* re: serial: Add Milbeaut serial control
@ 2019-05-02 11:47 Colin Ian King
2019-05-08 12:55 ` Sugaya, Taichi
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2019-05-02 11:47 UTC (permalink / raw)
To: Sugaya Taichi; +Cc: Greg Kroah-Hartman, Jiri Slaby, linux-serial, linux-kernel
Hi,
Static analysis with Coverity has picked up an issue in commit:
commit ba44dc04300441b47618f9933bf36e75a280e5fe
Author: Sugaya Taichi <sugaya.taichi@socionext.com>
Date: Mon Apr 15 20:31:40 2019 +0900
serial: Add Milbeaut serial control
In function mlb_usio_rx_chars() the u8 status is being bit-wise AND'd
with MLB_USIO_SSR_BRK (which is 1UL << 8) and hence the result is always
false, which looks incorrect to me. Is this intentional?
Colin
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: serial: Add Milbeaut serial control
2019-05-02 11:47 serial: Add Milbeaut serial control Colin Ian King
@ 2019-05-08 12:55 ` Sugaya, Taichi
0 siblings, 0 replies; 2+ messages in thread
From: Sugaya, Taichi @ 2019-05-08 12:55 UTC (permalink / raw)
To: Colin Ian King; +Cc: Greg Kroah-Hartman, Jiri Slaby, linux-serial, linux-kernel
Hi,
Thank you for pointing out.
On 2019/05/02 20:47, Colin Ian King wrote:
> Hi,
>
> Static analysis with Coverity has picked up an issue in commit:
>
> commit ba44dc04300441b47618f9933bf36e75a280e5fe
> Author: Sugaya Taichi <sugaya.taichi@socionext.com>
> Date: Mon Apr 15 20:31:40 2019 +0900
>
> serial: Add Milbeaut serial control
>
> In function mlb_usio_rx_chars() the u8 status is being bit-wise AND'd
> with MLB_USIO_SSR_BRK (which is 1UL << 8) and hence the result is always
> false, which looks incorrect to me. Is this intentional?
>
No. It is always false so should be dropped.
I will send a fixes patch.
Thanks,
Sugaya Taichi
> Colin
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-05-08 12:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-02 11:47 serial: Add Milbeaut serial control Colin Ian King
2019-05-08 12:55 ` Sugaya, Taichi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).