v4.15-rc2 on thinkpad x60: ethernet stopped working

v4.15-rc2 on thinkpad x60: ethernet stopped working

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 899 bytes --]

Hi!

In v4.15-rc2+, network manager can not see my ethernet card, and
manual attempts to ifconfig it up did not really help, either.

Card is:

02:00.0 Ethernet controller: Intel Corporation 82573L Gigabit Ethernet
Controller

Dmesg says:

  dmesg | grep eth
[    0.648931] e1000e 0000:02:00.0 eth0: (PCI Express:2.5GT/s:Width
x1) 00:16:d3:25:19:04
[    0.648934] e1000e 0000:02:00.0 eth0: Intel(R) PRO/1000 Network
Connection
[    0.649012] e1000e 0000:02:00.0 eth0: MAC: 2, PHY: 2, PBA No:
005302-003
[    0.706510] usbcore: registered new interface driver cdc_ether
[    6.557022] e1000e 0000:02:00.0 eth1: renamed from eth0
[    6.577554] systemd-udevd[2363]: renamed network interface eth0 to
eth1

Any ideas?
									Pavel


-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

Re: v4.15-rc2 on thinkpad x60: ethernet stopped working

[Gabriel C]

On 10.12.2017 09:39, Pavel Machek wrote:
> Hi!

Hi,

> In v4.15-rc2+, network manager can not see my ethernet card, and
> manual attempts to ifconfig it up did not really help, either.
> 
> Card is:
> 
> 02:00.0 Ethernet controller: Intel Corporation 82573L Gigabit Ethernet
> Controller
> 
> Dmesg says:
> 
>    dmesg | grep eth
> [    0.648931] e1000e 0000:02:00.0 eth0: (PCI Express:2.5GT/s:Width
> x1) 00:16:d3:25:19:04
> [    0.648934] e1000e 0000:02:00.0 eth0: Intel(R) PRO/1000 Network
> Connection
> [    0.649012] e1000e 0000:02:00.0 eth0: MAC: 2, PHY: 2, PBA No:
> 005302-003
> [    0.706510] usbcore: registered new interface driver cdc_ether
> [    6.557022] e1000e 0000:02:00.0 eth1: renamed from eth0
> [    6.577554] systemd-udevd[2363]: renamed network interface eth0 to
> eth1
> 
> Any ideas ?

Yes , 19110cfbb34d4af0cdfe14cd243f3b09dc95b013 broke it.

See:
https://bugzilla.kernel.org/show_bug.cgi?id=198047

Fix there :
https://marc.info/?l=linux-kernel&m=151272209903675&w=2

Regards,

Gabriel C

Re: v4.15-rc2 on thinkpad x60: ethernet stopped working

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 755 bytes --]

Hi!

> >In v4.15-rc2+, network manager can not see my ethernet card, and
> >manual attempts to ifconfig it up did not really help, either.
> >
> >Card is:
> >
> >02:00.0 Ethernet controller: Intel Corporation 82573L Gigabit Ethernet
> >Controller
....
> >Any ideas ?
> 
> Yes , 19110cfbb34d4af0cdfe14cd243f3b09dc95b013 broke it.
> 
> See:
> https://bugzilla.kernel.org/show_bug.cgi?id=198047
> 
> Fix there :
> https://marc.info/?l=linux-kernel&m=151272209903675&w=2

I don't see the patch in latest mainline. Not having ethernet
is... somehow annoying. What is going on there?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

Re: v4.15-rc2 on thinkpad x60: ethernet stopped working

[David Miller]

From: Pavel Machek <pavel@ucw.cz>
Date: Fri, 15 Dec 2017 10:28:49 +0100

> Hi!
> 
>> >In v4.15-rc2+, network manager can not see my ethernet card, and
>> >manual attempts to ifconfig it up did not really help, either.
>> >
>> >Card is:
>> >
>> >02:00.0 Ethernet controller: Intel Corporation 82573L Gigabit Ethernet
>> >Controller
> ....
>> >Any ideas ?
>> 
>> Yes , 19110cfbb34d4af0cdfe14cd243f3b09dc95b013 broke it.
>> 
>> See:
>> https://bugzilla.kernel.org/show_bug.cgi?id=198047
>> 
>> Fix there :
>> https://marc.info/?l=linux-kernel&m=151272209903675&w=2
> 
> I don't see the patch in latest mainline. Not having ethernet
> is... somehow annoying. What is going on there?

Generally speaking, e1000 maintainence has been handled very poorly over
the past few years, I have to say.

Fixes take forever to propagate even when someone other than the
maintainer provides a working and tested fix, just like this case.

Jeff, please take e1000 maintainence seriously and get these critical
bug fixes propagated.

Thank you.

RE: v4.15-rc2 on thinkpad x60: ethernet stopped working

[Keller, Jacob E]

> -----Original Message-----
> From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org]
> On Behalf Of Gabriel C
> Sent: Sunday, December 10, 2017 4:44 AM
> To: Pavel Machek <pavel@ucw.cz>; kernel list <linux-kernel@vger.kernel.org>
> Cc: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>; intel-wired-
> lan@lists.osuosl.org; netdev@vger.kernel.org
> Subject: Re: v4.15-rc2 on thinkpad x60: ethernet stopped working
> 
> On 10.12.2017 09:39, Pavel Machek wrote:
> > Hi!
> 
> Hi,
> 
> > In v4.15-rc2+, network manager can not see my ethernet card, and
> > manual attempts to ifconfig it up did not really help, either.
> >
> > Card is:
> >
> > 02:00.0 Ethernet controller: Intel Corporation 82573L Gigabit Ethernet
> > Controller
> >
> > Dmesg says:
> >
> >    dmesg | grep eth
> > [    0.648931] e1000e 0000:02:00.0 eth0: (PCI Express:2.5GT/s:Width
> > x1) 00:16:d3:25:19:04
> > [    0.648934] e1000e 0000:02:00.0 eth0: Intel(R) PRO/1000 Network
> > Connection
> > [    0.649012] e1000e 0000:02:00.0 eth0: MAC: 2, PHY: 2, PBA No:
> > 005302-003
> > [    0.706510] usbcore: registered new interface driver cdc_ether
> > [    6.557022] e1000e 0000:02:00.0 eth1: renamed from eth0
> > [    6.577554] systemd-udevd[2363]: renamed network interface eth0 to
> > eth1
> >
> > Any ideas ?
> 
> Yes , 19110cfbb34d4af0cdfe14cd243f3b09dc95b013 broke it.
> 
> See:
> https://bugzilla.kernel.org/show_bug.cgi?id=198047
> 
> Fix there :
> https://marc.info/?l=linux-kernel&m=151272209903675&w=2
> 
> Regards,
> 
> Gabriel C

Hi,

Digging into this, the problem is complicated. The original bug assumed behavior of the .check_for_link call, which is universally not implemented.

I think the correct fix is to revert 19110cfbb34d ("e1000e: Separate signaling for link check/link up", 2017-10-10) and find a more proper solution.

I don't think any other code which uses check_for_link expects the interface to return in the way this patch attempted.

Thanks,
Jake

RE: v4.15-rc2 on thinkpad x60: ethernet stopped working

[Keller, Jacob E]

> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On Behalf Of
> Keller, Jacob E
> Sent: Friday, December 15, 2017 9:29 AM
> To: Gabriel C <nix.or.die@gmail.com>; Pavel Machek <pavel@ucw.cz>; kernel list
> <linux-kernel@vger.kernel.org>
> Cc: netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org
> Subject: Re: [Intel-wired-lan] v4.15-rc2 on thinkpad x60: ethernet stopped
> working
> 
> > -----Original Message-----
> > From: netdev-owner@vger.kernel.org [mailto:netdev-
> owner@vger.kernel.org]
> > On Behalf Of Gabriel C
> > Sent: Sunday, December 10, 2017 4:44 AM
> > To: Pavel Machek <pavel@ucw.cz>; kernel list <linux-kernel@vger.kernel.org>
> > Cc: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>; intel-wired-
> > lan@lists.osuosl.org; netdev@vger.kernel.org
> > Subject: Re: v4.15-rc2 on thinkpad x60: ethernet stopped working
> >
> > On 10.12.2017 09:39, Pavel Machek wrote:
> > > Hi!
> >
> > Hi,
> >
> > > In v4.15-rc2+, network manager can not see my ethernet card, and
> > > manual attempts to ifconfig it up did not really help, either.
> > >
> > > Card is:
> > >
> > > 02:00.0 Ethernet controller: Intel Corporation 82573L Gigabit Ethernet
> > > Controller
> > >
> > > Dmesg says:
> > >
> > >    dmesg | grep eth
> > > [    0.648931] e1000e 0000:02:00.0 eth0: (PCI Express:2.5GT/s:Width
> > > x1) 00:16:d3:25:19:04
> > > [    0.648934] e1000e 0000:02:00.0 eth0: Intel(R) PRO/1000 Network
> > > Connection
> > > [    0.649012] e1000e 0000:02:00.0 eth0: MAC: 2, PHY: 2, PBA No:
> > > 005302-003
> > > [    0.706510] usbcore: registered new interface driver cdc_ether
> > > [    6.557022] e1000e 0000:02:00.0 eth1: renamed from eth0
> > > [    6.577554] systemd-udevd[2363]: renamed network interface eth0 to
> > > eth1
> > >
> > > Any ideas ?
> >
> > Yes , 19110cfbb34d4af0cdfe14cd243f3b09dc95b013 broke it.
> >
> > See:
> > https://bugzilla.kernel.org/show_bug.cgi?id=198047
> >
> > Fix there :
> > https://marc.info/?l=linux-kernel&m=151272209903675&w=2
> >
> > Regards,
> >
> > Gabriel C
> 
> Hi,
> 
> Digging into this, the problem is complicated. The original bug assumed behavior
> of the .check_for_link call, which is universally not implemented.
> 
> I think the correct fix is to revert 19110cfbb34d ("e1000e: Separate signaling for
> link check/link up", 2017-10-10) and find a more proper solution.
> 
> I don't think any other code which uses check_for_link expects the interface to
> return in the way this patch attempted.
> 
> Thanks,
> Jake
> 

Alternatively, we can go a step farther and make sure every implementation of .check_for_link follows the modified interface.

Thanks,
Jake

Re: v4.15-rc2 on thinkpad x60: ethernet stopped working

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 1169 bytes --]

Hi!

> > > > Any ideas ?
> > >
> > > Yes , 19110cfbb34d4af0cdfe14cd243f3b09dc95b013 broke it.
> > >
> > > See:
> > > https://bugzilla.kernel.org/show_bug.cgi?id=198047
> > >
> > > Fix there :
> > > https://marc.info/?l=linux-kernel&m=151272209903675&w=2
> > >
> > > Regards,
> > >
> > > Gabriel C
> > 
> > Hi,
> > 
> > Digging into this, the problem is complicated. The original bug assumed behavior
> > of the .check_for_link call, which is universally not implemented.
> > 
> > I think the correct fix is to revert 19110cfbb34d ("e1000e: Separate signaling for
> > link check/link up", 2017-10-10) and find a more proper solution.
> > 
> > I don't think any other code which uses check_for_link expects the interface to
> > return in the way this patch attempted.

> Alternatively, we can go a step farther and make sure every implementation of .check_for_link follows the modified interface.
> 

We are at -rc3 now. Reverting 19110cfbb34d seems like good solution at
the moment.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

Re: v4.15-rc2 on thinkpad x60: ethernet stopped working

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 1306 bytes --]

Hi!

> >> >In v4.15-rc2+, network manager can not see my ethernet card, and
> >> >manual attempts to ifconfig it up did not really help, either.
> >> >
> >> >Card is:
> >> >
> >> >02:00.0 Ethernet controller: Intel Corporation 82573L Gigabit Ethernet
> >> >Controller
> > ....
> >> >Any ideas ?
> >> 
> >> Yes , 19110cfbb34d4af0cdfe14cd243f3b09dc95b013 broke it.
> >> 
> >> See:
> >> https://bugzilla.kernel.org/show_bug.cgi?id=198047
> >> 
> >> Fix there :
> >> https://marc.info/?l=linux-kernel&m=151272209903675&w=2
> > 
> > I don't see the patch in latest mainline. Not having ethernet
> > is... somehow annoying. What is going on there?
> 
> Generally speaking, e1000 maintainence has been handled very poorly over
> the past few years, I have to say.
> 
> Fixes take forever to propagate even when someone other than the
> maintainer provides a working and tested fix, just like this case.
> 
> Jeff, please take e1000 maintainence seriously and get these critical
> bug fixes propagated.

No response AFAICT. I guess I should test reverting
19110cfbb34d4af0cdfe14cd243f3b09dc95b013, then ask you for revert?

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

Re: [Intel-wired-lan] v4.15-rc2 on thinkpad x60: ethernet stopped working

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 1999 bytes --]

On Mon 2017-12-18 13:24:40, Neftin, Sasha wrote:
> On 12/18/2017 12:26, Pavel Machek wrote:
> >Hi!
> >
> >>>>>In v4.15-rc2+, network manager can not see my ethernet card, and
> >>>>>manual attempts to ifconfig it up did not really help, either.
> >>>>>
> >>>>>Card is:
> >>>>>
> >>>>>02:00.0 Ethernet controller: Intel Corporation 82573L Gigabit Ethernet
> >>>>>Controller
> >>>....
> >>>>>Any ideas ?
> >>>>Yes , 19110cfbb34d4af0cdfe14cd243f3b09dc95b013 broke it.
> >>>>
> >>>>See:
> >>>>https://bugzilla.kernel.org/show_bug.cgi?id=198047
> >>>>
> >>>>Fix there :
> >>>>https://marc.info/?l=linux-kernel&m=151272209903675&w=2
> >>>I don't see the patch in latest mainline. Not having ethernet
> >>>is... somehow annoying. What is going on there?
> >>Generally speaking, e1000 maintainence has been handled very poorly over
> >>the past few years, I have to say.
> >>
> >>Fixes take forever to propagate even when someone other than the
> >>maintainer provides a working and tested fix, just like this case.
> >>
> >>Jeff, please take e1000 maintainence seriously and get these critical
> >>bug fixes propagated.
> >No response AFAICT. I guess I should test reverting
> >19110cfbb34d4af0cdfe14cd243f3b09dc95b013, then ask you for revert?
> 
> Hello Pavel,
> 
> Before ask for reverting 19110cfbb..., please, check if follow patch of
> Benjamin work for you http://patchwork.ozlabs.org/patch/846825/

Jacob said, in another email:

# Digging into this, the problem is complicated. The original bug
# assumed behavior of the .check_for_link call, which is universally not
# implemented.
# 
# I think the correct fix is to revert 19110cfbb34d ("e1000e: Separate
# signaling for link check/link up", 2017-10-10) and find a more proper solution.

...which makes me think that revert is preffered?

									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

Re: [Intel-wired-lan] v4.15-rc2 on thinkpad x60: ethernet stopped working

[Neftin, Sasha]

On 12/18/2017 13:58, Pavel Machek wrote:
> On Mon 2017-12-18 13:24:40, Neftin, Sasha wrote:
>> On 12/18/2017 12:26, Pavel Machek wrote:
>>> Hi!
>>>
>>>>>>> In v4.15-rc2+, network manager can not see my ethernet card, and
>>>>>>> manual attempts to ifconfig it up did not really help, either.
>>>>>>>
>>>>>>> Card is:
>>>>>>>
>>>>>>> 02:00.0 Ethernet controller: Intel Corporation 82573L Gigabit Ethernet
>>>>>>> Controller
>>>>> ....
>>>>>>> Any ideas ?
>>>>>> Yes , 19110cfbb34d4af0cdfe14cd243f3b09dc95b013 broke it.
>>>>>>
>>>>>> See:
>>>>>> https://bugzilla.kernel.org/show_bug.cgi?id=198047
>>>>>>
>>>>>> Fix there :
>>>>>> https://marc.info/?l=linux-kernel&m=151272209903675&w=2
>>>>> I don't see the patch in latest mainline. Not having ethernet
>>>>> is... somehow annoying. What is going on there?
>>>> Generally speaking, e1000 maintainence has been handled very poorly over
>>>> the past few years, I have to say.
>>>>
>>>> Fixes take forever to propagate even when someone other than the
>>>> maintainer provides a working and tested fix, just like this case.
>>>>
>>>> Jeff, please take e1000 maintainence seriously and get these critical
>>>> bug fixes propagated.
>>> No response AFAICT. I guess I should test reverting
>>> 19110cfbb34d4af0cdfe14cd243f3b09dc95b013, then ask you for revert?
>> Hello Pavel,
>>
>> Before ask for reverting 19110cfbb..., please, check if follow patch of
>> Benjamin work for you http://patchwork.ozlabs.org/patch/846825/
> Jacob said, in another email:
>
> # Digging into this, the problem is complicated. The original bug
> # assumed behavior of the .check_for_link call, which is universally not
> # implemented.
> #
> # I think the correct fix is to revert 19110cfbb34d ("e1000e: Separate
> # signaling for link check/link up", 2017-10-10) and find a more proper solution.
>
> ...which makes me think that revert is preffered?
>
> 									Pavel
>
Pavel, before ask for revert - let's check Benjamin's patch following to 
his previous patch. Previous patch was not competed and latest one come 
to complete changes.

RE: [Intel-wired-lan] v4.15-rc2 on thinkpad x60: ethernet stopped working

[Fujinaka, Todd]

Jeff was out sick last week. It might take him a bit to catch up.

I'll remind him when I see him next (which I hope is soon).

Todd Fujinaka
Software Application Engineer
Datacenter Engineering Group
Intel Corporation
todd.fujinaka@intel.com

-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On Behalf Of Neftin, Sasha
Sent: Monday, December 18, 2017 7:50 AM
To: Pavel Machek <pavel@ucw.cz>; Keller, Jacob E <jacob.e.keller@intel.com>
Cc: bpoirier@suse.com; nix.or.die@gmail.com; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; intel-wired-lan@lists.osuosl.org; lsorense@csclub.uwaterloo.ca; David Miller <davem@davemloft.net>
Subject: Re: [Intel-wired-lan] v4.15-rc2 on thinkpad x60: ethernet stopped working

On 12/18/2017 13:58, Pavel Machek wrote:
> On Mon 2017-12-18 13:24:40, Neftin, Sasha wrote:
>> On 12/18/2017 12:26, Pavel Machek wrote:
>>> Hi!
>>>
>>>>>>> In v4.15-rc2+, network manager can not see my ethernet card, and 
>>>>>>> manual attempts to ifconfig it up did not really help, either.
>>>>>>>
>>>>>>> Card is:
>>>>>>>
>>>>>>> 02:00.0 Ethernet controller: Intel Corporation 82573L Gigabit 
>>>>>>> Ethernet Controller
>>>>> ....
>>>>>>> Any ideas ?
>>>>>> Yes , 19110cfbb34d4af0cdfe14cd243f3b09dc95b013 broke it.
>>>>>>
>>>>>> See:
>>>>>> https://bugzilla.kernel.org/show_bug.cgi?id=198047
>>>>>>
>>>>>> Fix there :
>>>>>> https://marc.info/?l=linux-kernel&m=151272209903675&w=2
>>>>> I don't see the patch in latest mainline. Not having ethernet 
>>>>> is... somehow annoying. What is going on there?
>>>> Generally speaking, e1000 maintainence has been handled very poorly 
>>>> over the past few years, I have to say.
>>>>
>>>> Fixes take forever to propagate even when someone other than the 
>>>> maintainer provides a working and tested fix, just like this case.
>>>>
>>>> Jeff, please take e1000 maintainence seriously and get these 
>>>> critical bug fixes propagated.
>>> No response AFAICT. I guess I should test reverting 
>>> 19110cfbb34d4af0cdfe14cd243f3b09dc95b013, then ask you for revert?
>> Hello Pavel,
>>
>> Before ask for reverting 19110cfbb..., please, check if follow patch 
>> of Benjamin work for you http://patchwork.ozlabs.org/patch/846825/
> Jacob said, in another email:
>
> # Digging into this, the problem is complicated. The original bug # 
> assumed behavior of the .check_for_link call, which is universally not 
> # implemented.
> #
> # I think the correct fix is to revert 19110cfbb34d ("e1000e: Separate 
> # signaling for link check/link up", 2017-10-10) and find a more proper solution.
>
> ...which makes me think that revert is preffered?
>
> 									Pavel
>
Pavel, before ask for revert - let's check Benjamin's patch following to his previous patch. Previous patch was not competed and latest one come to complete changes.

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

Re: [Intel-wired-lan] v4.15-rc2 on thinkpad x60: ethernet stopped working

[Neftin, Sasha]

On 12/18/2017 17:50, Neftin, Sasha wrote:
> On 12/18/2017 13:58, Pavel Machek wrote:
>> On Mon 2017-12-18 13:24:40, Neftin, Sasha wrote:
>>> On 12/18/2017 12:26, Pavel Machek wrote:
>>>> Hi!
>>>>
>>>>>>>> In v4.15-rc2+, network manager can not see my ethernet card, and
>>>>>>>> manual attempts to ifconfig it up did not really help, either.
>>>>>>>>
>>>>>>>> Card is:
>>>>>>>>
>>>>>>>> 02:00.0 Ethernet controller: Intel Corporation 82573L Gigabit 
>>>>>>>> Ethernet
>>>>>>>> Controller
>>>>>> ....
>>>>>>>> Any ideas ?
>>>>>>> Yes , 19110cfbb34d4af0cdfe14cd243f3b09dc95b013 broke it.
>>>>>>>
>>>>>>> See:
>>>>>>> https://bugzilla.kernel.org/show_bug.cgi?id=198047
>>>>>>>
>>>>>>> Fix there :
>>>>>>> https://marc.info/?l=linux-kernel&m=151272209903675&w=2
>>>>>> I don't see the patch in latest mainline. Not having ethernet
>>>>>> is... somehow annoying. What is going on there?
>>>>> Generally speaking, e1000 maintainence has been handled very 
>>>>> poorly over
>>>>> the past few years, I have to say.
>>>>>
>>>>> Fixes take forever to propagate even when someone other than the
>>>>> maintainer provides a working and tested fix, just like this case.
>>>>>
>>>>> Jeff, please take e1000 maintainence seriously and get these critical
>>>>> bug fixes propagated.
>>>> No response AFAICT. I guess I should test reverting
>>>> 19110cfbb34d4af0cdfe14cd243f3b09dc95b013, then ask you for revert?
>>> Hello Pavel,
>>>
>>> Before ask for reverting 19110cfbb..., please, check if follow patch of
>>> Benjamin work for you http://patchwork.ozlabs.org/patch/846825/
>> Jacob said, in another email:
>>
>> # Digging into this, the problem is complicated. The original bug
>> # assumed behavior of the .check_for_link call, which is universally not
>> # implemented.
>> #
>> # I think the correct fix is to revert 19110cfbb34d ("e1000e: Separate
>> # signaling for link check/link up", 2017-10-10) and find a more 
>> proper solution.
>>
>> ...which makes me think that revert is preffered?
>>
>>                                     Pavel
>>
> Pavel, before ask for revert - let's check Benjamin's patch following 
> to his previous patch. Previous patch was not competed and latest one 
> come to complete changes.
>
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan@osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

Pavel, any update? Is Benjamin's last patch solved your network problem?

Re: [Intel-wired-lan] v4.15-rc2 on thinkpad x60: ethernet stopped working

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 619 bytes --]

Hi!

> >> Before ask for reverting 19110cfbb..., please, check if follow patch 
> >> of Benjamin work for you http://patchwork.ozlabs.org/patch/846825/

> >
> Pavel, before ask for revert - let's check Benjamin's patch following to his previous patch. Previous patch was not competed and latest one come to complete changes.
>

v4.15-rc4+:

Ethernet works with 19110cfbb reverted.

Ethernet works With patchwork.ozlabs.org/patch/846825/ applied.


									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

Re: [Intel-wired-lan] v4.15-rc2 on thinkpad x60: ethernet stopped working

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 962 bytes --]

On Wed 2017-12-20 16:54:21, Pavel Machek wrote:
> Hi!
> 
> > >> Before ask for reverting 19110cfbb..., please, check if follow patch 
> > >> of Benjamin work for you http://patchwork.ozlabs.org/patch/846825/
> 
> > >
> > Pavel, before ask for revert - let's check Benjamin's patch following to his previous patch. Previous patch was not competed and latest one come to complete changes.
> >
> 
> v4.15-rc4+:
> 
> Ethernet works with 19110cfbb reverted.
> 
> Ethernet works With patchwork.ozlabs.org/patch/846825/ applied.

Hmm. So... ethernet originally did not work with patch/846825/ applied
or 19110cfbb reverted, so I re-plugged ethernet cables. Now it works
even with plain v4.15-rc4+.

So it looks like the bug was fixed in the mainline in the meantime...?

Sorry for the noise,
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

Re: [Intel-wired-lan] v4.15-rc2 on thinkpad x60: ethernet stopped working

[Neftin, Sasha]

On 20/12/2017 18:01, Pavel Machek wrote:
> On Wed 2017-12-20 16:54:21, Pavel Machek wrote:
>> Hi!
>>
>>>>> Before ask for reverting 19110cfbb..., please, check if follow patch
>>>>> of Benjamin work for you http://patchwork.ozlabs.org/patch/846825/
>>> Pavel, before ask for revert - let's check Benjamin's patch following to his previous patch. Previous patch was not competed and latest one come to complete changes.
>>>
>> v4.15-rc4+:
>>
>> Ethernet works with 19110cfbb reverted.
>>
>> Ethernet works With patchwork.ozlabs.org/patch/846825/ applied.
> Hmm. So... ethernet originally did not work with patch/846825/ applied
> or 19110cfbb reverted, so I re-plugged ethernet cables. Now it works
> even with plain v4.15-rc4+.
>
> So it looks like the bug was fixed in the mainline in the meantime...?
>
> Sorry for the noise,
> 								Pavel

Good Pavel, thanks for update us, let's keep both patch applied and see 
ethernet adapter behavior.

Re: [Intel-wired-lan] v4.15-rc2 on thinkpad x60: ethernet stopped working

[Paul Menzel]

[-- Attachment #1.1: Type: text/plain, Size: 1667 bytes --]

Dear Pavel,


On 12/10/17 09:39, Pavel Machek wrote:

> In v4.15-rc2+, network manager can not see my ethernet card, and 
> manual attempts to ifconfig it up did not really help, either.
> 
> Card is:
> 
> 02:00.0 Ethernet controller: Intel Corporation 82573L Gigabit
> Ethernet Controller
> 
> Dmesg says:
> 
>    dmesg | grep eth
> [    0.648931] e1000e 0000:02:00.0 eth0: (PCI Express:2.5GT/s:Width x1) 00:16:d3:25:19:04
> [    0.648934] e1000e 0000:02:00.0 eth0: Intel(R) PRO/1000 Network Connection
> [    0.649012] e1000e 0000:02:00.0 eth0: MAC: 2, PHY: 2, PBA No: 005302-003
> [    0.706510] usbcore: registered new interface driver cdc_ether
> [    6.557022] e1000e 0000:02:00.0 eth1: renamed from eth0
> [    6.577554] systemd-udevd[2363]: renamed network interface eth0 to eth1
> 
> Any ideas?

I am sorry for jumping in on this so late.

Since using a Lenovo X60t more ofter since a year or so, I experience 
the issue, that the link doesn’t come up during that period occasionally 
[1]. I haven’t tried the latest patches yet, but it might be unrelated.

Did you test, that removing and loading the e1000e module fixes the issue?

Additionally, I was asked privately to test the out of tree driver, but 
haven’t had time yet.

> You might give the out-of-tree driver a try, you can download it here
> https://downloadcenter.intel.com/download/26549/Intel-Network-Adapter-Driver-for-PCIe-Intel-Gigabit-Ethernet-Network-Connections-Under-Linux-?product=19297
>  It's version is 3.3.5, dated 8/2016

Kind regards,

Paul


[1] 
https://lists.osuosl.org/pipermail/intel-wired-lan/Week-of-Mon-20170410/008590.html

[-- Attachment #1.2: Attached Message --]
[-- Type: message/rfc822, Size: 6831 bytes --]

From: Paul Menzel <pmenzel@molgen.mpg.de>
To: "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>
Subject: [Intel-wired-lan] e1000e: Link down after startup on Lenovo X60
Date: Wed, 12 Apr 2017 16:31:45 +0200
Message-ID: <63a45041-39ca-1276-27e2-41d2b6dc7405@molgen.mpg.de>

Dear Linux folks,


On a Lenovo X60t, in very rare cases, the link does not get ready with 
Linux 4.11-rc6, and also versions before it.

```
02:00.0 Ethernet controller: Intel Corporation 82573L Gigabit Ethernet 
Controller
```

`ip a` shows that the link is down, and unplugging and plugging the 
network cable back in does not help.

```
$ journalctl -k -o short-precise | grep -i e1000e
Apr 11 23:07:48.553259 x60 kernel: e1000e: Intel(R) PRO/1000 Network 
Driver - 3.2.6-k
Apr 11 23:07:48.553319 x60 kernel: e1000e: Copyright(c) 1999 - 2015 
Intel Corporation.
Apr 11 23:07:48.553499 x60 kernel: e1000e 0000:01:00.0: Interrupt 
Throttling Rate (ints/sec) set to dynamic conservative mode
Apr 11 23:07:48.577368 x60 kernel: e1000e 0000:01:00.0 eth0: (PCI 
Express:2.5GT/s:Width x1) 00:16:d3:b8:e3:49
Apr 11 23:07:48.577529 x60 kernel: e1000e 0000:01:00.0 eth0: Intel(R) 
PRO/1000 Network Connection
Apr 11 23:07:48.577688 x60 kernel: e1000e 0000:01:00.0 eth0: MAC: 2, 
PHY: 2, PBA No: 005302-003
Apr 11 23:07:48.923514 x60 kernel: e1000e 0000:01:00.0 eth8: renamed 
from eth0
```

Removing the module *e1000e* and loading it again fixes the issue.

```
Apr 11 23:12:01.526318 x60 kernel: e1000e 0000:01:00.0: Disabling ASPM 
L0s L1
Apr 11 23:12:01.687420 x60 kernel: e1000e: eth8 NIC Link is Down
Apr 11 23:12:08.295555 x60 kernel: e1000e: Intel(R) PRO/1000 Network 
Driver - 3.2.6-k
Apr 11 23:12:08.295737 x60 kernel: e1000e: Copyright(c) 1999 - 2015 
Intel Corporation.
Apr 11 23:12:08.296006 x60 kernel: e1000e 0000:01:00.0: Interrupt 
Throttling Rate (ints/sec) set to dynamic conservative mode
Apr 11 23:12:08.421070 x60 kernel: e1000e 0000:01:00.0 eth0: (PCI 
Express:2.5GT/s:Width x1) 00:16:d3:b8:e3:49
Apr 11 23:12:08.421389 x60 kernel: e1000e 0000:01:00.0 eth0: Intel(R) 
PRO/1000 Network Connection
Apr 11 23:12:08.421642 x60 kernel: e1000e 0000:01:00.0 eth0: MAC: 2, 
PHY: 2, PBA No: 005302-003
Apr 11 23:12:08.423534 x60 kernel: e1000e 0000:01:00.0 eth8: renamed 
from eth0
Apr 11 23:12:11.609873 x60 kernel: e1000e: eth8 NIC Link is Up 1000 Mbps 
Full Duplex, Flow Control: Rx/Tx
```

Do you know, if that is a known problem? What other information should 
be added to a bug report?


Kind regards,

Paul
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@lists.osuosl.org
http://lists.osuosl.org/mailman/listinfo/intel-wired-lan

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5174 bytes --]