* [PATCH] scsi: advansys: Replace zero-length array with flexible-array member
@ 2020-02-13 0:02 Gustavo A. R. Silva
2020-02-13 1:14 ` Matthew Wilcox
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Gustavo A. R. Silva @ 2020-02-13 0:02 UTC (permalink / raw)
To: Matthew Wilcox, Hannes Reinecke, James E.J. Bottomley,
Martin K. Petersen
Cc: linux-scsi, linux-kernel, Gustavo A. R. Silva
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:
struct foo {
int stuff;
struct boo array[];
};
By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.
Also, notice that, dynamic memory allocations won't be affected by
this change:
"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/scsi/advansys.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index a242a62caaa1..c2c7850ff7b4 100644
--- a/drivers/scsi/advansys.c
+++ b/drivers/scsi/advansys.c
@@ -316,7 +316,7 @@ typedef struct asc_sg_head {
ushort queue_cnt;
ushort entry_to_copy;
ushort res;
- ASC_SG_LIST sg_list[0];
+ ASC_SG_LIST sg_list[];
} ASC_SG_HEAD;
typedef struct asc_scsi_q {
--
2.23.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] scsi: advansys: Replace zero-length array with flexible-array member
2020-02-13 0:02 [PATCH] scsi: advansys: Replace zero-length array with flexible-array member Gustavo A. R. Silva
@ 2020-02-13 1:14 ` Matthew Wilcox
2020-02-13 6:04 ` Gustavo A. R. Silva
2020-02-13 16:52 ` Hannes Reinecke
2020-02-18 5:28 ` Martin K. Petersen
2 siblings, 1 reply; 5+ messages in thread
From: Matthew Wilcox @ 2020-02-13 1:14 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Hannes Reinecke, James E.J. Bottomley, Martin K. Petersen,
linux-scsi, linux-kernel
On Wed, Feb 12, 2020 at 06:02:11PM -0600, Gustavo A. R. Silva wrote:
> Also, notice that, dynamic memory allocations won't be affected by
> this change:
Shouldn't you also convert this:
asc_sg_head = kzalloc(sizeof(asc_scsi_q->sg_head) +
use_sg * sizeof(struct asc_sg_list), GFP_ATOMIC);
to use struct_size()?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] scsi: advansys: Replace zero-length array with flexible-array member
2020-02-13 1:14 ` Matthew Wilcox
@ 2020-02-13 6:04 ` Gustavo A. R. Silva
0 siblings, 0 replies; 5+ messages in thread
From: Gustavo A. R. Silva @ 2020-02-13 6:04 UTC (permalink / raw)
To: Matthew Wilcox
Cc: Hannes Reinecke, James E.J. Bottomley, Martin K. Petersen,
linux-scsi, linux-kernel
On 2/12/20 19:14, Matthew Wilcox wrote:
> On Wed, Feb 12, 2020 at 06:02:11PM -0600, Gustavo A. R. Silva wrote:
>> Also, notice that, dynamic memory allocations won't be affected by
>> this change:
>
> Shouldn't you also convert this:
> asc_sg_head = kzalloc(sizeof(asc_scsi_q->sg_head) +
> use_sg * sizeof(struct asc_sg_list), GFP_ATOMIC);
> to use struct_size()?
>
It's not a requirement to do that prior to applying the change proposed by
this patch.
Thanks
--
Gustavo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] scsi: advansys: Replace zero-length array with flexible-array member
2020-02-13 0:02 [PATCH] scsi: advansys: Replace zero-length array with flexible-array member Gustavo A. R. Silva
2020-02-13 1:14 ` Matthew Wilcox
@ 2020-02-13 16:52 ` Hannes Reinecke
2020-02-18 5:28 ` Martin K. Petersen
2 siblings, 0 replies; 5+ messages in thread
From: Hannes Reinecke @ 2020-02-13 16:52 UTC (permalink / raw)
To: Gustavo A. R. Silva, Matthew Wilcox, Hannes Reinecke,
James E.J. Bottomley, Martin K. Petersen
Cc: linux-scsi, linux-kernel
On 2/13/20 1:02 AM, Gustavo A. R. Silva wrote:
> The current codebase makes use of the zero-length array language
> extension to the C90 standard, but the preferred mechanism to declare
> variable-length types such as these ones is a flexible array member[1][2],
> introduced in C99:
>
> struct foo {
> int stuff;
> struct boo array[];
> };
>
> By making use of the mechanism above, we will get a compiler warning
> in case the flexible array does not occur last in the structure, which
> will help us prevent some kind of undefined behavior bugs from being
> inadvertently introduced[3] to the codebase from now on.
>
> Also, notice that, dynamic memory allocations won't be affected by
> this change:
>
> "Flexible array members have incomplete type, and so the sizeof operator
> may not be applied. As a quirk of the original implementation of
> zero-length arrays, sizeof evaluates to zero."[1]
>
> This issue was found with the help of Coccinelle.
>
> [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
> [2] https://github.com/KSPP/linux/issues/21
> [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/scsi/advansys.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
> index a242a62caaa1..c2c7850ff7b4 100644
> --- a/drivers/scsi/advansys.c
> +++ b/drivers/scsi/advansys.c
> @@ -316,7 +316,7 @@ typedef struct asc_sg_head {
> ushort queue_cnt;
> ushort entry_to_copy;
> ushort res;
> - ASC_SG_LIST sg_list[0];
> + ASC_SG_LIST sg_list[];
> } ASC_SG_HEAD;
>
> typedef struct asc_scsi_q {
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] scsi: advansys: Replace zero-length array with flexible-array member
2020-02-13 0:02 [PATCH] scsi: advansys: Replace zero-length array with flexible-array member Gustavo A. R. Silva
2020-02-13 1:14 ` Matthew Wilcox
2020-02-13 16:52 ` Hannes Reinecke
@ 2020-02-18 5:28 ` Martin K. Petersen
2 siblings, 0 replies; 5+ messages in thread
From: Martin K. Petersen @ 2020-02-18 5:28 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Matthew Wilcox, Hannes Reinecke, James E.J. Bottomley,
Martin K. Petersen, linux-scsi, linux-kernel
Gustavo,
> The current codebase makes use of the zero-length array language
> extension to the C90 standard, but the preferred mechanism to declare
> variable-length types such as these ones is a flexible array member[1][2],
> introduced in C99:
Applied to 5.7/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-02-18 5:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-13 0:02 [PATCH] scsi: advansys: Replace zero-length array with flexible-array member Gustavo A. R. Silva
2020-02-13 1:14 ` Matthew Wilcox
2020-02-13 6:04 ` Gustavo A. R. Silva
2020-02-13 16:52 ` Hannes Reinecke
2020-02-18 5:28 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).