* [PATCH] rtw89: use flexible array member in rtw89_btc_btf_tlv
@ 2023-05-23 11:32 Arnd Bergmann
2023-05-24 1:24 ` Ping-Ke Shih
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Arnd Bergmann @ 2023-05-23 11:32 UTC (permalink / raw)
To: Ping-Ke Shih, Kalle Valo
Cc: Arnd Bergmann, Ching-Te Ku, linux-wireless, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
struct rtw89_btc_btf_tlv contains a one-byte member that is intended as a
flexible array:
In function 'fortify_memcpy_chk',
inlined from '_append_tdma' at drivers/net/wireless/realtek/rtw89/coex.c:1579:3:
include/linux/fortify-string.h:583:25: error: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Werror=attribute-warning]
583 | __write_overflow_field(p_size_field, size);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Make this actually use a flexible array to let the compiler understand.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/wireless/realtek/rtw89/coex.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtw89/coex.c b/drivers/net/wireless/realtek/rtw89/coex.c
index 3a586a971e8f..bda0e1e99a8c 100644
--- a/drivers/net/wireless/realtek/rtw89/coex.c
+++ b/drivers/net/wireless/realtek/rtw89/coex.c
@@ -206,7 +206,7 @@ static const struct rtw89_btc_ver rtw89_btc_ver_defs[] = {
struct rtw89_btc_btf_tlv {
u8 type;
u8 len;
- u8 val[1];
+ u8 val[];
} __packed;
enum btc_btf_set_report_en {
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH] rtw89: use flexible array member in rtw89_btc_btf_tlv
2023-05-23 11:32 [PATCH] rtw89: use flexible array member in rtw89_btc_btf_tlv Arnd Bergmann
@ 2023-05-24 1:24 ` Ping-Ke Shih
2023-05-24 10:43 ` Gustavo A. R. Silva
2023-05-25 16:14 ` wifi: " Kalle Valo
2 siblings, 0 replies; 4+ messages in thread
From: Ping-Ke Shih @ 2023-05-24 1:24 UTC (permalink / raw)
To: Arnd Bergmann, Kalle Valo
Cc: Arnd Bergmann, DeanKu, linux-wireless, linux-kernel
> -----Original Message-----
> From: Arnd Bergmann <arnd@kernel.org>
> Sent: Tuesday, May 23, 2023 7:33 PM
> To: Ping-Ke Shih <pkshih@realtek.com>; Kalle Valo <kvalo@kernel.org>
> Cc: Arnd Bergmann <arnd@arndb.de>; DeanKu <ku920601@realtek.com>; linux-wireless@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Subject: [PATCH] rtw89: use flexible array member in rtw89_btc_btf_tlv
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> struct rtw89_btc_btf_tlv contains a one-byte member that is intended as a
> flexible array:
>
> In function 'fortify_memcpy_chk',
> inlined from '_append_tdma' at drivers/net/wireless/realtek/rtw89/coex.c:1579:3:
> include/linux/fortify-string.h:583:25: error: call to '__write_overflow_field' declared with attribute
> warning: detected write beyond size of field (1st parameter); maybe use struct_group()?
> [-Werror=attribute-warning]
> 583 | __write_overflow_field(p_size_field, size);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Make this actually use a flexible array to let the compiler understand.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>
> ---
> drivers/net/wireless/realtek/rtw89/coex.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw89/coex.c b/drivers/net/wireless/realtek/rtw89/coex.c
> index 3a586a971e8f..bda0e1e99a8c 100644
> --- a/drivers/net/wireless/realtek/rtw89/coex.c
> +++ b/drivers/net/wireless/realtek/rtw89/coex.c
> @@ -206,7 +206,7 @@ static const struct rtw89_btc_ver rtw89_btc_ver_defs[] = {
> struct rtw89_btc_btf_tlv {
> u8 type;
> u8 len;
> - u8 val[1];
> + u8 val[];
> } __packed;
>
> enum btc_btf_set_report_en {
> --
> 2.39.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] rtw89: use flexible array member in rtw89_btc_btf_tlv
2023-05-23 11:32 [PATCH] rtw89: use flexible array member in rtw89_btc_btf_tlv Arnd Bergmann
2023-05-24 1:24 ` Ping-Ke Shih
@ 2023-05-24 10:43 ` Gustavo A. R. Silva
2023-05-25 16:14 ` wifi: " Kalle Valo
2 siblings, 0 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2023-05-24 10:43 UTC (permalink / raw)
To: Arnd Bergmann, Ping-Ke Shih, Kalle Valo
Cc: Arnd Bergmann, Ching-Te Ku, linux-wireless, linux-kernel
On 5/23/23 05:32, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> struct rtw89_btc_btf_tlv contains a one-byte member that is intended as a
> flexible array:
>
> In function 'fortify_memcpy_chk',
> inlined from '_append_tdma' at drivers/net/wireless/realtek/rtw89/coex.c:1579:3:
> include/linux/fortify-string.h:583:25: error: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Werror=attribute-warning]
> 583 | __write_overflow_field(p_size_field, size);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Make this actually use a flexible array to let the compiler understand.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Thanks!
--
Gustavo
> ---
> drivers/net/wireless/realtek/rtw89/coex.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw89/coex.c b/drivers/net/wireless/realtek/rtw89/coex.c
> index 3a586a971e8f..bda0e1e99a8c 100644
> --- a/drivers/net/wireless/realtek/rtw89/coex.c
> +++ b/drivers/net/wireless/realtek/rtw89/coex.c
> @@ -206,7 +206,7 @@ static const struct rtw89_btc_ver rtw89_btc_ver_defs[] = {
> struct rtw89_btc_btf_tlv {
> u8 type;
> u8 len;
> - u8 val[1];
> + u8 val[];
> } __packed;
>
> enum btc_btf_set_report_en {
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: wifi: rtw89: use flexible array member in rtw89_btc_btf_tlv
2023-05-23 11:32 [PATCH] rtw89: use flexible array member in rtw89_btc_btf_tlv Arnd Bergmann
2023-05-24 1:24 ` Ping-Ke Shih
2023-05-24 10:43 ` Gustavo A. R. Silva
@ 2023-05-25 16:14 ` Kalle Valo
2 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2023-05-25 16:14 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Ping-Ke Shih, Arnd Bergmann, Ching-Te Ku, linux-wireless, linux-kernel
Arnd Bergmann <arnd@kernel.org> wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> struct rtw89_btc_btf_tlv contains a one-byte member that is intended as a
> flexible array:
>
> In function 'fortify_memcpy_chk',
> inlined from '_append_tdma' at drivers/net/wireless/realtek/rtw89/coex.c:1579:3:
> include/linux/fortify-string.h:583:25: error: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Werror=attribute-warning]
> 583 | __write_overflow_field(p_size_field, size);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Make this actually use a flexible array to let the compiler understand.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>
> Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Patch applied to wireless-next.git, thanks.
47e612268ea0 wifi: rtw89: use flexible array member in rtw89_btc_btf_tlv
--
https://patchwork.kernel.org/project/linux-wireless/patch/20230523113241.2772811-1-arnd@kernel.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-05-25 16:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-23 11:32 [PATCH] rtw89: use flexible array member in rtw89_btc_btf_tlv Arnd Bergmann
2023-05-24 1:24 ` Ping-Ke Shih
2023-05-24 10:43 ` Gustavo A. R. Silva
2023-05-25 16:14 ` wifi: " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).