* [PATCH] platform/dcdbas: move EXPORT_SYMBOL after function
@ 2022-02-12 12:59 Mateusz Jończyk
2022-02-17 14:54 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Mateusz Jończyk @ 2022-02-12 12:59 UTC (permalink / raw)
To: linux-kernel, platform-driver-x86
Cc: Mateusz Jończyk, Stuart Hayes, Hans de Goede, Mark Gross
The declaration
EXPORT_SYMBOL(dcdbas_smi_request);
was placed after smi_request_store(), which made a false impression that
dcdbas_smi_request() was not exported.
Signed-off-by: Mateusz Jończyk <mat.jonczyk@o2.pl>
Cc: Stuart Hayes <stuart.w.hayes@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Mark Gross <markgross@kernel.org>
---
drivers/platform/x86/dell/dcdbas.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/dell/dcdbas.c b/drivers/platform/x86/dell/dcdbas.c
index 5e63d6225048..db3633fafbd5 100644
--- a/drivers/platform/x86/dell/dcdbas.c
+++ b/drivers/platform/x86/dell/dcdbas.c
@@ -284,6 +284,7 @@ int dcdbas_smi_request(struct smi_cmd *smi_cmd)
return ret;
}
+EXPORT_SYMBOL(dcdbas_smi_request);
/**
* smi_request_store:
@@ -351,7 +352,6 @@ static ssize_t smi_request_store(struct device *dev,
mutex_unlock(&smi_data_lock);
return ret;
}
-EXPORT_SYMBOL(dcdbas_smi_request);
/**
* host_control_smi: generate host control SMI
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] platform/dcdbas: move EXPORT_SYMBOL after function
2022-02-12 12:59 [PATCH] platform/dcdbas: move EXPORT_SYMBOL after function Mateusz Jończyk
@ 2022-02-17 14:54 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2022-02-17 14:54 UTC (permalink / raw)
To: Mateusz Jończyk, linux-kernel, platform-driver-x86
Cc: Stuart Hayes, Mark Gross
Hi,
On 2/12/22 13:59, Mateusz Jończyk wrote:
> The declaration
> EXPORT_SYMBOL(dcdbas_smi_request);
> was placed after smi_request_store(), which made a false impression that
> dcdbas_smi_request() was not exported.
>
> Signed-off-by: Mateusz Jończyk <mat.jonczyk@o2.pl>
> Cc: Stuart Hayes <stuart.w.hayes@gmail.com>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Mark Gross <markgross@kernel.org>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> drivers/platform/x86/dell/dcdbas.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/dell/dcdbas.c b/drivers/platform/x86/dell/dcdbas.c
> index 5e63d6225048..db3633fafbd5 100644
> --- a/drivers/platform/x86/dell/dcdbas.c
> +++ b/drivers/platform/x86/dell/dcdbas.c
> @@ -284,6 +284,7 @@ int dcdbas_smi_request(struct smi_cmd *smi_cmd)
>
> return ret;
> }
> +EXPORT_SYMBOL(dcdbas_smi_request);
>
> /**
> * smi_request_store:
> @@ -351,7 +352,6 @@ static ssize_t smi_request_store(struct device *dev,
> mutex_unlock(&smi_data_lock);
> return ret;
> }
> -EXPORT_SYMBOL(dcdbas_smi_request);
>
> /**
> * host_control_smi: generate host control SMI
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-17 14:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-12 12:59 [PATCH] platform/dcdbas: move EXPORT_SYMBOL after function Mateusz Jończyk
2022-02-17 14:54 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).