* [PATCH] iwlegacy: remove redundant assignment to *res
@ 2019-03-30 20:14 Colin King
2019-03-31 7:15 ` Mukesh Ojha
2019-04-04 10:15 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2019-03-30 20:14 UTC (permalink / raw)
To: Stanislaw Gruszka, Kalle Valo, David S . Miller, linux-wireless, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Currently 1 is being assigned to *res and then it is immediately
updated with the computed result. The first assignment is
redundant and can be removed.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/wireless/intel/iwlegacy/4965.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlegacy/4965.c b/drivers/net/wireless/intel/iwlegacy/4965.c
index ce4144a89217..a20b6c885047 100644
--- a/drivers/net/wireless/intel/iwlegacy/4965.c
+++ b/drivers/net/wireless/intel/iwlegacy/4965.c
@@ -577,7 +577,6 @@ il4965_math_div_round(s32 num, s32 denom, s32 * res)
sign = -sign;
denom = -denom;
}
- *res = 1;
*res = ((num * 2 + denom) / (denom * 2)) * sign;
return 1;
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iwlegacy: remove redundant assignment to *res
2019-03-30 20:14 [PATCH] iwlegacy: remove redundant assignment to *res Colin King
@ 2019-03-31 7:15 ` Mukesh Ojha
2019-04-04 10:15 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Mukesh Ojha @ 2019-03-31 7:15 UTC (permalink / raw)
To: Colin King, Stanislaw Gruszka, Kalle Valo, David S . Miller,
linux-wireless, netdev
Cc: kernel-janitors, linux-kernel
On 3/31/2019 1:44 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently 1 is being assigned to *res and then it is immediately
> updated with the computed result. The first assignment is
> redundant and can be removed.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Cheers,
-Mukesh
> ---
> drivers/net/wireless/intel/iwlegacy/4965.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/wireless/intel/iwlegacy/4965.c b/drivers/net/wireless/intel/iwlegacy/4965.c
> index ce4144a89217..a20b6c885047 100644
> --- a/drivers/net/wireless/intel/iwlegacy/4965.c
> +++ b/drivers/net/wireless/intel/iwlegacy/4965.c
> @@ -577,7 +577,6 @@ il4965_math_div_round(s32 num, s32 denom, s32 * res)
> sign = -sign;
> denom = -denom;
> }
> - *res = 1;
> *res = ((num * 2 + denom) / (denom * 2)) * sign;
>
> return 1;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iwlegacy: remove redundant assignment to *res
2019-03-30 20:14 [PATCH] iwlegacy: remove redundant assignment to *res Colin King
2019-03-31 7:15 ` Mukesh Ojha
@ 2019-04-04 10:15 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2019-04-04 10:15 UTC (permalink / raw)
To: Colin King
Cc: Stanislaw Gruszka, David S . Miller, linux-wireless, netdev,
kernel-janitors, linux-kernel
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently 1 is being assigned to *res and then it is immediately
> updated with the computed result. The first assignment is
> redundant and can be removed.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Patch applied to wireless-drivers-next.git, thanks.
6603c5844a44 iwlegacy: remove redundant assignment to *res
--
https://patchwork.kernel.org/patch/10878565/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-04 10:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-30 20:14 [PATCH] iwlegacy: remove redundant assignment to *res Colin King
2019-03-31 7:15 ` Mukesh Ojha
2019-04-04 10:15 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).