* [PATCH] leds-PowerNV: Delete an error message for a failed memory allocation in powernv_led_create()
@ 2017-08-27 20:10 SF Markus Elfring
2017-08-28 10:18 ` Pavel Machek
2017-08-28 20:23 ` Jacek Anaszewski
0 siblings, 2 replies; 3+ messages in thread
From: SF Markus Elfring @ 2017-08-27 20:10 UTC (permalink / raw)
To: linux-leds, linuxppc-dev, Benjamin Herrenschmidt,
Jacek Anaszewski, Michael Ellerman, Paul Mackerras, Pavel Machek,
Richard Purdie
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 27 Aug 2017 22:00:22 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/leds/leds-powernv.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/leds/leds-powernv.c b/drivers/leds/leds-powernv.c
index b2a98c7b521b..b1adbd70ce2e 100644
--- a/drivers/leds/leds-powernv.c
+++ b/drivers/leds/leds-powernv.c
@@ -224,12 +224,8 @@ static int powernv_led_create(struct device *dev,
powernv_led->cdev.name = devm_kasprintf(dev, GFP_KERNEL, "%s:%s",
powernv_led->loc_code,
led_type_desc);
- if (!powernv_led->cdev.name) {
- dev_err(dev,
- "%s: Memory allocation failed for classdev name\n",
- __func__);
+ if (!powernv_led->cdev.name)
return -ENOMEM;
- }
powernv_led->cdev.brightness_set_blocking = powernv_brightness_set;
powernv_led->cdev.brightness_get = powernv_brightness_get;
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] leds-PowerNV: Delete an error message for a failed memory allocation in powernv_led_create()
2017-08-27 20:10 [PATCH] leds-PowerNV: Delete an error message for a failed memory allocation in powernv_led_create() SF Markus Elfring
@ 2017-08-28 10:18 ` Pavel Machek
2017-08-28 20:23 ` Jacek Anaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Pavel Machek @ 2017-08-28 10:18 UTC (permalink / raw)
To: SF Markus Elfring
Cc: linux-leds, linuxppc-dev, Benjamin Herrenschmidt,
Jacek Anaszewski, Michael Ellerman, Paul Mackerras,
Richard Purdie, LKML, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 546 bytes --]
On Sun 2017-08-27 22:10:08, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 27 Aug 2017 22:00:22 +0200
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Pavel Machek <pavel@ucw.cz>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] leds-PowerNV: Delete an error message for a failed memory allocation in powernv_led_create()
2017-08-27 20:10 [PATCH] leds-PowerNV: Delete an error message for a failed memory allocation in powernv_led_create() SF Markus Elfring
2017-08-28 10:18 ` Pavel Machek
@ 2017-08-28 20:23 ` Jacek Anaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Jacek Anaszewski @ 2017-08-28 20:23 UTC (permalink / raw)
To: SF Markus Elfring, linux-leds, linuxppc-dev,
Benjamin Herrenschmidt, Michael Ellerman, Paul Mackerras,
Pavel Machek, Richard Purdie
Cc: LKML, kernel-janitors
Hi Markus,
Thanks for the patch.
On 08/27/2017 10:10 PM, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 27 Aug 2017 22:00:22 +0200
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/leds/leds-powernv.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/leds/leds-powernv.c b/drivers/leds/leds-powernv.c
> index b2a98c7b521b..b1adbd70ce2e 100644
> --- a/drivers/leds/leds-powernv.c
> +++ b/drivers/leds/leds-powernv.c
> @@ -224,12 +224,8 @@ static int powernv_led_create(struct device *dev,
> powernv_led->cdev.name = devm_kasprintf(dev, GFP_KERNEL, "%s:%s",
> powernv_led->loc_code,
> led_type_desc);
> - if (!powernv_led->cdev.name) {
> - dev_err(dev,
> - "%s: Memory allocation failed for classdev name\n",
> - __func__);
> + if (!powernv_led->cdev.name)
> return -ENOMEM;
> - }
>
> powernv_led->cdev.brightness_set_blocking = powernv_brightness_set;
> powernv_led->cdev.brightness_get = powernv_brightness_get;
>
Applied.
--
Best regards,
Jacek Anaszewski
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-28 20:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-27 20:10 [PATCH] leds-PowerNV: Delete an error message for a failed memory allocation in powernv_led_create() SF Markus Elfring
2017-08-28 10:18 ` Pavel Machek
2017-08-28 20:23 ` Jacek Anaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).