* [PATCH] drm/mediatek: fix error handling
@ 2016-07-03 5:37 Christophe JAILLET
2016-07-03 5:51 ` Matthias Brugger
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2016-07-03 5:37 UTC (permalink / raw)
To: airlied, matthias.bgg, ck.hu
Cc: dri-devel, linux-arm-kernel, linux-mediatek, linux-kernel,
kernel-janitors, Christophe JAILLET
This is likely that checking 'phy_provider' instead of 'phy' is
expected here.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/gpu/drm/mediatek/mtk_mipi_tx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_mipi_tx.c b/drivers/gpu/drm/mediatek/mtk_mipi_tx.c
index cf8f38d..1c366f8 100644
--- a/drivers/gpu/drm/mediatek/mtk_mipi_tx.c
+++ b/drivers/gpu/drm/mediatek/mtk_mipi_tx.c
@@ -431,7 +431,7 @@ static int mtk_mipi_tx_probe(struct platform_device *pdev)
phy_set_drvdata(phy, mipi_tx);
phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
- if (IS_ERR(phy)) {
+ if (IS_ERR(phy_provider)) {
ret = PTR_ERR(phy_provider);
return ret;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/mediatek: fix error handling
2016-07-03 5:37 [PATCH] drm/mediatek: fix error handling Christophe JAILLET
@ 2016-07-03 5:51 ` Matthias Brugger
0 siblings, 0 replies; 2+ messages in thread
From: Matthias Brugger @ 2016-07-03 5:51 UTC (permalink / raw)
To: Christophe JAILLET, airlied, ck.hu
Cc: dri-devel, linux-arm-kernel, linux-mediatek, linux-kernel,
kernel-janitors
On 07/03/2016 07:37 AM, Christophe JAILLET wrote:
> This is likely that checking 'phy_provider' instead of 'phy' is
> expected here.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/gpu/drm/mediatek/mtk_mipi_tx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_mipi_tx.c b/drivers/gpu/drm/mediatek/mtk_mipi_tx.c
> index cf8f38d..1c366f8 100644
> --- a/drivers/gpu/drm/mediatek/mtk_mipi_tx.c
> +++ b/drivers/gpu/drm/mediatek/mtk_mipi_tx.c
> @@ -431,7 +431,7 @@ static int mtk_mipi_tx_probe(struct platform_device *pdev)
> phy_set_drvdata(phy, mipi_tx);
>
> phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
> - if (IS_ERR(phy)) {
> + if (IS_ERR(phy_provider)) {
Dan already send a patch for that:
http://www.spinics.net/lists/dri-devel/msg112031.html
Regards,
Matthias
> ret = PTR_ERR(phy_provider);
> return ret;
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-03 5:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-03 5:37 [PATCH] drm/mediatek: fix error handling Christophe JAILLET
2016-07-03 5:51 ` Matthias Brugger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).