linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drivers: clocksource: timer-riscv: Depend on the SBI
@ 2020-11-25 19:58 Palmer Dabbelt
  2020-11-26  1:00 ` Kefeng Wang
  0 siblings, 1 reply; 2+ messages in thread
From: Palmer Dabbelt @ 2020-11-25 19:58 UTC (permalink / raw)
  To: linux-riscv
  Cc: daniel.lezcano, tglx, linux-kernel, kernel-team, Palmer Dabbelt

From: Palmer Dabbelt <palmerdabbelt@google.com>

Fundamentally this is an SBI timer driver, so it cannot be enabled without
support for the RISC-V SBI.

Fixes: d5be89a8d118 ("RISC-V: Resurrect the MMIO timer implementation for M-mode systems")
Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>
---
 drivers/clocksource/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index 68b087bff59c..3eeaf0efba8f 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -655,6 +655,7 @@ config ATCPIT100_TIMER
 config RISCV_TIMER
 	bool "Timer for the RISC-V platform" if COMPILE_TEST
 	depends on GENERIC_SCHED_CLOCK && RISCV
+	depends on RISCV_SBI
 	select TIMER_PROBE
 	select TIMER_OF
 	help
-- 
2.29.2.454.gaff20da3a2-goog


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drivers: clocksource: timer-riscv: Depend on the SBI
  2020-11-25 19:58 [PATCH] drivers: clocksource: timer-riscv: Depend on the SBI Palmer Dabbelt
@ 2020-11-26  1:00 ` Kefeng Wang
  0 siblings, 0 replies; 2+ messages in thread
From: Kefeng Wang @ 2020-11-26  1:00 UTC (permalink / raw)
  To: Palmer Dabbelt, linux-riscv
  Cc: Palmer Dabbelt, tglx, daniel.lezcano, kernel-team, linux-kernel

Hi Palmer,  I send a same patch and have been acked from you : )

https://patchwork.kernel.org/project/linux-riscv/patch/20201028131230.72907-1-wangkefeng.wang@huawei.com/

On 2020/11/26 3:58, Palmer Dabbelt wrote:
> From: Palmer Dabbelt <palmerdabbelt@google.com>
>
> Fundamentally this is an SBI timer driver, so it cannot be enabled without
> support for the RISC-V SBI.
>
> Fixes: d5be89a8d118 ("RISC-V: Resurrect the MMIO timer implementation for M-mode systems")
> Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>
> ---
>   drivers/clocksource/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index 68b087bff59c..3eeaf0efba8f 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -655,6 +655,7 @@ config ATCPIT100_TIMER
>   config RISCV_TIMER
>   	bool "Timer for the RISC-V platform" if COMPILE_TEST
>   	depends on GENERIC_SCHED_CLOCK && RISCV
> +	depends on RISCV_SBI
>   	select TIMER_PROBE
>   	select TIMER_OF
>   	help

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-11-26  1:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-25 19:58 [PATCH] drivers: clocksource: timer-riscv: Depend on the SBI Palmer Dabbelt
2020-11-26  1:00 ` Kefeng Wang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).