From: Naveen Naidu <naveennaidu479@gmail.com>
To: bhelgaas@google.com, ruscur@russell.cc, oohall@gmail.com
Cc: Naveen Naidu <naveennaidu479@gmail.com>,
linux-kernel-mentees@lists.linuxfoundation.org,
skhan@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: [PATCH v2 3/8] PCI/DPC: Initialize info->id in dpc_process_error()
Date: Mon, 4 Oct 2021 19:36:29 +0530 [thread overview]
Message-ID: <d6e7eabf4fcf80b454dbcec507b3553448fcc95a.1633353468.git.naveennaidu479@gmail.com> (raw)
Message-ID: <20211004140629.FC5FOAdwiWsWOkRUWX2cirwbf3c5eDEURsbK3GPFUa4@z> (raw)
In-Reply-To: <cover.1633353468.git.naveennaidu479@gmail.com>
In the dpc_process_error() path, info->id isn't initialized before being
passed to aer_print_error(). In the corresponding AER path, it is
initialized in aer_isr_one_error().
The error message shown during Coverity Scan is:
Coverity #1461602
CID 1461602 (#1 of 1): Uninitialized scalar variable (UNINIT)
8. uninit_use_in_call: Using uninitialized value info.id when calling aer_print_error.
Initialize the "info->id" before passing it to aer_print_error()
Fixes: 8aefa9b0d910 ("PCI/DPC: Print AER status in DPC event handling")
Signed-off-by: Naveen Naidu <naveennaidu479@gmail.com>
---
drivers/pci/pcie/dpc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/pci/pcie/dpc.c b/drivers/pci/pcie/dpc.c
index c556e7beafe3..df3f3a10f8bc 100644
--- a/drivers/pci/pcie/dpc.c
+++ b/drivers/pci/pcie/dpc.c
@@ -262,14 +262,14 @@ static int dpc_get_aer_uncorrect_severity(struct pci_dev *dev,
void dpc_process_error(struct pci_dev *pdev)
{
- u16 cap = pdev->dpc_cap, status, source, reason, ext_reason;
+ u16 cap = pdev->dpc_cap, status, reason, ext_reason;
struct aer_err_info info;
pci_read_config_word(pdev, cap + PCI_EXP_DPC_STATUS, &status);
- pci_read_config_word(pdev, cap + PCI_EXP_DPC_SOURCE_ID, &source);
+ pci_read_config_word(pdev, cap + PCI_EXP_DPC_SOURCE_ID, &info.id);
pci_info(pdev, "containment event, status:%#06x source:%#06x\n",
- status, source);
+ status, info.id);
reason = (status & PCI_EXP_DPC_STATUS_TRIGGER_RSN) >> 1;
ext_reason = (status & PCI_EXP_DPC_STATUS_TRIGGER_RSN_EXT) >> 5;
--
2.25.1
next prev parent reply other threads:[~2021-10-04 14:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211004140626.aa-OCgblBo049SqAlgcfAQUPOceVrQEz41GMkYrk44U@z>
2021-10-04 14:06 ` [PATCH v2 0/8] Fix long standing AER Error Handling Issues Naveen Naidu
[not found] ` <20211004140627.L9Ory2bL_N9H4mTmqby8I92QVcOUJ36Ob2XJgdEMLVs@z>
2021-10-04 14:06 ` [PATCH v2 1/8] PCI/AER: Remove ID from aer_agent_string[] Naveen Naidu
[not found] ` <20211004140628.KfrY2vR7_XdTPwneg95gWIBwo84hdUr5T1z3PKeCJdk@z>
2021-10-04 14:06 ` [PATCH v2 2/8] PCI: Cleanup struct aer_err_info Naveen Naidu
[not found] ` <20211004140629.FC5FOAdwiWsWOkRUWX2cirwbf3c5eDEURsbK3GPFUa4@z>
2021-10-04 14:06 ` Naveen Naidu [this message]
[not found] ` <20211004140630.y-dc_oAcvlk9QpGeTOxDZOalxJRgtjoRGJV108-dli0@z>
2021-10-04 14:06 ` [PATCH v2 4/8] PCI/DPC: Use pci_aer_clear_status() in dpc_process_error() Naveen Naidu
[not found] ` <20211004140631.GmoAXbtJEPhUHPewQCOfaYnBH4dcCcGtA0WBndPNDD8@z>
2021-10-04 14:06 ` [PATCH v2 5/8] PCI/DPC: Converge EDR and DPC Path of clearing AER registers Naveen Naidu
[not found] ` <20211004140632.h5z7NbLk5TNEj8snZn7TZ6yKtGCgrGOXkhT3UMzsu70@z>
2021-10-04 14:06 ` [PATCH v2 6/8] PCI/AER: Clear error device AER registers in aer_irq() Naveen Naidu
[not found] ` <20211004140633.QxC1EM-Kue6FsUP4tqbR75LGibxaUNwKL6m6Rno_imY@z>
2021-10-04 14:06 ` [PATCH v2 7/8] PCI/ERR: Remove redundant clearing of AER register in pcie_do_recovery() Naveen Naidu
[not found] ` <20211004141205.IcHGZTA5gVTcs2jHK32EWSN4l67j-xq1gbFHCRb75Bg@z>
2021-10-04 14:12 ` [PATCH v2 8/8] PCI/AER: Include DEVCTL in aer_print_error() Naveen Naidu
2021-10-04 14:06 ` [PATCH " Naveen Naidu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6e7eabf4fcf80b454dbcec507b3553448fcc95a.1633353468.git.naveennaidu479@gmail.com \
--to=naveennaidu479@gmail.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=oohall@gmail.com \
--cc=ruscur@russell.cc \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).