[PATCH 1/3] dt-bindings: timer: cdns,ttc: drop unneeded minItems

[PATCH 1/3] dt-bindings: timer: cdns,ttc: drop unneeded minItems

[Krzysztof Kozlowski]

There is no need to add minItems when it is equal to maxItems.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/timer/cdns,ttc.yaml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/timer/cdns,ttc.yaml b/Documentation/devicetree/bindings/timer/cdns,ttc.yaml
index c3386076a98c..7d821fd480f6 100644
--- a/Documentation/devicetree/bindings/timer/cdns,ttc.yaml
+++ b/Documentation/devicetree/bindings/timer/cdns,ttc.yaml
@@ -17,7 +17,6 @@ properties:
     maxItems: 1
 
   interrupts:
-    minItems: 3
     maxItems: 3
     description: |
       A list of 3 interrupts; one per timer channel.
-- 
2.32.0

[PATCH 2/3] dt-bindings: timer: samsung,exynos4210-mct: drop unneeded minItems

[Krzysztof Kozlowski]

There is no need to add minItems when it is equal to maxItems.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../devicetree/bindings/timer/samsung,exynos4210-mct.yaml        | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/timer/samsung,exynos4210-mct.yaml b/Documentation/devicetree/bindings/timer/samsung,exynos4210-mct.yaml
index 1584944c7ac4..0e28d9bdb8cb 100644
--- a/Documentation/devicetree/bindings/timer/samsung,exynos4210-mct.yaml
+++ b/Documentation/devicetree/bindings/timer/samsung,exynos4210-mct.yaml
@@ -35,7 +35,6 @@ properties:
           - const: samsung,exynos4210-mct
 
   clocks:
-    minItems: 2
     maxItems: 2
 
   clock-names:
-- 
2.32.0

[PATCH 3/3] dt-bindings: timer: samsung,exynos4210-mct: define strict clock order

[Krzysztof Kozlowski]

The DTS should always have fixed clock order, even if it comes with
clock-names property.  Drop the pattern to make the order strict.
Existing DTS already match this.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../devicetree/bindings/timer/samsung,exynos4210-mct.yaml     | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/timer/samsung,exynos4210-mct.yaml b/Documentation/devicetree/bindings/timer/samsung,exynos4210-mct.yaml
index 0e28d9bdb8cb..9c81d00b12e0 100644
--- a/Documentation/devicetree/bindings/timer/samsung,exynos4210-mct.yaml
+++ b/Documentation/devicetree/bindings/timer/samsung,exynos4210-mct.yaml
@@ -39,8 +39,8 @@ properties:
 
   clock-names:
     items:
-      - pattern: "^(fin_pll|mct)$"
-      - pattern: "^(fin_pll|mct)$"
+      - const: fin_pll
+      - const: mct
 
   reg:
     maxItems: 1
-- 
2.32.0

Re: [PATCH 2/3] dt-bindings: timer: samsung,exynos4210-mct: drop unneeded minItems

[Rob Herring]

On Sun, 24 Apr 2022 17:03:32 +0200, Krzysztof Kozlowski wrote:
> There is no need to add minItems when it is equal to maxItems.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  .../devicetree/bindings/timer/samsung,exynos4210-mct.yaml        | 1 -
>  1 file changed, 1 deletion(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

RE: [PATCH 2/3] dt-bindings: timer: samsung,exynos4210-mct: drop unneeded minItems

[Alim Akhtar]

Hello Krzysztof

>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
>Sent: Sunday, April 24, 2022 8:34 PM
>To: Daniel Lezcano <daniel.lezcano@linaro.org>; Thomas Gleixner
><tglx@linutronix.de>; Rob Herring <robh+dt@kernel.org>; Krzysztof
>Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
><alim.akhtar@samsung.com>; Michal Simek <michal.simek@xilinx.com>;
>linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; linux-arm-
>kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org
>Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>Subject: [PATCH 2/3] dt-bindings: timer: samsung,exynos4210-mct: drop
>unneeded minItems
>
>There is no need to add minItems when it is equal to maxItems.
>
>Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>---

Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>


> .../devicetree/bindings/timer/samsung,exynos4210-mct.yaml        | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/Documentation/devicetree/bindings/timer/samsung,exynos4210-
>mct.yaml
>b/Documentation/devicetree/bindings/timer/samsung,exynos4210-mct.yaml
>index 1584944c7ac4..0e28d9bdb8cb 100644
>--- a/Documentation/devicetree/bindings/timer/samsung,exynos4210-
>mct.yaml
>+++ b/Documentation/devicetree/bindings/timer/samsung,exynos4210-
>mct.yaml
>@@ -35,7 +35,6 @@ properties:
>           - const: samsung,exynos4210-mct
>
>   clocks:
>-    minItems: 2
>     maxItems: 2
>
>   clock-names:
>--
>2.32.0

RE: [PATCH 3/3] dt-bindings: timer: samsung,exynos4210-mct: define strict clock order

[Alim Akhtar]

Hello Krzysztof,

>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
>Sent: Sunday, April 24, 2022 8:34 PM
>To: Daniel Lezcano <daniel.lezcano@linaro.org>; Thomas Gleixner
><tglx@linutronix.de>; Rob Herring <robh+dt@kernel.org>; Krzysztof
>Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
><alim.akhtar@samsung.com>; Michal Simek <michal.simek@xilinx.com>;
>linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; linux-arm-
>kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org
>Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>Subject: [PATCH 3/3] dt-bindings: timer: samsung,exynos4210-mct: define
>strict clock order
>
>The DTS should always have fixed clock order, even if it comes with clock-
>names property.  Drop the pattern to make the order strict.
>Existing DTS already match this.
>
>Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>---

Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

> .../devicetree/bindings/timer/samsung,exynos4210-mct.yaml     | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/Documentation/devicetree/bindings/timer/samsung,exynos4210-
>mct.yaml
>b/Documentation/devicetree/bindings/timer/samsung,exynos4210-mct.yaml
>index 0e28d9bdb8cb..9c81d00b12e0 100644
>--- a/Documentation/devicetree/bindings/timer/samsung,exynos4210-
>mct.yaml
>+++ b/Documentation/devicetree/bindings/timer/samsung,exynos4210-
>mct.yam
>+++ l
>@@ -39,8 +39,8 @@ properties:
>
>   clock-names:
>     items:
>-      - pattern: "^(fin_pll|mct)$"
>-      - pattern: "^(fin_pll|mct)$"
>+      - const: fin_pll
>+      - const: mct
>
>   reg:
>     maxItems: 1
>--
>2.32.0

RE: [PATCH 1/3] dt-bindings: timer: cdns,ttc: drop unneeded minItems

[Alim Akhtar]

Hello Krzysztof,

>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
>Sent: Sunday, April 24, 2022 8:34 PM
>To: Daniel Lezcano <daniel.lezcano@linaro.org>; Thomas Gleixner
><tglx@linutronix.de>; Rob Herring <robh+dt@kernel.org>; Krzysztof
>Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
><alim.akhtar@samsung.com>; Michal Simek <michal.simek@xilinx.com>;
>linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; linux-arm-
>kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org
>Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>Subject: [PATCH 1/3] dt-bindings: timer: cdns,ttc: drop unneeded minItems
>
>There is no need to add minItems when it is equal to maxItems.
>
>Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>---

Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

> Documentation/devicetree/bindings/timer/cdns,ttc.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/Documentation/devicetree/bindings/timer/cdns,ttc.yaml
>b/Documentation/devicetree/bindings/timer/cdns,ttc.yaml
>index c3386076a98c..7d821fd480f6 100644
>--- a/Documentation/devicetree/bindings/timer/cdns,ttc.yaml
>+++ b/Documentation/devicetree/bindings/timer/cdns,ttc.yaml
>@@ -17,7 +17,6 @@ properties:
>     maxItems: 1
>
>   interrupts:
>-    minItems: 3
>     maxItems: 3
>     description: |
>       A list of 3 interrupts; one per timer channel.
>--
>2.32.0

Re: [PATCH 1/3] dt-bindings: timer: cdns,ttc: drop unneeded minItems

[Rob Herring]

On Sun, 24 Apr 2022 17:03:31 +0200, Krzysztof Kozlowski wrote:
> There is no need to add minItems when it is equal to maxItems.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/timer/cdns,ttc.yaml | 1 -
>  1 file changed, 1 deletion(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

Re: [PATCH 3/3] dt-bindings: timer: samsung,exynos4210-mct: define strict clock order

[Rob Herring]

On Sun, 24 Apr 2022 17:03:33 +0200, Krzysztof Kozlowski wrote:
> The DTS should always have fixed clock order, even if it comes with
> clock-names property.  Drop the pattern to make the order strict.
> Existing DTS already match this.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  .../devicetree/bindings/timer/samsung,exynos4210-mct.yaml     | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

Re: [PATCH 1/3] dt-bindings: timer: cdns,ttc: drop unneeded minItems

[Krzysztof Kozlowski]

On 24/04/2022 17:03, Krzysztof Kozlowski wrote:
> There is no need to add minItems when it is equal to maxItems.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/timer/cdns,ttc.yaml | 1 -
>  1 file changed, 1 deletion(-)
Hi Daniel, Thomas,

The patchset was acked by Rob, so he expects you will pick it up. Could
you let me know if there is anything stopping or you expect the other
way (via DT-tree)?

Best regards,
Krzysztof

Re: [PATCH 1/3] dt-bindings: timer: cdns,ttc: drop unneeded minItems

[Rob Herring]

On Fri, May 06, 2022 at 10:28:52AM +0200, Krzysztof Kozlowski wrote:
> On 24/04/2022 17:03, Krzysztof Kozlowski wrote:
> > There is no need to add minItems when it is equal to maxItems.
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > ---
> >  Documentation/devicetree/bindings/timer/cdns,ttc.yaml | 1 -
> >  1 file changed, 1 deletion(-)
> Hi Daniel, Thomas,
> 
> The patchset was acked by Rob, so he expects you will pick it up. Could
> you let me know if there is anything stopping or you expect the other
> way (via DT-tree)?

Looks like still not applied, so I've applied to DT tree.

Rob