[PATCH] coresight: etm4x: Add Support for HiSilicon ETM device

[PATCH] coresight: etm4x: Add Support for HiSilicon ETM device

[Qi Liu]

Add ETMv4 periperhal ID for HiSilicon Hip08 and Hip09 platform. Hip08
contains ETMv4.2 device and Hip09 contains ETMv4.5 device.

Signed-off-by: Qi Liu <liuqi115@huawei.com>
---
 drivers/hwtracing/coresight/coresight-etm4x.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c b/drivers/hwtracing/coresight/coresight-etm4x.c
index 0c35cd5e..4a4f0bd 100644
--- a/drivers/hwtracing/coresight/coresight-etm4x.c
+++ b/drivers/hwtracing/coresight/coresight-etm4x.c
@@ -1561,6 +1561,8 @@ static struct amba_cs_uci_id uci_id_etm4[] = {
 };

 static const struct amba_id etm4_ids[] = {
+	CS_AMBA_ID(0x000b6d02),			/* HiSilicon-Hip09 */
+	CS_AMBA_ID(0x000b6d01),			/* HiSilicon-Hip08 */
 	CS_AMBA_ID(0x000bb95d),			/* Cortex-A53 */
 	CS_AMBA_ID(0x000bb95e),			/* Cortex-A57 */
 	CS_AMBA_ID(0x000bb95a),			/* Cortex-A72 */
--
2.8.1

Re: [PATCH] coresight: etm4x: Add Support for HiSilicon ETM device

[Sai Prakash Ranjan]

Hi Qi Liu,

On 2020-08-03 19:05, Qi Liu wrote:
> Add ETMv4 periperhal ID for HiSilicon Hip08 and Hip09 platform. Hip08
> contains ETMv4.2 device and Hip09 contains ETMv4.5 device.
> 
> Signed-off-by: Qi Liu <liuqi115@huawei.com>
> ---
>  drivers/hwtracing/coresight/coresight-etm4x.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c
> b/drivers/hwtracing/coresight/coresight-etm4x.c
> index 0c35cd5e..4a4f0bd 100644
> --- a/drivers/hwtracing/coresight/coresight-etm4x.c
> +++ b/drivers/hwtracing/coresight/coresight-etm4x.c
> @@ -1561,6 +1561,8 @@ static struct amba_cs_uci_id uci_id_etm4[] = {
>  };
> 
>  static const struct amba_id etm4_ids[] = {
> +	CS_AMBA_ID(0x000b6d02),			/* HiSilicon-Hip09 */
> +	CS_AMBA_ID(0x000b6d01),			/* HiSilicon-Hip08 */
>  	CS_AMBA_ID(0x000bb95d),			/* Cortex-A53 */
>  	CS_AMBA_ID(0x000bb95e),			/* Cortex-A57 */
>  	CS_AMBA_ID(0x000bb95a),			/* Cortex-A72 */
> --
> 2.8.1

You have missed adding the maintainers/reviewers of coresight(Mathieu 
and Mike),
you can use scripts/get_maintainer.pl on the drivers to get the 
maintainers and
reviewers for the corresponding drivers, same on other patch as well.

Thanks,
Sai

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a 
member
of Code Aurora Forum, hosted by The Linux Foundation

Re: [PATCH] coresight: etm4x: Add Support for HiSilicon ETM device

[Suzuki K Poulose]

Hi Qi

On 08/03/2020 02:35 PM, Qi Liu wrote:
> Add ETMv4 periperhal ID for HiSilicon Hip08 and Hip09 platform. Hip08
> contains ETMv4.2 device and Hip09 contains ETMv4.5 device.

Does the ETMv4.5 on your system implement system instructions to access
the ETMs ? If so, please could you give the following series on your
board ?

http://lists.infradead.org/pipermail/linux-arm-kernel/2020-July/587745.html


> 
> Signed-off-by: Qi Liu <liuqi115@huawei.com>
> ---
>   drivers/hwtracing/coresight/coresight-etm4x.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c b/drivers/hwtracing/coresight/coresight-etm4x.c
> index 0c35cd5e..4a4f0bd 100644
> --- a/drivers/hwtracing/coresight/coresight-etm4x.c
> +++ b/drivers/hwtracing/coresight/coresight-etm4x.c
> @@ -1561,6 +1561,8 @@ static struct amba_cs_uci_id uci_id_etm4[] = {
>   };
> 
>   static const struct amba_id etm4_ids[] = {
> +	CS_AMBA_ID(0x000b6d02),			/* HiSilicon-Hip09 */
> +	CS_AMBA_ID(0x000b6d01),			/* HiSilicon-Hip08 */

Please use CS_AMBA_UCI_ID() instead.

We should stop using the CS_AMBA_ID()


Suzuki

Re: [PATCH] coresight: etm4x: Add Support for HiSilicon ETM device

[Qi Liu]

Hi Suzuki,
Thanks for your review.

On 2020/8/4 18:47, Suzuki K Poulose wrote:
> Hi Qi
> 
> On 08/03/2020 02:35 PM, Qi Liu wrote:
>> Add ETMv4 periperhal ID for HiSilicon Hip08 and Hip09 platform. Hip08
>> contains ETMv4.2 device and Hip09 contains ETMv4.5 device.
> 
> Does the ETMv4.5 on your system implement system instructions to access
> the ETMs ? If so, please could you give the following series on your
> board ?
> 
> http://lists.infradead.org/pipermail/linux-arm-kernel/2020-July/587745.html
> 

ETMv4.5 on Hip09 platform does not support system instructions.
> 
>>
>> Signed-off-by: Qi Liu <liuqi115@huawei.com>
>> ---
>>   drivers/hwtracing/coresight/coresight-etm4x.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c b/drivers/hwtracing/coresight/coresight-etm4x.c
>> index 0c35cd5e..4a4f0bd 100644
>> --- a/drivers/hwtracing/coresight/coresight-etm4x.c
>> +++ b/drivers/hwtracing/coresight/coresight-etm4x.c
>> @@ -1561,6 +1561,8 @@ static struct amba_cs_uci_id uci_id_etm4[] = {
>>   };
>>
>>   static const struct amba_id etm4_ids[] = {
>> +    CS_AMBA_ID(0x000b6d02),            /* HiSilicon-Hip09 */
>> +    CS_AMBA_ID(0x000b6d01),            /* HiSilicon-Hip08 */
> 
> Please use CS_AMBA_UCI_ID() instead.
> 
> We should stop using the CS_AMBA_ID()
> 
ok, I'll fix this in next version.

Thanks,
Qi
> 
> Suzuki
> 
> .
>