From: Yu-cheng Yu <yu-cheng.yu@intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Tony Luck <tony.luck@intel.com>,
Andy Lutomirski <luto@kernel.org>,
Rik van Riel <riel@surriel.com>,
"Ravi V. Shankar" <ravi.v.shankar@intel.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Fenghua Yu <fenghua.yu@intel.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 6/6] x86/fpu/xstate: Rename validate_xstate_header() to validate_xstate_header_from_user()
Date: Wed, 09 Oct 2019 15:10:54 -0700 [thread overview]
Message-ID: <d733c8d7c7c7c27ac6e89374bfb78891119e3b02.camel@intel.com> (raw)
In-Reply-To: <20191009173148.GJ10395@zn.tnic>
On Wed, 2019-10-09 at 19:31 +0200, Borislav Petkov wrote:
> On Wed, Sep 25, 2019 at 08:10:22AM -0700, Yu-cheng Yu wrote:
> > From: Fenghua Yu <fenghua.yu@intel.com>
> >
> > The function validate_xstate_header() validates an xstate header coming
> > from userspace (PTRACE or sigreturn). To make it clear, rename it to
> > validate_xstate_header_from_user().
> >
> > Suggested-by: Dave Hansen <dave.hansen@intel.com>
> > Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
> > Signed-off-by: Yu-cheng Yu <yu-cheng.yu@intel.com>
>
> This one is correct!
>
> \o/
>
> > Reviewed-by: Dave Hansen <dave.hansen@linux.intel.com>
> > Reviewed-by: Tony Luck <tony.luck@intel.com>
> > ---
> > arch/x86/include/asm/fpu/xstate.h | 2 +-
> > arch/x86/kernel/fpu/regset.c | 2 +-
> > arch/x86/kernel/fpu/signal.c | 2 +-
> > arch/x86/kernel/fpu/xstate.c | 6 +++---
> > 4 files changed, 6 insertions(+), 6 deletions(-)
>
> And I like patches like this one! :-)
>
> Reviewed-by: Borislav Petkov <bp@suse.de>
Thanks for reviewing. I will send out an updated version.
Yu-cheng
prev parent reply other threads:[~2019-10-09 22:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 15:10 [PATCH 0/6] Support XSAVES supervisor states Yu-cheng Yu
2019-09-25 15:10 ` [PATCH 1/6] x86/fpu/xstate: Fix small issues before adding supervisor xstates Yu-cheng Yu
2019-10-09 15:58 ` Borislav Petkov
2019-11-22 21:22 ` Yu-cheng Yu
2019-11-22 21:54 ` Borislav Petkov
2019-09-25 15:10 ` [PATCH 2/6] x86/fpu/xstate: Define new macros for supervisor and user xstates Yu-cheng Yu
2019-10-09 16:17 ` Borislav Petkov
2019-09-25 15:10 ` [PATCH 3/6] x86/fpu/xstate: Separate user and supervisor xfeatures mask Yu-cheng Yu
2019-10-09 16:59 ` Borislav Petkov
2019-09-25 15:10 ` [PATCH 4/6] x86/fpu/xstate: Introduce XSAVES supervisor states Yu-cheng Yu
2019-10-09 17:10 ` Borislav Petkov
2019-09-25 15:10 ` [PATCH 5/6] x86/fpu/xstate: Define new functions for clearing fpregs and xstates Yu-cheng Yu
2019-10-09 17:28 ` Borislav Petkov
2019-09-25 15:10 ` [PATCH 6/6] x86/fpu/xstate: Rename validate_xstate_header() to validate_xstate_header_from_user() Yu-cheng Yu
2019-10-09 17:31 ` Borislav Petkov
2019-10-09 22:10 ` Yu-cheng Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d733c8d7c7c7c27ac6e89374bfb78891119e3b02.camel@intel.com \
--to=yu-cheng.yu@intel.com \
--cc=bigeasy@linutronix.de \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=ravi.v.shankar@intel.com \
--cc=riel@surriel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).