From: Benno Evers <bevers@mesosphere.io>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>
Cc: Benno Evers <bevers@mesosphere.com>,
Krister Johansen <kjlx@templeofstupid.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>,
linux-kernel@vger.kernel.org, kernel-team@lge.com
Subject: Re: [PATCH] perf tools: Check for null when copying nsinfo.
Date: Fri, 10 Aug 2018 15:38:20 +0200 [thread overview]
Message-ID: <d8d9132b-36af-951d-4932-42ec9fa1ae15@mesosphere.io> (raw)
In-Reply-To: <20180810131847.GG5395@kernel.org>
Haha, sorry, I was following some "how-to-contribute" guide out there,
but it seems like I missed a step :D I sent out a new version with the
missing sign-off.
On 10.08.2018 15:18, Arnaldo Carvalho de Melo wrote:
> Em Fri, Aug 10, 2018 at 01:55:37PM +0900, Namhyung Kim escreveu:
>> Hello,
>>
>> On Thu, Aug 09, 2018 at 11:53:48PM +0200, Benno Evers wrote:
>>> The argument to nsinfo__copy() was assumed to be valid, but some code paths
>>> exist that will lead to NULL being passed.
>>>
>>> In particular, running 'perf script -D' on a perf.data file containing an
>>> PERF_RECORD_MMAP event associating the '[vdso]' dso with pid 0 earlier in
>>> the event stream will lead to a segfault.
>>>
>>> Since all calling code is already checking for a non-null return value,
>>> just return NULL for this case as well.
>> Acked-by: Namhyung Kim <namhyung@kernel.org>
>>
>> It seems you missed the Signed-off-by though.
> Yeah, please collect Namhyung's Acked-by and provide yours, i.e. your
> patch should end with the following lines:
>
>
> Acked-by: Namhyung Kim <namhyung@kernel.org>
> Signed-off-by: Benno Evers <bevers@mesosphere.com>
>
> My git-am scripts will collect the Cc from the e-mail message and add
> the Link: with the Message-id.
>
> Thanks,
>
> - Arnaldo
>
>> Thanks,
>> Namhyung
>>
>>
>>> ---
>>> tools/perf/util/namespaces.c | 3 +++
>>> 1 file changed, 3 insertions(+)
>>>
>>> diff --git a/tools/perf/util/namespaces.c b/tools/perf/util/namespaces.c
>>> index 5be021701f34..cf8bd123cf73 100644
>>> --- a/tools/perf/util/namespaces.c
>>> +++ b/tools/perf/util/namespaces.c
>>> @@ -139,6 +139,9 @@ struct nsinfo *nsinfo__copy(struct nsinfo *nsi)
>>> {
>>> struct nsinfo *nnsi;
>>>
>>> + if (nsi == NULL)
>>> + return NULL;
>>> +
>>> nnsi = calloc(1, sizeof(*nnsi));
>>> if (nnsi != NULL) {
>>> nnsi->pid = nsi->pid;
>>> --
>>> 2.17.1
>>>
prev parent reply other threads:[~2018-08-10 13:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-09 21:53 [PATCH] perf tools: Check for null when copying nsinfo Benno Evers
2018-08-10 4:55 ` Namhyung Kim
2018-08-10 13:18 ` Arnaldo Carvalho de Melo
2018-08-10 13:38 ` Benno Evers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8d9132b-36af-951d-4932-42ec9fa1ae15@mesosphere.io \
--to=bevers@mesosphere.io \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=bevers@mesosphere.com \
--cc=jolsa@redhat.com \
--cc=kernel-team@lge.com \
--cc=kjlx@templeofstupid.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).