* [PATCH] ASoC: rt5682: Register clocks even when mclk is NULL
@ 2020-06-12 16:31 Akshu Agrawal
2020-06-12 16:34 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Akshu Agrawal @ 2020-06-12 16:31 UTC (permalink / raw)
Cc: akshu.agrawal, yuhsuan, albertchen, derek.fang, Oder Chiou,
Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...,
open list
Fixes kernel crash on platforms which do not have mclk exposed
in CCF framework. For these platforms have mclk as NULL and
continue to register clocks.
Signed-off-by: Akshu Agrawal <akshu.agrawal@amd.com>
---
sound/soc/codecs/rt5682.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/sound/soc/codecs/rt5682.c b/sound/soc/codecs/rt5682.c
index d3245123101d..7c8b8d839db8 100644
--- a/sound/soc/codecs/rt5682.c
+++ b/sound/soc/codecs/rt5682.c
@@ -2829,12 +2829,11 @@ static int rt5682_probe(struct snd_soc_component *component)
return ret;
}
rt5682->mclk = NULL;
- } else {
- /* Register CCF DAI clock control */
- ret = rt5682_register_dai_clks(component);
- if (ret)
- return ret;
}
+ /* Register CCF DAI clock control */
+ ret = rt5682_register_dai_clks(component);
+ if (ret)
+ return ret;
/* Initial setup for CCF */
rt5682->lrck[RT5682_AIF1] = CLK_48;
#endif
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: rt5682: Register clocks even when mclk is NULL
2020-06-12 16:31 [PATCH] ASoC: rt5682: Register clocks even when mclk is NULL Akshu Agrawal
@ 2020-06-12 16:34 ` Mark Brown
2020-06-12 16:46 ` Agrawal, Akshu
0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2020-06-12 16:34 UTC (permalink / raw)
To: Akshu Agrawal
Cc: yuhsuan, albertchen, derek.fang, Oder Chiou, Liam Girdwood,
Jaroslav Kysela, Takashi Iwai,
moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...,
open list
[-- Attachment #1: Type: text/plain, Size: 353 bytes --]
On Fri, Jun 12, 2020 at 10:01:11PM +0530, Akshu Agrawal wrote:
> Fixes kernel crash on platforms which do not have mclk exposed
> in CCF framework. For these platforms have mclk as NULL and
> continue to register clocks.
Derek already submitted this:
https://lore.kernel.org/alsa-devel/1591938925-1070-5-git-send-email-derek.fang@realtek.com/T/#u
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: rt5682: Register clocks even when mclk is NULL
2020-06-12 16:34 ` Mark Brown
@ 2020-06-12 16:46 ` Agrawal, Akshu
0 siblings, 0 replies; 3+ messages in thread
From: Agrawal, Akshu @ 2020-06-12 16:46 UTC (permalink / raw)
To: Mark Brown, Akshu Agrawal
Cc: yuhsuan, albertchen, derek.fang, Oder Chiou, Liam Girdwood,
Jaroslav Kysela, Takashi Iwai,
moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...,
open list
On 6/12/2020 10:04 PM, Mark Brown wrote:
> On Fri, Jun 12, 2020 at 10:01:11PM +0530, Akshu Agrawal wrote:
>> Fixes kernel crash on platforms which do not have mclk exposed
>> in CCF framework. For these platforms have mclk as NULL and
>> continue to register clocks.
> Derek already submitted this:
>
> https://lore.kernel.org/alsa-devel/1591938925-1070-5-git-send-email-derek.fang@realtek.com/T/#u
Ok great. Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-12 16:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-12 16:31 [PATCH] ASoC: rt5682: Register clocks even when mclk is NULL Akshu Agrawal
2020-06-12 16:34 ` Mark Brown
2020-06-12 16:46 ` Agrawal, Akshu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).