From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Kishon Vijay Abraham I <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>,
Minas Harutyunyan <hminas@synopsys.com>,
linux-usb@vger.kernel.org
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Jules Maselbas <jmaselbas@kalray.eu>
Subject: Re: Correct ordering of phy_init and phy_power_on
Date: Tue, 22 Dec 2020 10:08:14 +0100 [thread overview]
Message-ID: <d9311d93-76bb-7671-cc3e-04e7c7db2ff8@pengutronix.de> (raw)
In-Reply-To: <014e75a5-ab7b-55be-e554-14ef7550b360@ti.com>
Hello Kishon,
On 21.12.20 04:15, Kishon Vijay Abraham I wrote:
>> So how was it meant to be?
>
> It is intended to be ->init() and then ->power_on(). So ideally it
> should be the way dwc3 is.
Thanks. Should we do something about the inconsistency?
Amend documentation and maybe print a warning when order is wrong,
so users are encouraged to fix their drivers?
The way it is, you can't properly mix some of the PHY and USB controller drivers.
Cheers,
Ahmad
>
> Thanks,
> Kishon
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2020-12-22 9:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-20 23:06 Correct ordering of phy_init and phy_power_on Ahmad Fatoum
2020-12-21 3:15 ` Kishon Vijay Abraham I
2020-12-22 9:08 ` Ahmad Fatoum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9311d93-76bb-7671-cc3e-04e7c7db2ff8@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=hminas@synopsys.com \
--cc=jmaselbas@kalray.eu \
--cc=kernel@pengutronix.de \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).