From: Rajendra Nayak <rnayak@codeaurora.org>
To: Stephen Boyd <sboyd@kernel.org>,
andy.gross@linaro.org, collinsd@codeaurora.org, mka@chromium.org,
robh@kernel.org, ulf.hansson@linaro.org, viresh.kumar@linaro.org
Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 4/8] soc: qcom: rpmpd: Add support for get/set performance state
Date: Wed, 5 Dec 2018 12:33:14 +0530 [thread overview]
Message-ID: <d9317471-fb81-482a-22c1-4a7b466a1df4@codeaurora.org> (raw)
In-Reply-To: <154396526967.88331.13652897075952274639@swboyd.mtv.corp.google.com>
On 12/5/2018 4:44 AM, Stephen Boyd wrote:
> Quoting Rajendra Nayak (2018-12-03 21:21:15)
>> @@ -221,6 +224,47 @@ static int rpmpd_power_off(struct generic_pm_domain *domain)
>> return ret;
>> }
>>
>> +static int rpmpd_set_performance(struct generic_pm_domain *domain,
>> + unsigned int state)
>> +{
>> + int ret = 0;
>> + struct rpmpd *pd = domain_to_rpmpd(domain);
>> +
>> + mutex_lock(&rpmpd_lock);
>> +
>> + if (state > MAX_RPMPD_STATE)
>> + goto out;
>
> Does this need to be under the mutex lock? Doesn't look like it.
Nope, will move it out.
>
>> +
>> + pd->corner = state;
>> +
>> + if (!pd->enabled && (pd->key != KEY_FLOOR_CORNER))
>
> Please drop useless parenthesis.
sure
>
>> + goto out;
>> +
>> + ret = rpmpd_aggregate_corner(pd);
>> +
>> +out:
>> + mutex_unlock(&rpmpd_lock);
>> +
>> + return ret;
>> +}
>> +
>> +static unsigned int rpmpd_get_performance(struct generic_pm_domain *genpd,
>> + struct dev_pm_opp *opp)
>> +{
>> + struct device_node *np;
>> + unsigned int corner = 0;
>> +
>> + np = dev_pm_opp_get_of_node(opp);
>> + if (of_property_read_u32(np, "qcom,level", &corner)) {
>> + pr_err("%s: missing 'qcom,level' property\n", __func__);
>
> We leak np reference here, assuming dev_pm_opp_get_of_node() returns an
> of_node_get() pointer to the caller.
good catch, will fix.
>
>> + return 0;
>> + }
>> +
>> + of_node_put(np);
>
> This same code exists twice. Perhaps a helper needs to exist for
> qcom_rpm_get_performance() to pull the number out of the DT.
Sure I can make both drivers use a common helper instead of duplicating it.
>
>> +
>> + return corner;
>> +}
next prev parent reply other threads:[~2018-12-05 7:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 5:21 [PATCH v5 0/8] Add power domain driver for corners on msm8996/sdm845 Rajendra Nayak
2018-12-04 5:21 ` [PATCH v5 1/8] dt-bindings: opp: Introduce qcom-opp bindings Rajendra Nayak
2018-12-04 23:06 ` Stephen Boyd
2018-12-07 17:29 ` Rob Herring
2018-12-04 5:21 ` [PATCH v5 2/8] dt-bindings: power: Add qcom rpm power domain driver bindings Rajendra Nayak
2018-12-04 5:21 ` [PATCH v5 3/8] soc: qcom: rpmpd: Add a Power domain driver to model corners Rajendra Nayak
2018-12-04 23:12 ` Stephen Boyd
2018-12-05 7:01 ` Rajendra Nayak
2018-12-04 5:21 ` [PATCH v5 4/8] soc: qcom: rpmpd: Add support for get/set performance state Rajendra Nayak
2018-12-04 23:14 ` Stephen Boyd
2018-12-05 7:03 ` Rajendra Nayak [this message]
2018-12-05 10:11 ` Rajendra Nayak
2018-12-05 20:46 ` Stephen Boyd
2018-12-04 5:21 ` [PATCH v5 5/8] arm64: dts: msm8996: Add rpmpd device node Rajendra Nayak
2018-12-04 5:21 ` [PATCH v5 6/8] soc: qcom: rpmhpd: Add RPMh Power domain driver Rajendra Nayak
2018-12-04 5:21 ` [PATCH v5 7/8] arm64: dts: sdm845: Add rpmh powercontroller node Rajendra Nayak
2018-12-04 5:25 ` Viresh Kumar
2018-12-04 23:16 ` Stephen Boyd
2018-12-05 7:07 ` Rajendra Nayak
2018-12-07 17:36 ` Rob Herring
2018-12-04 5:21 ` [PATCH v5 8/8] soc: qcom: rpmhpd: Mark mx as a parent for cx Rajendra Nayak
2018-12-04 5:26 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9317471-fb81-482a-22c1-4a7b466a1df4@codeaurora.org \
--to=rnayak@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=collinsd@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).