From: "Arnd Bergmann" <arnd@arndb.de>
To: "Andrew Lunn" <andrew@lunn.ch>,
"Balamanikandan Gunasundar"
<balamanikandan.gunasundar@microchip.com>
Cc: "Ulf Hansson" <ulf.hansson@linaro.org>,
linux-kernel@vger.kernel.org,
linux-atm-general@lists.sourceforge.net,
"linux-mmc @ vger . kernel . org" <linux-mmc@vger.kernel.org>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
ludovic.desroches@microchip.com, 3chas3@gmail.com,
Netdev <netdev@vger.kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] mmc: atmel-mci: Convert to gpio descriptors
Date: Thu, 10 Nov 2022 10:02:25 +0100 [thread overview]
Message-ID: <d9b1e753-3bdd-4b8f-935e-718b0b590ace@app.fastmail.com> (raw)
In-Reply-To: <213cb0f3-10ce-45b1-aa5d-41d753a0cadd@app.fastmail.com>
On Thu, Nov 10, 2022, at 09:05, Arnd Bergmann wrote:
> On Wed, Nov 9, 2022, at 18:16, Andrew Lunn wrote:
>> On Wed, Nov 09, 2022 at 10:08:45AM +0530, Balamanikandan Gunasundar wrote:
>>> Replace the legacy GPIO APIs with gpio descriptor consumer interface.
>>
>> I was wondering why you Cc: netdev and ATM. This clearly has nothing
>> to do with those lists.
>>
>> You well foul of
>>
>> M: Chas Williams <3chas3@gmail.com>
>> L: linux-atm-general@lists.sourceforge.net (moderated for non-subscribers)
>> L: netdev@vger.kernel.org
>> S: Maintained
>> W: http://linux-atm.sourceforge.net
>> F: drivers/atm/
>> F: include/linux/atm*
>> F: include/uapi/linux/atm*
>>
>> Maybe these atm* should be more specific so they don't match atmel :-)
>
> The uapi headers look unambiguous to me, for the three headers in
> include/linux/, only the atmdev.h is actually significant, while
> linux/atm.h and linux/atm_tcp.h could each be folded into the one
> C file that actually uses the contents.
Actually the situation for the linux/atmel*.h headers is similar:
most of them are only used in one file, and the linux/atmel-mci.h
contents should just be moved into drivers/mmc/host/atmel-mci.c
as part of Balamanikandan's patch, to allow further cleanups.
linux/atmel-isc-media.h similarly can go into its drivers as a
separate patch if desired.
The linux/atmel-ssc.h could ideally be cleaned up to get moved
into sound/soc/atmel/ along with drivers/misc/atmel-ssc.c.
The atmel-scc driver is technically also used by
sound/spi/at73c213.c, but that driver has been orphaned since
2014, with commit 2e591e7b3ac2 ("ARM: at91: remove
at91sam9261/at91sam9g10 legacy board support"), as nobody
ever added DT probing support to it.
Arnd
next prev parent reply other threads:[~2022-11-10 9:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 4:38 [PATCH] mmc: atmel-mci: Convert to gpio descriptors Balamanikandan Gunasundar
2022-11-09 12:38 ` Ulf Hansson
2022-11-09 14:48 ` Linus Walleij
2022-11-10 22:33 ` Dmitry Torokhov
2022-11-09 17:16 ` Andrew Lunn
2022-11-10 8:05 ` Arnd Bergmann
2022-11-10 9:02 ` Arnd Bergmann [this message]
2022-11-10 22:41 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9b1e753-3bdd-4b8f-935e-718b0b590ace@app.fastmail.com \
--to=arnd@arndb.de \
--cc=3chas3@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=balamanikandan.gunasundar@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=netdev@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).