* [PATCH] misc/xilinx_sdfec: remove redundant _{open, release} function
@ 2023-04-22 19:59 Bo Svangård
2023-05-15 9:33 ` Michal Simek
0 siblings, 1 reply; 2+ messages in thread
From: Bo Svangård @ 2023-04-22 19:59 UTC (permalink / raw)
To: derek.kiernan, dragan.cvetic, arnd, gregkh, michal.simek,
linux-arm-kernel, linux-kernel
Cc: Bo Svangård
The functions are redundant as they are empty and performed by the misc
driver.
Signed-off-by: Bo Svangård <bo.svangard@sylog.se>
---
drivers/misc/xilinx_sdfec.c | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/drivers/misc/xilinx_sdfec.c b/drivers/misc/xilinx_sdfec.c
index cb9506f9cbd0..270ff4c5971a 100644
--- a/drivers/misc/xilinx_sdfec.c
+++ b/drivers/misc/xilinx_sdfec.c
@@ -855,16 +855,6 @@ static int xsdfec_cfg_axi_streams(struct xsdfec_dev *xsdfec)
return 0;
}
-static int xsdfec_dev_open(struct inode *iptr, struct file *fptr)
-{
- return 0;
-}
-
-static int xsdfec_dev_release(struct inode *iptr, struct file *fptr)
-{
- return 0;
-}
-
static int xsdfec_start(struct xsdfec_dev *xsdfec)
{
u32 regread;
@@ -1030,8 +1020,6 @@ static __poll_t xsdfec_poll(struct file *file, poll_table *wait)
static const struct file_operations xsdfec_fops = {
.owner = THIS_MODULE,
- .open = xsdfec_dev_open,
- .release = xsdfec_dev_release,
.unlocked_ioctl = xsdfec_dev_ioctl,
.poll = xsdfec_poll,
.compat_ioctl = compat_ptr_ioctl,
--
2.40.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] misc/xilinx_sdfec: remove redundant _{open, release} function
2023-04-22 19:59 [PATCH] misc/xilinx_sdfec: remove redundant _{open, release} function Bo Svangård
@ 2023-05-15 9:33 ` Michal Simek
0 siblings, 0 replies; 2+ messages in thread
From: Michal Simek @ 2023-05-15 9:33 UTC (permalink / raw)
To: Bo Svangård, derek.kiernan, dragan.cvetic, arnd, gregkh,
michal.simek, linux-arm-kernel, linux-kernel
On 4/22/23 21:59, Bo Svangård wrote:
>
> The functions are redundant as they are empty and performed by the misc
> driver.
>
> Signed-off-by: Bo Svangård <bo.svangard@sylog.se>
> ---
> drivers/misc/xilinx_sdfec.c | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/drivers/misc/xilinx_sdfec.c b/drivers/misc/xilinx_sdfec.c
> index cb9506f9cbd0..270ff4c5971a 100644
> --- a/drivers/misc/xilinx_sdfec.c
> +++ b/drivers/misc/xilinx_sdfec.c
> @@ -855,16 +855,6 @@ static int xsdfec_cfg_axi_streams(struct xsdfec_dev *xsdfec)
> return 0;
> }
>
> -static int xsdfec_dev_open(struct inode *iptr, struct file *fptr)
> -{
> - return 0;
> -}
> -
> -static int xsdfec_dev_release(struct inode *iptr, struct file *fptr)
> -{
> - return 0;
> -}
> -
> static int xsdfec_start(struct xsdfec_dev *xsdfec)
> {
> u32 regread;
> @@ -1030,8 +1020,6 @@ static __poll_t xsdfec_poll(struct file *file, poll_table *wait)
>
> static const struct file_operations xsdfec_fops = {
> .owner = THIS_MODULE,
> - .open = xsdfec_dev_open,
> - .release = xsdfec_dev_release,
> .unlocked_ioctl = xsdfec_dev_ioctl,
> .poll = xsdfec_poll,
> .compat_ioctl = compat_ptr_ioctl,
> --
> 2.40.0
>
Acked-by: Michal Simek <michal.simek@amd.com>
Thanks,
Michal
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-15 9:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-22 19:59 [PATCH] misc/xilinx_sdfec: remove redundant _{open, release} function Bo Svangård
2023-05-15 9:33 ` Michal Simek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).