From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org,
"Christian Bornträger" <borntraeger@de.ibm.com>,
"Cornelia Huck" <cornelia.huck@de.ibm.com>,
"David Hildenbrand" <dahi@linux.vnet.ibm.com>,
"Heiko Carstens" <heiko.carstens@de.ibm.com>,
"Martin Schwidefsky" <schwidefsky@de.ibm.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
"Julia Lawall" <julia.lawall@lip6.fr>,
"Walter Harms" <wharms@bfs.de>
Subject: Re: KVM: s390: Use memdup_user() rather than duplicating code
Date: Mon, 3 Oct 2016 16:25:34 +0200 [thread overview]
Message-ID: <da96837e-50bb-de1e-be42-0a22474edee8@users.sourceforge.net> (raw)
In-Reply-To: <CAMuHMdUS2aMd5B2nQOpQFdQGE7EvWMCea+dMzS7R7_yZ4LdONw@mail.gmail.com>
>> * Does there really a probability remain that an inappropriate product
>> would be calculated here (as the situation was before my two update steps
>> for this software module)?
>
> Perhaps not. Hence my "Probably not an issue here, ...".
Thanks for your clarification.
>> * Can it be that you are looking for a variant of a function like "memdup_user"
>> where values can be passed as separate parameters "count" and "size" so that
>> the needed multiplication and corresponding overflow check would be performed
>> together as desired?
>
> If there are enough uses, and people like it, adding memdup_user_array()
> may be a good idea...
How are the chances of such an addition for the Linux programming interface?
> P.S. Why do your questions make me think of a scientific paper? ;-)
Would you like to recommend any for further reading? ;-)
Regards,
Markus
next prev parent reply other threads:[~2016-10-03 14:25 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-17 18:02 [PATCH 0/4] KVM-S390: Fine-tuning for kvm_s390_import_bp_data() SF Markus Elfring
2016-08-17 18:06 ` [PATCH 1/4] KVM-S390: Improve determination of sizes in kvm_s390_import_bp_data() SF Markus Elfring
2016-08-18 7:25 ` walter harms
2016-08-18 9:02 ` Julia Lawall
2016-08-18 9:48 ` Paolo Bonzini
2016-08-18 10:52 ` walter harms
2016-08-18 10:55 ` Paolo Bonzini
2016-08-22 12:58 ` Cornelia Huck
2016-08-24 12:10 ` Replacing specific kmalloc() calls by kmalloc_array()? SF Markus Elfring
2016-08-24 15:00 ` Paolo Bonzini
2016-08-17 18:08 ` [PATCH 2/4] KVM-S390: Use memdup_user() rather than duplicating its implementation SF Markus Elfring
2016-08-22 13:02 ` David Hildenbrand
2016-08-22 13:05 ` Cornelia Huck
2016-08-24 15:19 ` Christian Borntraeger
2016-08-24 18:30 ` [PATCH v2 0/2] KVM: s390: Fine-tuning for kvm_s390_import_bp_data() SF Markus Elfring
2016-08-24 18:36 ` [PATCH v2 1/2] KVM: s390: Improve determination of sizes in kvm_s390_import_bp_data() SF Markus Elfring
2016-08-25 16:10 ` Cornelia Huck
2016-08-25 16:45 ` SF Markus Elfring
2016-08-25 17:34 ` Software evolution around scripts for the semantic patch langugae SF Markus Elfring
2016-08-25 17:40 ` Cornelia Huck
2016-08-25 17:54 ` SF Markus Elfring
2016-08-25 18:14 ` Julia Lawall
2016-08-25 18:20 ` SF Markus Elfring
2016-08-25 18:23 ` Julia Lawall
2016-08-25 21:04 ` Cornelia Huck
2016-08-24 18:40 ` [PATCH v2 2/2] KVM: s390: Use memdup_user() rather than duplicating code SF Markus Elfring
2016-08-25 16:11 ` Cornelia Huck
2016-10-03 12:11 ` Geert Uytterhoeven
2016-10-03 12:28 ` SF Markus Elfring
2016-10-03 13:10 ` Geert Uytterhoeven
2016-10-03 13:47 ` SF Markus Elfring
2016-10-03 14:00 ` Geert Uytterhoeven
2016-10-03 14:25 ` SF Markus Elfring [this message]
2016-08-25 16:12 ` [PATCH v2 0/2] KVM: s390: Fine-tuning for kvm_s390_import_bp_data() Christian Borntraeger
2016-08-17 18:10 ` [PATCH 3/4] KVM-S390: Less function calls in kvm_s390_import_bp_data() after error detection SF Markus Elfring
2016-08-22 12:58 ` David Hildenbrand
2016-08-22 13:00 ` Cornelia Huck
2016-08-22 16:56 ` SF Markus Elfring
2016-08-22 19:37 ` Cornelia Huck
2016-08-22 21:17 ` SF Markus Elfring
2016-08-22 21:28 ` Cornelia Huck
2016-08-31 12:29 ` Paolo Bonzini
2016-08-24 15:10 ` Christian Borntraeger
2016-08-27 16:12 ` SF Markus Elfring
2016-08-17 18:12 ` [PATCH 4/4] KVM-S390: Delete an unnecessary initialisation for a buffer variable SF Markus Elfring
2016-08-22 12:59 ` David Hildenbrand
2016-08-22 13:01 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da96837e-50bb-de1e-be42-0a22474edee8@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=dahi@linux.vnet.ibm.com \
--cc=geert@linux-m68k.org \
--cc=heiko.carstens@de.ibm.com \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=schwidefsky@de.ibm.com \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).