* [PATCH] xen/grant-table: Fix incorrect gnttab_dma_free_pages() pr_debug message
@ 2018-11-02 14:04 Liam Merwick
2018-11-02 15:35 ` Juergen Gross
2018-11-06 9:36 ` Juergen Gross
0 siblings, 2 replies; 3+ messages in thread
From: Liam Merwick @ 2018-11-02 14:04 UTC (permalink / raw)
To: xen-devel, linux-kernel; +Cc: jgross, boris.ostrovsky, liam.merwick
If a call to xenmem_reservation_increase() in gnttab_dma_free_pages()
fails it triggers a message "Failed to decrease reservation..." which
should be "Failed to increase reservation..."
Fixes: 9bdc7304f536 ('xen/grant-table: Allow allocating buffers suitable for DMA')
Reported-by: Ross Philipson <ross.philipson@oracle.com>
Signed-off-by: Liam Merwick <liam.merwick@oracle.com>
Reviewed-by: Mark Kanda <mark.kanda@oracle.com>
---
drivers/xen/grant-table.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c
index 84575baceebc..97341fa75458 100644
--- a/drivers/xen/grant-table.c
+++ b/drivers/xen/grant-table.c
@@ -914,7 +914,7 @@ int gnttab_dma_free_pages(struct gnttab_dma_alloc_args *args)
ret = xenmem_reservation_increase(args->nr_pages, args->frames);
if (ret != args->nr_pages) {
- pr_debug("Failed to decrease reservation for DMA buffer\n");
+ pr_debug("Failed to increase reservation for DMA buffer\n");
ret = -EFAULT;
} else {
ret = 0;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xen/grant-table: Fix incorrect gnttab_dma_free_pages() pr_debug message
2018-11-02 14:04 [PATCH] xen/grant-table: Fix incorrect gnttab_dma_free_pages() pr_debug message Liam Merwick
@ 2018-11-02 15:35 ` Juergen Gross
2018-11-06 9:36 ` Juergen Gross
1 sibling, 0 replies; 3+ messages in thread
From: Juergen Gross @ 2018-11-02 15:35 UTC (permalink / raw)
To: Liam Merwick, xen-devel, linux-kernel; +Cc: boris.ostrovsky
On 02/11/2018 15:04, Liam Merwick wrote:
> If a call to xenmem_reservation_increase() in gnttab_dma_free_pages()
> fails it triggers a message "Failed to decrease reservation..." which
> should be "Failed to increase reservation..."
>
> Fixes: 9bdc7304f536 ('xen/grant-table: Allow allocating buffers suitable for DMA')
> Reported-by: Ross Philipson <ross.philipson@oracle.com>
> Signed-off-by: Liam Merwick <liam.merwick@oracle.com>
> Reviewed-by: Mark Kanda <mark.kanda@oracle.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xen/grant-table: Fix incorrect gnttab_dma_free_pages() pr_debug message
2018-11-02 14:04 [PATCH] xen/grant-table: Fix incorrect gnttab_dma_free_pages() pr_debug message Liam Merwick
2018-11-02 15:35 ` Juergen Gross
@ 2018-11-06 9:36 ` Juergen Gross
1 sibling, 0 replies; 3+ messages in thread
From: Juergen Gross @ 2018-11-06 9:36 UTC (permalink / raw)
To: Liam Merwick, xen-devel, linux-kernel; +Cc: boris.ostrovsky
On 02/11/2018 15:04, Liam Merwick wrote:
> If a call to xenmem_reservation_increase() in gnttab_dma_free_pages()
> fails it triggers a message "Failed to decrease reservation..." which
> should be "Failed to increase reservation..."
>
> Fixes: 9bdc7304f536 ('xen/grant-table: Allow allocating buffers suitable for DMA')
> Reported-by: Ross Philipson <ross.philipson@oracle.com>
> Signed-off-by: Liam Merwick <liam.merwick@oracle.com>
> Reviewed-by: Mark Kanda <mark.kanda@oracle.com>
Pushed to xen.git for-linus-4.20a
Juergen
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-06 9:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-02 14:04 [PATCH] xen/grant-table: Fix incorrect gnttab_dma_free_pages() pr_debug message Liam Merwick
2018-11-02 15:35 ` Juergen Gross
2018-11-06 9:36 ` Juergen Gross
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).