* [PATCH v1] checkpatch: Skip "From" tag from 75 character limit enforcement
@ 2022-04-16 3:43 Kuppuswamy Sathyanarayanan
0 siblings, 0 replies; only message in thread
From: Kuppuswamy Sathyanarayanan @ 2022-04-16 3:43 UTC (permalink / raw)
To: Andy Whitcroft, Joe Perches, Dwaipayan Ray, Lukas Bulwahn
Cc: linux-kernel, Kuppuswamy Sathyanarayanan, Dave Hansen
From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@intel.com>
Currently, checkpatch script skips tags like "Fixes", "Link" and
"$signature_tags" when enforcing the 75 character limit in the commit
log. But it is missing the "From" tag in the skip list. So if a commit
log includes a "From:" tag with a long name or email, it reports a
false warning message.
To avoid this issue, include the "From" tag in the 75 character limit
enforcement skip list.
Reported-by: Dave Hansen <dave.hansen@intel.com>
Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@intel.com>
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 577e02998701..c8cbc216f098 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3174,7 +3174,7 @@ sub process {
# file delta changes
$line =~ /^\s*(?:[\w\.\-\+]*\/)++[\w\.\-\+]+:/ ||
# filename then :
- $line =~ /^\s*(?:Fixes:|Link:|$signature_tags)/i ||
+ $line =~ /^\s*(?:From:|Fixes:|Link:|$signature_tags)/i ||
# A Fixes: or Link: line or signature tag line
$commit_log_possible_stack_dump)) {
WARN("COMMIT_LOG_LONG_LINE",
--
2.25.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2022-04-16 3:44 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-16 3:43 [PATCH v1] checkpatch: Skip "From" tag from 75 character limit enforcement Kuppuswamy Sathyanarayanan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).