linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 06/62] gpio: gpio-amd-fch: Use new GPIO_LINE_DIRECTION
       [not found] <cover.1572945686.git.matti.vaittinen@fi.rohmeurope.com>
@ 2019-11-05 10:11 ` Matti Vaittinen
  0 siblings, 0 replies; only message in thread
From: Matti Vaittinen @ 2019-11-05 10:11 UTC (permalink / raw)
  To: matti.vaittinen, mazziesaccount
  Cc: Enrico Weigelt, metux IT consult, Linus Walleij,
	Bartosz Golaszewski, linux-gpio, linux-kernel

It's hard for occasional GPIO code reader/writer to know if values 0/1
equal to IN or OUT. Use defined GPIO_LINE_DIRECTION_IN and
GPIO_LINE_DIRECTION_OUT to help them out.

NOTE: This commit also changes the return value for direction get
to equal 1 for direction INPUT. Prior this commit the driver returned
non standard value BIT(23).

Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
---
 drivers/gpio/gpio-amd-fch.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-amd-fch.c b/drivers/gpio/gpio-amd-fch.c
index 181df1581df5..4e44ba4d7423 100644
--- a/drivers/gpio/gpio-amd-fch.c
+++ b/drivers/gpio/gpio-amd-fch.c
@@ -92,7 +92,7 @@ static int amd_fch_gpio_get_direction(struct gpio_chip *gc, unsigned int gpio)
 	ret = (readl_relaxed(ptr) & AMD_FCH_GPIO_FLAG_DIRECTION);
 	spin_unlock_irqrestore(&priv->lock, flags);
 
-	return ret;
+	return ret ? GPIO_LINE_DIRECTION_IN : GPIO_LINE_DIRECTION_OUT;
 }
 
 static void amd_fch_gpio_set(struct gpio_chip *gc,
-- 
2.21.0


-- 
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =] 

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2019-11-05 10:12 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <cover.1572945686.git.matti.vaittinen@fi.rohmeurope.com>
2019-11-05 10:11 ` [PATCH 06/62] gpio: gpio-amd-fch: Use new GPIO_LINE_DIRECTION Matti Vaittinen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).