* [PATCH] rpmsg: qcom_smd: Fix returning 0 if irq_of_parse_and_map() fails
@ 2022-04-23 9:39 Krzysztof Kozlowski
2022-04-28 9:47 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-23 9:39 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Mathieu Poirier, linux-arm-msm,
linux-remoteproc, linux-kernel
Cc: Krzysztof Kozlowski
irq_of_parse_and_map() returns 0 on failure, so this should not be
passed further as error return code.
Fixes: 1a358d350664 ("rpmsg: qcom_smd: Fix irq_of_parse_and_map() return value")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
A fix for: https://lore.kernel.org/all/20220422105326.78713-1-krzysztof.kozlowski@linaro.org/
Commit sha from Bjorn's email, so might not be stable/correct.
Consider squashing it.
---
drivers/rpmsg/qcom_smd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c
index 6ccfa12abd10..1957b27c4cf3 100644
--- a/drivers/rpmsg/qcom_smd.c
+++ b/drivers/rpmsg/qcom_smd.c
@@ -1409,7 +1409,7 @@ static int qcom_smd_parse_edge(struct device *dev,
irq = irq_of_parse_and_map(node, 0);
if (!irq) {
dev_err(dev, "required smd interrupt missing\n");
- ret = irq;
+ ret = -EINVAL;
goto put_node;
}
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rpmsg: qcom_smd: Fix returning 0 if irq_of_parse_and_map() fails
2022-04-23 9:39 [PATCH] rpmsg: qcom_smd: Fix returning 0 if irq_of_parse_and_map() fails Krzysztof Kozlowski
@ 2022-04-28 9:47 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-28 9:47 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Mathieu Poirier, linux-arm-msm,
linux-remoteproc, linux-kernel
On 23/04/2022 11:39, Krzysztof Kozlowski wrote:
> irq_of_parse_and_map() returns 0 on failure, so this should not be
> passed further as error return code.
>
> Fixes: 1a358d350664 ("rpmsg: qcom_smd: Fix irq_of_parse_and_map() return value")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> A fix for: https://lore.kernel.org/all/20220422105326.78713-1-krzysztof.kozlowski@linaro.org/
> Commit sha from Bjorn's email, so might not be stable/correct.
>
Bjorn,
Can you pick up this one? It's for an issue in your tree, introduced
with my previous patch.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-28 9:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-23 9:39 [PATCH] rpmsg: qcom_smd: Fix returning 0 if irq_of_parse_and_map() fails Krzysztof Kozlowski
2022-04-28 9:47 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).