From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Allen-KH Cheng <allen-kh.cheng@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Project_Global_Chrome_Upstream_Group@mediatek.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
Chen-Yu Tsai <wenst@chromium.org>,
Ryder Lee <ryder.lee@kernel.org>, Hui Liu <hui.liu@mediatek.com>
Subject: Re: [PATCH v3 12/21] arm64: dts: mt8192: Add mmc device nodes
Date: Tue, 15 Mar 2022 15:47:01 +0100 [thread overview]
Message-ID: <dc4ce2b5-bf8e-ea20-f9b1-9034caff421b@collabora.com> (raw)
In-Reply-To: <20220304130809.12924-13-allen-kh.cheng@mediatek.com>
Il 04/03/22 14:08, Allen-KH Cheng ha scritto:
> Add mmc nodes for mt8192 SoC.
>
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> ---
> arch/arm64/boot/dts/mediatek/mt8192.dtsi | 34 +++++++++++++++++++++---
> 1 file changed, 30 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> index 6220d6962f58..4e4081ea7db5 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> @@ -1150,10 +1150,36 @@
> #clock-cells = <1>;
> };
>
> - msdc: clock-controller@11f60000 {
> - compatible = "mediatek,mt8192-msdc";
> - reg = <0 0x11f60000 0 0x1000>;
> - #clock-cells = <1>;
> + mmc0: mmc@11f60000 {
> + compatible = "mediatek,mt8192-mmc", "mediatek,mt8183-mmc";
> + reg = <0 0x11f60000 0 0x1000>, <0 0x11f50000 0 0x1000>;
> + interrupts = <GIC_SPI 99 IRQ_TYPE_LEVEL_HIGH 0>;
> + clocks = <&topckgen CLK_TOP_MSDC50_0_SEL>,
> + <&msdc_top CLK_MSDC_TOP_H_MST_0P>,
> + <&msdc_top CLK_MSDC_TOP_SRC_0P>,
> + <&msdc_top CLK_MSDC_TOP_P_CFG>,
> + <&msdc_top CLK_MSDC_TOP_AXI>,
> + <&msdc_top CLK_MSDC_TOP_AHB2AXI_BRG_AXI>,
> + <&msdc_top CLK_MSDC_TOP_P_MSDC0>;
> + clock-names = "source", "hclk", "source_cg", "sys_cg",
> + "axi_cg", "ahb_cg", "pclk_cg";
Can you please use the same clock order as specified in the dt-bindings?
This means that "pclk_cg" goes before "axi_cg".
<&msdc_top CLK_MSDC_TOP_P_MSDC0>,
<&msdc_top CLK_MSDC_TOP_AHB2AXI_BRG_AXI>,
<&msdc_top CLK_MSDC_TOP_AXI>;
clock-names = "source", "hclk", "source_cg", "sys_cg",
"pclk_cg", "axi_cg", "ahb_cg";
> + status = "disabled";
> + };
> +
> + mmc1: mmc@11f70000 {
> + compatible = "mediatek,mt8192-mmc", "mediatek,mt8183-mmc";
> + reg = <0 0x11f70000 0 0x1000>, <0 0x11c70000 0 0x1000>;
> + interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH 0>;
> + clocks = <&topckgen CLK_TOP_MSDC30_1_SEL>,
> + <&msdc_top CLK_MSDC_TOP_H_MST_1P>,
> + <&msdc_top CLK_MSDC_TOP_SRC_1P>,
> + <&msdc_top CLK_MSDC_TOP_P_CFG>,
> + <&msdc_top CLK_MSDC_TOP_AXI>,
> + <&msdc_top CLK_MSDC_TOP_AHB2AXI_BRG_AXI>,
> + <&msdc_top CLK_MSDC_TOP_P_MSDC1>;
same here please.
> + clock-names = "source", "hclk", "source_cg", "sys_cg",
> + "axi_cg", "ahb_cg", "pclk_cg";
> + status = "disabled";
> };
>
> mfgcfg: clock-controller@13fbf000 {
After applying the requested changes,
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Thanks,
Angelo
next prev parent reply other threads:[~2022-03-15 14:47 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 13:07 [PATCH v3 00/21] Add driver nodes for MT8192 SoC Allen-KH Cheng
2022-03-04 13:07 ` [PATCH v3 01/21] arm64: dts: mt8192: Add pwrap node Allen-KH Cheng
2022-03-04 13:07 ` [PATCH v3 02/21] arm64: dts: mt8192: Add spmi node Allen-KH Cheng
2022-03-04 13:07 ` [PATCH v3 03/21] arm64: dts: mt8192: Add gce node Allen-KH Cheng
2022-03-04 13:07 ` [PATCH v3 04/21] arm64: dts: mt8192: Add SCP node Allen-KH Cheng
2022-03-15 14:34 ` AngeloGioacchino Del Regno
2022-03-04 13:07 ` [PATCH v3 05/21] arm64: dts: mt8192: Add usb-phy node Allen-KH Cheng
2022-03-15 14:34 ` AngeloGioacchino Del Regno
2022-03-04 13:07 ` [PATCH v3 06/21] arm64: dts: mt8192: Add xhci node Allen-KH Cheng
2022-03-04 13:07 ` [PATCH v3 07/21] arm64: dts: mt8192: Add audio-related nodes Allen-KH Cheng
2022-03-04 13:07 ` [PATCH v3 08/21] arm64: dts: mt8192: Add infracfg_rst node Allen-KH Cheng
2022-03-04 13:07 ` [PATCH v3 09/21] arm64: dts: mt8192: Add PCIe node Allen-KH Cheng
2022-03-04 13:07 ` [PATCH v3 10/21] arm64: dts: mt8192: Fix nor_flash status disable typo Allen-KH Cheng
2022-03-04 13:07 ` [PATCH v3 11/21] arm64: dts: mt8192: Add efuse node Allen-KH Cheng
2022-03-15 14:34 ` AngeloGioacchino Del Regno
2022-03-04 13:08 ` [PATCH v3 12/21] arm64: dts: mt8192: Add mmc device nodes Allen-KH Cheng
2022-03-15 14:47 ` AngeloGioacchino Del Regno [this message]
2022-03-04 13:08 ` [PATCH v3 13/21] arm64: dts: mt8192: Add mipi_tx node Allen-KH Cheng
2022-03-15 14:35 ` AngeloGioacchino Del Regno
2022-03-04 13:08 ` [PATCH v3 14/21] arm64: dts: mt8192: Add m4u and smi nodes Allen-KH Cheng
2022-03-04 13:08 ` [PATCH v3 15/21] arm64: dts: mt8192: Add H264 venc device node Allen-KH Cheng
2022-03-04 13:08 ` [PATCH v3 16/21] arm64: dts: mt8192: Add vcodec lat and core nodes Allen-KH Cheng
2022-03-15 14:39 ` AngeloGioacchino Del Regno
2022-03-04 13:08 ` [PATCH v3 17/21] arm64: dts: mt8192: Add dpi node Allen-KH Cheng
2022-03-15 14:41 ` AngeloGioacchino Del Regno
2022-03-04 13:08 ` [PATCH v3 18/21] arm64: dts: mt8192: Add display nodes Allen-KH Cheng
2022-03-04 13:08 ` [PATCH v3 19/21] arm64: dts: mt8192: Add dsi node Allen-KH Cheng
2022-03-15 14:51 ` AngeloGioacchino Del Regno
2022-03-04 13:08 ` [PATCH v3 20/21] arm64: dts: mt8192: Add gce info for display nodes Allen-KH Cheng
2022-03-15 14:54 ` AngeloGioacchino Del Regno
2022-03-04 13:08 ` [PATCH v3 21/21] arm64: dts: mt8192: Add pwm node Allen-KH Cheng
2022-03-15 14:54 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc4ce2b5-bf8e-ea20-f9b1-9034caff421b@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=allen-kh.cheng@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=hui.liu@mediatek.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=ryder.lee@kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).