[PATCH] ice: Slightly simply ice_find_free_recp_res_idx

[PATCH] ice: Slightly simply ice_find_free_recp_res_idx

[Christophe JAILLET]

The 'possible_idx' bitmap is set just after it is zeroed, so we can save
the first step.

The 'free_idx' bitmap is used only at the end of the function as the
result of a bitmap xor operation. So there is no need to explicitly
zero it before.

So, slightly simply the code and remove 2 useless 'bitmap_zero()' call

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
I don't think it will make any differences in RL. ICE_MAX_FV_WORDS is
just 48 (bits), so 1 or 2 longs
---
 drivers/net/ethernet/intel/ice/ice_switch.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/ice/ice_switch.c b/drivers/net/ethernet/intel/ice/ice_switch.c
index 793f4a9fc2cd..78bfb9fd318d 100644
--- a/drivers/net/ethernet/intel/ice/ice_switch.c
+++ b/drivers/net/ethernet/intel/ice/ice_switch.c
@@ -4071,10 +4071,8 @@ ice_find_free_recp_res_idx(struct ice_hw *hw, const unsigned long *profiles,
 	DECLARE_BITMAP(used_idx, ICE_MAX_FV_WORDS);
 	u16 bit;
 
-	bitmap_zero(possible_idx, ICE_MAX_FV_WORDS);
 	bitmap_zero(recipes, ICE_MAX_NUM_RECIPES);
 	bitmap_zero(used_idx, ICE_MAX_FV_WORDS);
-	bitmap_zero(free_idx, ICE_MAX_FV_WORDS);
 
 	bitmap_set(possible_idx, 0, ICE_MAX_FV_WORDS);
 
-- 
2.30.2

RE: [Intel-wired-lan] [PATCH] ice: Slightly simply ice_find_free_recp_res_idx

[Penigalapati, Sandeep]

>-----Original Message-----
>From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
>Christophe JAILLET
>Sent: Thursday, November 18, 2021 2:51 AM
>To: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L
><anthony.l.nguyen@intel.com>; davem@davemloft.net; kuba@kernel.org
>Cc: netdev@vger.kernel.org; kernel-janitors@vger.kernel.org; Christophe
>JAILLET <christophe.jaillet@wanadoo.fr>; intel-wired-lan@lists.osuosl.org;
>linux-kernel@vger.kernel.org
>Subject: [Intel-wired-lan] [PATCH] ice: Slightly simply
>ice_find_free_recp_res_idx
>
>The 'possible_idx' bitmap is set just after it is zeroed, so we can save the first
>step.
>
>The 'free_idx' bitmap is used only at the end of the function as the result of a
>bitmap xor operation. So there is no need to explicitly zero it before.
>
>So, slightly simply the code and remove 2 useless 'bitmap_zero()' call
>
>Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>---
>I don't think it will make any differences in RL. ICE_MAX_FV_WORDS is just 48
>(bits), so 1 or 2 longs
>---
> drivers/net/ethernet/intel/ice/ice_switch.c | 2 --
> 1 file changed, 2 deletions(-)
>
Tested-by: Sandeep Penigalapati <sandeep.penigalapati@intel.com>