* [PATCH v2] soc: imx8m: Fix return value check in imx8mq_soc_revision()
@ 2022-11-28 8:37 Zheng Yongjun
2022-11-28 9:31 ` Ahmad Fatoum
0 siblings, 1 reply; 2+ messages in thread
From: Zheng Yongjun @ 2022-11-28 8:37 UTC (permalink / raw)
To: shawnguo, s.hauer, linux-arm-kernel, linux-kernel
Cc: kernel, festevam, linux-imx
In case of error, the function of_clk_get_by_name()
returns ERR_PTR() and never returns NULL. The NULL test in the
return value check should be replaced with IS_ERR().
Fixes: 836fb30949d9 ("soc: imx8m: Enable OCOTP clock before reading the register")
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
Changes in v2:
- Rewrite code and make it more concise.
drivers/soc/imx/soc-imx8m.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/soc/imx/soc-imx8m.c b/drivers/soc/imx/soc-imx8m.c
index 28144c699b0c..d1dbe318be53 100644
--- a/drivers/soc/imx/soc-imx8m.c
+++ b/drivers/soc/imx/soc-imx8m.c
@@ -66,10 +66,8 @@ static u32 __init imx8mq_soc_revision(void)
ocotp_base = of_iomap(np, 0);
WARN_ON(!ocotp_base);
clk = of_clk_get_by_name(np, NULL);
- if (!clk) {
- WARN_ON(!clk);
+ if (WARN_ON(IS_ERR(clk)))
return 0;
- }
clk_prepare_enable(clk);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] soc: imx8m: Fix return value check in imx8mq_soc_revision()
2022-11-28 8:37 [PATCH v2] soc: imx8m: Fix return value check in imx8mq_soc_revision() Zheng Yongjun
@ 2022-11-28 9:31 ` Ahmad Fatoum
0 siblings, 0 replies; 2+ messages in thread
From: Ahmad Fatoum @ 2022-11-28 9:31 UTC (permalink / raw)
To: Zheng Yongjun, shawnguo, s.hauer, linux-arm-kernel, linux-kernel
Cc: festevam, linux-imx, kernel
Hello Zheng,
On 28.11.22 09:37, Zheng Yongjun wrote:
> In case of error, the function of_clk_get_by_name()
> returns ERR_PTR() and never returns NULL. The NULL test in the
> return value check should be replaced with IS_ERR().
>
> Fixes: 836fb30949d9 ("soc: imx8m: Enable OCOTP clock before reading the register")
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Maintainers will usually collect tags replied to the current patch revision when they
apply a series. However, If you send a new revision, please make sure to incorporate
any tags yourself.
Cheers,
Ahmad
> ---
> Changes in v2:
> - Rewrite code and make it more concise.
> drivers/soc/imx/soc-imx8m.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/soc/imx/soc-imx8m.c b/drivers/soc/imx/soc-imx8m.c
> index 28144c699b0c..d1dbe318be53 100644
> --- a/drivers/soc/imx/soc-imx8m.c
> +++ b/drivers/soc/imx/soc-imx8m.c
> @@ -66,10 +66,8 @@ static u32 __init imx8mq_soc_revision(void)
> ocotp_base = of_iomap(np, 0);
> WARN_ON(!ocotp_base);
> clk = of_clk_get_by_name(np, NULL);
> - if (!clk) {
> - WARN_ON(!clk);
> + if (WARN_ON(IS_ERR(clk)))
> return 0;
> - }
>
> clk_prepare_enable(clk);
>
> --
> 2.17.1
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-28 9:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-28 8:37 [PATCH v2] soc: imx8m: Fix return value check in imx8mq_soc_revision() Zheng Yongjun
2022-11-28 9:31 ` Ahmad Fatoum
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).