* Re: [PATCH v19 11/25] soc: mediatek: add mtk-mutex component - dp_intf1 [not found] ` <20220503102345.22817-12-nancy.lin@mediatek.com> @ 2022-05-03 12:19 ` AngeloGioacchino Del Regno 0 siblings, 0 replies; 4+ messages in thread From: AngeloGioacchino Del Regno @ 2022-05-03 12:19 UTC (permalink / raw) To: Nancy.Lin, Rob Herring, Matthias Brugger, Chun-Kuang Hu, Philipp Zabel, wim, linux Cc: David Airlie, Daniel Vetter, Nathan Chancellor, Nick Desaulniers, jason-jh . lin, Yongqiang Niu, devicetree, linux-kernel, linux-arm-kernel, linux-mediatek, dri-devel, llvm, singo.chang, Project_Global_Chrome_Upstream_Group Il 03/05/22 12:23, Nancy.Lin ha scritto: > Add mtk-mutex DDP_COMPONENT_DP_INTF1 component. The MT8195 vdosys1 path > component contains ovl_adaptor, merge5, and dp_intf1. It is a preparation > for adding support for MT8195 vdosys1 path component. > > Signed-off-by: Nancy.Lin <nancy.lin@mediatek.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <20220503102345.22817-5-nancy.lin@mediatek.com>]
* Re: [PATCH v19 04/25] soc: mediatek: add mtk-mmsys ethdr and mdp_rdma components [not found] ` <20220503102345.22817-5-nancy.lin@mediatek.com> @ 2022-05-03 12:19 ` AngeloGioacchino Del Regno 0 siblings, 0 replies; 4+ messages in thread From: AngeloGioacchino Del Regno @ 2022-05-03 12:19 UTC (permalink / raw) To: Nancy.Lin, Rob Herring, Matthias Brugger, Chun-Kuang Hu, Philipp Zabel, wim, linux Cc: David Airlie, Daniel Vetter, Nathan Chancellor, Nick Desaulniers, jason-jh . lin, Yongqiang Niu, devicetree, linux-kernel, linux-arm-kernel, linux-mediatek, dri-devel, llvm, singo.chang, Project_Global_Chrome_Upstream_Group Il 03/05/22 12:23, Nancy.Lin ha scritto: > Add new mmsys component: ethdr_mixer and mdp_rdma. These components will > use in mt8195 vdosys1. > > Signed-off-by: Nancy.Lin <nancy.lin@mediatek.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <20220503102345.22817-10-nancy.lin@mediatek.com>]
* Re: [PATCH v19 09/25] soc: mediatek: mmsys: add mmsys for support 64 reset bits [not found] ` <20220503102345.22817-10-nancy.lin@mediatek.com> @ 2022-05-03 12:19 ` AngeloGioacchino Del Regno 0 siblings, 0 replies; 4+ messages in thread From: AngeloGioacchino Del Regno @ 2022-05-03 12:19 UTC (permalink / raw) To: Nancy.Lin, Rob Herring, Matthias Brugger, Chun-Kuang Hu, Philipp Zabel, wim, linux Cc: David Airlie, Daniel Vetter, Nathan Chancellor, Nick Desaulniers, jason-jh . lin, Yongqiang Niu, devicetree, linux-kernel, linux-arm-kernel, linux-mediatek, dri-devel, llvm, singo.chang, Project_Global_Chrome_Upstream_Group Il 03/05/22 12:23, Nancy.Lin ha scritto: > Add mmsys for support 64 reset bits. It is a preparation for MT8195 > vdosys1 HW reset. MT8195 vdosys1 has more than 32 reset bits. > > 1. Add the number of reset bits in mmsys private data > 2. move the whole "reset register code section" behind the > "get mmsys->data" code section for getting the num_resets in mmsys->data. > > Signed-off-by: Nancy.Lin <nancy.lin@mediatek.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <20220503102345.22817-7-nancy.lin@mediatek.com>]
* Re: [PATCH v19 06/25] soc: mediatek: add mtk_mmsys_write_reg API [not found] ` <20220503102345.22817-7-nancy.lin@mediatek.com> @ 2022-05-03 12:19 ` AngeloGioacchino Del Regno 0 siblings, 0 replies; 4+ messages in thread From: AngeloGioacchino Del Regno @ 2022-05-03 12:19 UTC (permalink / raw) To: Nancy.Lin, Rob Herring, Matthias Brugger, Chun-Kuang Hu, Philipp Zabel, wim, linux Cc: David Airlie, Daniel Vetter, Nathan Chancellor, Nick Desaulniers, jason-jh . lin, Yongqiang Niu, devicetree, linux-kernel, linux-arm-kernel, linux-mediatek, dri-devel, llvm, singo.chang, Project_Global_Chrome_Upstream_Group Il 03/05/22 12:23, Nancy.Lin ha scritto: > Add mtk_mmsys_write_reg API. Simplify code for writing mmsys reg. > It is a preparation for adding support for mmsys config API. > > Signed-off-by: Nancy.Lin <nancy.lin@mediatek.com> > --- > drivers/soc/mediatek/mtk-mmsys.c | 35 ++++++++++++++------------------ > 1 file changed, 15 insertions(+), 20 deletions(-) > > diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c > index ab3c5cbb0175..3e2e5e3f721d 100644 > --- a/drivers/soc/mediatek/mtk-mmsys.c > +++ b/drivers/soc/mediatek/mtk-mmsys.c > @@ -191,22 +191,26 @@ static int mtk_mmsys_find_match_drvdata(struct mtk_mmsys *mmsys, > return -EINVAL; > } > > +static void mtk_mmsys_write_reg(struct mtk_mmsys *mmsys, u32 offset, u32 mask, u32 val) > +{ > + u32 tmp; > + > + tmp = readl_relaxed(mmsys->regs + offset); > + tmp = (tmp & ~mask) | val; > + writel_relaxed(tmp, mmsys->regs + offset); > +} > + Uhm... this is the equivalent of regmap_update_bits(): I fear that calling this mtk_mmsys_write_reg() may lead to confusion. I think that a more appropriate name would be mtk_mmsys_update_bits() or something similar, recalling that this is not just a register write, but a RMW. Regards, Angelo ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-05-03 12:19 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <20220503102345.22817-1-nancy.lin@mediatek.com> [not found] ` <20220503102345.22817-12-nancy.lin@mediatek.com> 2022-05-03 12:19 ` [PATCH v19 11/25] soc: mediatek: add mtk-mutex component - dp_intf1 AngeloGioacchino Del Regno [not found] ` <20220503102345.22817-5-nancy.lin@mediatek.com> 2022-05-03 12:19 ` [PATCH v19 04/25] soc: mediatek: add mtk-mmsys ethdr and mdp_rdma components AngeloGioacchino Del Regno [not found] ` <20220503102345.22817-10-nancy.lin@mediatek.com> 2022-05-03 12:19 ` [PATCH v19 09/25] soc: mediatek: mmsys: add mmsys for support 64 reset bits AngeloGioacchino Del Regno [not found] ` <20220503102345.22817-7-nancy.lin@mediatek.com> 2022-05-03 12:19 ` [PATCH v19 06/25] soc: mediatek: add mtk_mmsys_write_reg API AngeloGioacchino Del Regno
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).