* [PATCH] ata: pata_octeon_cf: make of_device_ids const.
@ 2017-06-16 11:54 Arvind Yadav
2017-06-19 18:04 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-06-16 11:54 UTC (permalink / raw)
To: b.zolnierkie, tj; +Cc: linux-ide, linux-kernel
of_device_ids are not supposed to change at runtime. All functions
working with of_device_ids provided by <linux/of.h> work with const
of_device_ids. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
465 696 4 1165 48d drivers/ata/pata_octeon_cf.o
File size after constify octeon_cf_match.
text data bss dec hex filename
865 280 4 1149 47d drivers/ata/pata_octeon_cf.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/ata/pata_octeon_cf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/pata_octeon_cf.c b/drivers/ata/pata_octeon_cf.c
index f524a90..1ba03d6 100644
--- a/drivers/ata/pata_octeon_cf.c
+++ b/drivers/ata/pata_octeon_cf.c
@@ -1038,7 +1038,7 @@ static void octeon_cf_shutdown(struct device *dev)
}
}
-static struct of_device_id octeon_cf_match[] = {
+static const struct of_device_id octeon_cf_match[] = {
{
.compatible = "cavium,ebt3000-compact-flash",
},
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ata: pata_octeon_cf: make of_device_ids const.
2017-06-16 11:54 [PATCH] ata: pata_octeon_cf: make of_device_ids const Arvind Yadav
@ 2017-06-19 18:04 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2017-06-19 18:04 UTC (permalink / raw)
To: Arvind Yadav; +Cc: b.zolnierkie, linux-ide, linux-kernel
On Fri, Jun 16, 2017 at 05:24:41PM +0530, Arvind Yadav wrote:
> of_device_ids are not supposed to change at runtime. All functions
> working with of_device_ids provided by <linux/of.h> work with const
> of_device_ids. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 465 696 4 1165 48d drivers/ata/pata_octeon_cf.o
>
> File size after constify octeon_cf_match.
> text data bss dec hex filename
> 865 280 4 1149 47d drivers/ata/pata_octeon_cf.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Applied to libata/for-4.13.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-19 18:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-16 11:54 [PATCH] ata: pata_octeon_cf: make of_device_ids const Arvind Yadav
2017-06-19 18:04 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).