From: Markus Elfring <Markus.Elfring@web.de>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
kernel-janitors@vger.kernel.org,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Joe Perches <joe@perches.com>, Kees Cook <keescook@chromium.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Steven Rostedt <rostedt@goodmis.org>,
Aditya Pakki <pakki001@umn.edu>, Kangjie Lu <kjlu@umn.edu>,
Navid Emamdoost <emamd001@umn.edu>,
Stephen McCamant <smccaman@umn.edu>,
Coccinelle <cocci@systeme.lip6.fr>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: Searching for missing variable checks
Date: Fri, 11 Oct 2019 07:15:53 +0200 [thread overview]
Message-ID: <dd1adf86-1bc1-2ffe-1af8-3d7082c5a468@web.de> (raw)
In-Reply-To: <954c5d70-742f-7b0e-57ad-ea967e93be89@rasmusvillemoes.dk>
> The problem is the __must_check does not mean that the
> return value must be followed by a comparison to NULL and bailing out
> (that can't really be checked), it simply ensures the return value is
> assigned somewhere or used in an if(). So foo->bar = kstrdup() not
> followed by a check of foo->bar won't warn.
Higher level source code analysis tools like the semantic patch language
(Coccinelle software) can help to find such missing checks.
Would you like to point any additional development tools out
for this purpose?
Regards,
Markus
next prev parent reply other threads:[~2019-10-11 5:16 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 12:14 [PATCH] string.h: Mark 34 functions with __must_check Markus Elfring
2019-10-09 13:26 ` Rasmus Villemoes
2019-10-09 13:56 ` Dan Carpenter
2019-10-09 14:21 ` Rasmus Villemoes
2019-10-09 14:30 ` Dan Carpenter
2019-10-09 16:31 ` Nick Desaulniers
2019-10-09 18:45 ` Dan Carpenter
2019-10-10 7:20 ` Rasmus Villemoes
2019-10-09 16:37 ` Nick Desaulniers
2019-10-09 16:42 ` Markus Elfring
2019-10-11 5:15 ` Markus Elfring [this message]
2019-10-09 15:09 ` [PATCH] " Steven Rostedt
2019-10-09 16:13 ` Nick Desaulniers
2019-10-09 16:27 ` Steven Rostedt
2019-10-09 16:40 ` Nick Desaulniers
2019-10-09 17:04 ` Markus Elfring
2019-10-09 17:33 ` Nick Desaulniers
2019-10-09 18:06 ` Markus Elfring
2019-10-09 16:38 ` [PATCH] " Joe Perches
2019-10-09 17:33 ` Nick Desaulniers
2019-10-10 14:27 ` David Sterba
2019-10-10 14:34 ` Joe Perches
2019-10-11 5:00 ` Markus Elfring
2019-10-10 15:46 ` [PATCH] " David Laight
2019-10-09 20:06 ` Markus Elfring
2019-10-10 5:29 ` Andy Shevchenko
2019-10-10 7:25 ` Markus Elfring
2019-12-21 9:30 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd1adf86-1bc1-2ffe-1af8-3d7082c5a468@web.de \
--to=markus.elfring@web.de \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=cocci@systeme.lip6.fr \
--cc=emamd001@umn.edu \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=ndesaulniers@google.com \
--cc=pakki001@umn.edu \
--cc=rostedt@goodmis.org \
--cc=smccaman@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).