From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Yakir Yang <ykk@rock-chips.com>, Marc Zyngier <marc.zyngier@arm.com>
Cc: "Heiko Stübner" <heiko@sntech.de>,
"Inki Dae" <inki.dae@samsung.com>,
"Andrzej Hajda" <a.hajda@samsung.com>,
"Joonyoung Shim" <jy0922.shim@samsung.com>,
"Seung-Woo Kim" <sw0312.kim@samsung.com>,
"Kyungmin Park" <kyungmin.park@samsung.com>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Thierry Reding" <treding@nvidia.com>,
"Krzysztof Kozlowski" <k.kozlowski@samsung.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Yao" <mark.yao@rock-chips.com>,
"Russell King" <linux@arm.linux.org.uk>,
djkurtz@chromium.org, "Sean Paul" <seanpaul@chromium.org>,
"Kukjin Kim" <kgene@kernel.org>,
"Kumar Gala" <galak@codeaurora.org>,
emil.l.velikov@gmail.com,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Gustavo Padovan" <gustavo.padovan@collabora.co.uk>,
"Kishon Vijay Abraham I" <kishon@ti.com>,
"Pawel Moll" <pawel.moll@arm.com>,
ajaynumb@gmail.com, robherring2@gmail.com,
"Andy Yan" <andy.yan@rock-chips.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v14.1 01/17] drm: bridge: analogix/dp: split exynos dp driver to bridge directory
Date: Wed, 8 Jun 2016 10:19:04 -0400 [thread overview]
Message-ID: <ddbe174b-c3f8-be97-1b3f-dcdcf45ffc7f@osg.samsung.com> (raw)
In-Reply-To: <5757F917.2030506@rock-chips.com>
On 06/08/2016 06:53 AM, Yakir Yang wrote:
> Marc, Javier
>
> On 06/08/2016 03:44 PM, Marc Zyngier wrote:
>> On Wed, 8 Jun 2016 09:28:32 +0800
>> Yakir Yang <ykk@rock-chips.com> wrote:
>>
>>> Hi Javier,
>>>
>>> On 06/08/2016 01:06 AM, Javier Martinez Canillas wrote:
>>>> Hello Yakir,
>>>>
>>>> On 03/17/2016 05:47 PM, Heiko Stübner wrote:
>>>>> Split the dp core driver from exynos directory to bridge directory,
>>>>> and rename the core driver to analogix_dp_*, rename the platform
>>>>> code to exynos_dp.
>>>>>
>>>>> Beside the new analogix_dp driver would export six hooks.
>>>>> "analogix_dp_bind()" and "analogix_dp_unbind()"
>>>>> "analogix_dp_suspned()" and "analogix_dp_resume()"
>>>>> "analogix_dp_detect()" and "analogix_dp_get_modes()"
>>>>>
>>>>> The bind/unbind symbols is used for analogix platform driver to connect
>>>>> with analogix_dp core driver. And the detect/get_modes is used for analogix
>>>>> platform driver to init the connector.
>>>>>
>>>>> They reason why connector need register in helper driver is rockchip drm
>>>>> haven't implement the atomic API, but Exynos drm have implement it, so
>>>>> there would need two different connector helper functions, that's why we
>>>>> leave the connector register in helper driver.
>>>>>
>>>>> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
>>>>> ---
>>>> Marc reported that his Exynos5250 Snow Chromebook fails to boot with v4.7-rc.
>>>>
>>>> I've done a git bisect and tracked down to this commit. The problem is a NULL
>>>> pointer dereference to connector->dev in drm_mode_create(connector->dev) when
>>>> called from exynos_dp_get_modes(). The error log is at [1].
>>>>
>>>> I'm trying to figure out the issue but wanted to mention in case you have any
>>>> hints about what could be the cause. AFAICT the problem is related to the fact
>>>> that drm_connector_init() is called in analogix_dp_bridge_attach() and the
>>>> connector passed as argument is the one in struct analogix_dp_device *dp, but
>>>> later exynos_dp_get_modes() calls drm_mode_create() passing the connector in
>>>> struct exynos_dp_device *dp, which has not been previously initialized.
>>> Agree, this should be the problem, exynos_dp->connector haven't been
>>> initialized, driver should make exynos_dp->dp to a connector point, and
>>> record the passing connector in exynos_dp_bridge_attach(), that should
>>> fix this problem.
>>>
>>>
>>> Thanks,
>>> - Yakir
>>>
>>>
>>> diff --git a/drivers/gpu/drm/exynos/exynos_dp.c
>>> b/drivers/gpu/drm/exynos/exynos_dp.c
>>> index 468498e..4c1fb3f 100644
>>> --- a/drivers/gpu/drm/exynos/exynos_dp.c
>>> +++ b/drivers/gpu/drm/exynos/exynos_dp.c
>>> @@ -34,7 +34,7 @@
>>>
>>> struct exynos_dp_device {
>>> struct drm_encoder encoder;
>>> - struct drm_connector connector;
>>> + struct drm_connector *connector;
>>> struct drm_bridge *ptn_bridge;
>>> struct drm_device *drm_dev;
>>> struct device *dev;
>>> @@ -70,7 +70,7 @@ static int exynos_dp_poweroff(struct
>>> analogix_dp_plat_data *plat_data)
>>> static int exynos_dp_get_modes(struct analogix_dp_plat_data *plat_data)
>>> {
>>> struct exynos_dp_device *dp = to_dp(plat_data);
>>> - struct drm_connector *connector = &dp->connector;
>>> + struct drm_connector *connector = dp->connector;
>>> struct drm_display_mode *mode;
>>> int num_modes = 0;
>>>
>>> @@ -103,6 +103,7 @@ static int exynos_dp_bridge_attach(struct
>>> analogix_dp_plat_data *plat_data,
>>> int ret;
>>>
>>> drm_connector_register(connector);
>>> + dp->connector = connector;
>>>
>>> /* Pre-empt DP connector creation if there's a bridge */
>>> if (dp->ptn_bridge) {
>>>
>> I've just tested this change, and in combination with Javier's DT patch,
>> my Snow is back to its useful state (I'm writing this email from that
>> very Chromebook).
>>
Great. I also tested and the Snow booted but I don't have physical access
to check if the display was brought correctly, So thanks a lot for testing.
>> Once you make this a proper patch, please add my:
>>
>> Tested-by: Marc Zyngier <marc.zyngier@arm.com>
>
> I guess Javier should be the best one to create this patch, if he have no time, i would do it for him. thanks for your report ;)
>
Done.
> - Yakir
>
>> to it.
>>
>> Thanks a lot to you and Javier for tracking this down!
>>
Thanks to you for reporting all the issues!
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
next prev parent reply other threads:[~2016-06-08 14:19 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 11:08 [PATCH v14 0/17] Add Analogix Core Display Port Driver Yakir Yang
2016-02-15 11:09 ` [PATCH v14 01/17] drm: bridge: analogix/dp: split exynos dp driver to bridge directory Yakir Yang
2016-03-17 21:47 ` [PATCH v14.1 " Heiko Stübner
2016-03-18 7:01 ` Caesar Wang
2016-06-07 17:06 ` Javier Martinez Canillas
2016-06-08 1:28 ` Yakir Yang
2016-06-08 7:44 ` Marc Zyngier
2016-06-08 10:53 ` Yakir Yang
2016-06-08 14:19 ` Javier Martinez Canillas [this message]
2016-03-30 20:32 ` [v14, " Guenter Roeck
2016-03-31 9:56 ` Thierry Reding
2016-03-31 16:02 ` Doug Anderson
2016-04-05 2:15 ` Yakir Yang
2016-03-31 15:57 ` Doug Anderson
2016-04-05 1:49 ` Yakir Yang
2016-02-15 11:09 ` [PATCH v14 02/17] drm/exynos: dp: rename implementation specific driver part Yakir Yang
2016-02-15 11:09 ` [PATCH v14 03/17] drm: bridge: analogix/dp: rename register constants Yakir Yang
2016-02-15 11:09 ` [PATCH v14 04/17] drm: bridge: analogix/dp: fix some obvious code style Yakir Yang
2016-03-17 21:48 ` Heiko Stübner
2016-03-17 21:50 ` [PATCH v14.1 " Heiko Stübner
2016-02-15 11:10 ` [PATCH v14 05/17] drm: bridge: analogix/dp: remove duplicate configuration of link rate and link count Yakir Yang
2016-02-15 11:10 ` [PATCH v14 06/17] drm: bridge: analogix/dp: dynamic parse sync_pol & interlace & dynamic_range Yakir Yang
2016-02-15 11:10 ` [PATCH v14 07/17] dt-bindings: add document for analogix display port driver Yakir Yang
2016-02-15 11:10 ` [PATCH v14 08/17] ARM: dts: exynos/dp: remove some properties that deprecated by analogix_dp driver Yakir Yang
2016-02-15 11:10 ` [PATCH v14 09/17] drm: rockchip: dp: add rockchip platform dp driver Yakir Yang
2016-03-17 21:51 ` [PATCH v14.1 " Heiko Stübner
2016-03-18 6:45 ` Caesar Wang
2016-03-23 1:08 ` [PATCH v14 " Mark yao
2016-02-15 11:10 ` [PATCH v14 10/17] dt-bindings: add document for rockchip variant of analogix_dp Yakir Yang
2016-02-15 11:10 ` [PATCH v14 11/17] drm: bridge: analogix/dp: add some rk3288 special registers setting Yakir Yang
2016-03-18 6:56 ` Caesar Wang
2016-02-15 11:11 ` [PATCH v14 12/17] drm: bridge: analogix/dp: add max link rate and lane count limit for RK3288 Yakir Yang
2016-02-15 11:11 ` [PATCH v14 13/17] drm: bridge: analogix/dp: try force hpd after plug in lookup failed Yakir Yang
2016-02-15 11:11 ` [PATCH v14 14/17] drm: bridge: analogix/dp: move hpd detect to connector detect function Yakir Yang
2016-02-15 11:11 ` [PATCH v14 15/17] drm: bridge: analogix/dp: add edid modes parse in get_modes method Yakir Yang
2016-02-15 11:11 ` [PATCH v14 16/17] drm: bridge: analogix/dp: add panel prepare/unprepare in suspend/resume time Yakir Yang
2016-02-15 11:11 ` [PATCH v14 17/17] drm: bridge: analogix/dp: Fix the possible dead lock in bridge disable time Yakir Yang
2016-03-18 6:41 ` [PATCH v14 0/17] Add Analogix Core Display Port Driver Caesar Wang
2016-03-18 22:53 ` Doug Anderson
2016-03-22 19:19 ` Javier Martinez Canillas
2016-03-22 22:12 ` Who is going to merge it [Was: Re: [PATCH v14 0/17] Add Analogix Core Display Port Driver] Heiko Stübner
2016-03-22 22:44 ` Inki Dae
2016-03-22 22:52 ` Heiko Stübner
2016-03-22 23:09 ` Inki Dae
2016-03-22 23:39 ` Russell King - ARM Linux
2016-03-22 23:54 ` Inki Dae
2016-03-23 0:08 ` Russell King - ARM Linux
2016-03-23 0:41 ` Dave Airlie
2016-03-23 1:08 ` Mark yao
2016-03-23 15:49 ` Thierry Reding
2017-11-13 1:11 ` Yakir Yang
2016-03-24 13:01 ` [PATCH v14 0/17] Add Analogix Core Display Port Driver Heiko Stübner
2016-03-31 10:15 ` Daniel Vetter
2016-03-31 10:22 ` Thierry Reding
2016-04-05 2:06 ` Yakir Yang
2016-07-29 8:38 ` Tomeu Vizoso
2016-08-01 1:49 ` Yakir Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddbe174b-c3f8-be97-1b3f-dcdcf45ffc7f@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=a.hajda@samsung.com \
--cc=ajaynumb@gmail.com \
--cc=andy.yan@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=djkurtz@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=galak@codeaurora.org \
--cc=gustavo.padovan@collabora.co.uk \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=inki.dae@samsung.com \
--cc=jingoohan1@gmail.com \
--cc=jy0922.shim@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=kishon@ti.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=marc.zyngier@arm.com \
--cc=mark.yao@rock-chips.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=robherring2@gmail.com \
--cc=seanpaul@chromium.org \
--cc=sw0312.kim@samsung.com \
--cc=treding@nvidia.com \
--cc=ykk@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).