[PATCH 0/2] arm64: dts: qcom: Add dma-coherent property on

[PATCH 0/2] arm64: dts: qcom: Add dma-coherent property on

[Ling Xu]

Add dma-coherent property to fastRPC context bank nodes on sm8550 and
sm8650 dtsi files to pass dma sequence test in fastrpc sanity test,
ensure that data integrity is matained during DMA operations.

Ling Xu (2):
  arm64: dts: qcom: sm8550: Add dma-coherent property
  arm64: dts: qcom: sm8650: Add dma-coherent property

 arch/arm64/boot/dts/qcom/sm8550.dtsi | 13 +++++++++++++
 arch/arm64/boot/dts/qcom/sm8650.dtsi | 13 +++++++++++++
 2 files changed, 26 insertions(+)


base-commit: 774551425799cb5bbac94e1768fd69eec4f78dd4
-- 
2.17.1

[PATCH 1/2] arm64: dts: qcom: sm8550: Add dma-coherent property

[Ling Xu]

Add dma-coherent property to fastRPC context bank nodes to pass dma
sequence test in fastrpc sanity test, ensure that data integrity is
maintained during DMA operations.

Signed-off-by: Ling Xu <quic_lxu5@quicinc.com>
---
 arch/arm64/boot/dts/qcom/sm8550.dtsi | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
index ee1ba5a8c8fc..00bb803940fc 100644
--- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
@@ -4254,6 +4254,7 @@
 						reg = <3>;
 						iommus = <&apps_smmu 0x1003 0x80>,
 							 <&apps_smmu 0x1063 0x0>;
+						dma-coherent;
 					};
 
 					compute-cb@4 {
@@ -4261,6 +4262,7 @@
 						reg = <4>;
 						iommus = <&apps_smmu 0x1004 0x80>,
 							 <&apps_smmu 0x1064 0x0>;
+						dma-coherent;
 					};
 
 					compute-cb@5 {
@@ -4268,6 +4270,7 @@
 						reg = <5>;
 						iommus = <&apps_smmu 0x1005 0x80>,
 							 <&apps_smmu 0x1065 0x0>;
+						dma-coherent;
 					};
 
 					compute-cb@6 {
@@ -4275,6 +4278,7 @@
 						reg = <6>;
 						iommus = <&apps_smmu 0x1006 0x80>,
 							 <&apps_smmu 0x1066 0x0>;
+						dma-coherent;
 					};
 
 					compute-cb@7 {
@@ -4282,6 +4286,7 @@
 						reg = <7>;
 						iommus = <&apps_smmu 0x1007 0x80>,
 							 <&apps_smmu 0x1067 0x0>;
+						dma-coherent;
 					};
 				};
 
@@ -4388,6 +4393,7 @@
 						iommus = <&apps_smmu 0x1961 0x0>,
 							 <&apps_smmu 0x0c01 0x20>,
 							 <&apps_smmu 0x19c1 0x10>;
+						dma-coherent;
 					};
 
 					compute-cb@2 {
@@ -4396,6 +4402,7 @@
 						iommus = <&apps_smmu 0x1962 0x0>,
 							 <&apps_smmu 0x0c02 0x20>,
 							 <&apps_smmu 0x19c2 0x10>;
+						dma-coherent;
 					};
 
 					compute-cb@3 {
@@ -4404,6 +4411,7 @@
 						iommus = <&apps_smmu 0x1963 0x0>,
 							 <&apps_smmu 0x0c03 0x20>,
 							 <&apps_smmu 0x19c3 0x10>;
+						dma-coherent;
 					};
 
 					compute-cb@4 {
@@ -4412,6 +4420,7 @@
 						iommus = <&apps_smmu 0x1964 0x0>,
 							 <&apps_smmu 0x0c04 0x20>,
 							 <&apps_smmu 0x19c4 0x10>;
+						dma-coherent;
 					};
 
 					compute-cb@5 {
@@ -4420,6 +4429,7 @@
 						iommus = <&apps_smmu 0x1965 0x0>,
 							 <&apps_smmu 0x0c05 0x20>,
 							 <&apps_smmu 0x19c5 0x10>;
+						dma-coherent;
 					};
 
 					compute-cb@6 {
@@ -4428,6 +4438,7 @@
 						iommus = <&apps_smmu 0x1966 0x0>,
 							 <&apps_smmu 0x0c06 0x20>,
 							 <&apps_smmu 0x19c6 0x10>;
+						dma-coherent;
 					};
 
 					compute-cb@7 {
@@ -4436,6 +4447,7 @@
 						iommus = <&apps_smmu 0x1967 0x0>,
 							 <&apps_smmu 0x0c07 0x20>,
 							 <&apps_smmu 0x19c7 0x10>;
+						dma-coherent;
 					};
 
 					compute-cb@8 {
@@ -4444,6 +4456,7 @@
 						iommus = <&apps_smmu 0x1968 0x0>,
 							 <&apps_smmu 0x0c08 0x20>,
 							 <&apps_smmu 0x19c8 0x10>;
+						dma-coherent;
 					};
 
 					/* note: secure cb9 in downstream */
-- 
2.17.1

[PATCH 2/2] arm64: dts: qcom: sm8650: Add dma-coherent property

[Ling Xu]

Add dma-coherent property to fastRPC context bank nodes to pass dma
sequence test in fastrpc sanity test, ensure that data integrity is
maintained during DMA operations.

Signed-off-by: Ling Xu <quic_lxu5@quicinc.com>
---
 arch/arm64/boot/dts/qcom/sm8650.dtsi | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi
index 2df77123a8c7..ed0d0ca34fd4 100644
--- a/arch/arm64/boot/dts/qcom/sm8650.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi
@@ -4808,6 +4808,7 @@
 
 						iommus = <&apps_smmu 0x1003 0x80>,
 							 <&apps_smmu 0x1043 0x20>;
+						dma-coherent;
 					};
 
 					compute-cb@4 {
@@ -4816,6 +4817,7 @@
 
 						iommus = <&apps_smmu 0x1004 0x80>,
 							 <&apps_smmu 0x1044 0x20>;
+						dma-coherent;
 					};
 
 					compute-cb@5 {
@@ -4824,6 +4826,7 @@
 
 						iommus = <&apps_smmu 0x1005 0x80>,
 							 <&apps_smmu 0x1045 0x20>;
+						dma-coherent;
 					};
 
 					compute-cb@6 {
@@ -4832,6 +4835,7 @@
 
 						iommus = <&apps_smmu 0x1006 0x80>,
 							 <&apps_smmu 0x1046 0x20>;
+						dma-coherent;
 					};
 
 					compute-cb@7 {
@@ -4841,6 +4845,7 @@
 						iommus = <&apps_smmu 0x1007 0x40>,
 							 <&apps_smmu 0x1067 0x0>,
 							 <&apps_smmu 0x1087 0x0>;
+						dma-coherent;
 					};
 				};
 
@@ -4961,6 +4966,7 @@
 						iommus = <&apps_smmu 0x1961 0x0>,
 							 <&apps_smmu 0x0c01 0x20>,
 							 <&apps_smmu 0x19c1 0x0>;
+						dma-coherent;
 					};
 
 					compute-cb@2 {
@@ -4970,6 +4976,7 @@
 						iommus = <&apps_smmu 0x1962 0x0>,
 							 <&apps_smmu 0x0c02 0x20>,
 							 <&apps_smmu 0x19c2 0x0>;
+						dma-coherent;
 					};
 
 					compute-cb@3 {
@@ -4979,6 +4986,7 @@
 						iommus = <&apps_smmu 0x1963 0x0>,
 							 <&apps_smmu 0x0c03 0x20>,
 							 <&apps_smmu 0x19c3 0x0>;
+						dma-coherent;
 					};
 
 					compute-cb@4 {
@@ -4988,6 +4996,7 @@
 						iommus = <&apps_smmu 0x1964 0x0>,
 							 <&apps_smmu 0x0c04 0x20>,
 							 <&apps_smmu 0x19c4 0x0>;
+						dma-coherent;
 					};
 
 					compute-cb@5 {
@@ -4997,6 +5006,7 @@
 						iommus = <&apps_smmu 0x1965 0x0>,
 							 <&apps_smmu 0x0c05 0x20>,
 							 <&apps_smmu 0x19c5 0x0>;
+						dma-coherent;
 					};
 
 					compute-cb@6 {
@@ -5006,6 +5016,7 @@
 						iommus = <&apps_smmu 0x1966 0x0>,
 							 <&apps_smmu 0x0c06 0x20>,
 							 <&apps_smmu 0x19c6 0x0>;
+						dma-coherent;
 					};
 
 					compute-cb@7 {
@@ -5015,6 +5026,7 @@
 						iommus = <&apps_smmu 0x1967 0x0>,
 							 <&apps_smmu 0x0c07 0x20>,
 							 <&apps_smmu 0x19c7 0x0>;
+						dma-coherent;
 					};
 
 					compute-cb@8 {
@@ -5024,6 +5036,7 @@
 						iommus = <&apps_smmu 0x1968 0x0>,
 							 <&apps_smmu 0x0c08 0x20>,
 							 <&apps_smmu 0x19c8 0x0>;
+						dma-coherent;
 					};
 				};
 			};
-- 
2.17.1

Re: [PATCH 1/2] arm64: dts: qcom: sm8550: Add dma-coherent property

[Konrad Dybcio]

On 1/25/24 11:24, Ling Xu wrote:
> Add dma-coherent property to fastRPC context bank nodes to pass dma
> sequence test in fastrpc sanity test, ensure that data integrity is
> maintained during DMA operations.
> 
> Signed-off-by: Ling Xu <quic_lxu5@quicinc.com>
> ---

How can we replicate this validation?

Konrad

Re: [PATCH 1/2] arm64: dts: qcom: sm8550: Add dma-coherent property

[Ling Xu]

在 2024/1/26 0:38, Konrad Dybcio 写道:
> 
> 
> On 1/25/24 11:24, Ling Xu wrote:
>> Add dma-coherent property to fastRPC context bank nodes to pass dma
>> sequence test in fastrpc sanity test, ensure that data integrity is
>> maintained during DMA operations.
>>
>> Signed-off-by: Ling Xu <quic_lxu5@quicinc.com>
>> ---
> 
> How can we replicate this validation?
> 
> Konrad

Without this change, case8 and case14 about DMA sequence test in fastRPC sanity test can not pass.

The steps to do fastRPC sanity test is:
1.download code
p4 login
export PATH="$PATH:/prj/qct/asw/qctss/linux/bin/vce"
vce.py view --base fastrpctest.common.1.0 --checkout=<username> --root .
2.compile command
chmod -R 777 ./fastrpc_tests && python3 ./fastrpc_tests/build_fastrpc_test.py -target=LE
3.run fastRPC test
fastrpc_tests_ReleaseG_push_LE.bat
adb shell fastrpc_tests -e (case number) -d 3

-- 
Thx and BRs,
Ling Xu

Re: [PATCH 1/2] arm64: dts: qcom: sm8550: Add dma-coherent property

[Konrad Dybcio]

On 26.01.2024 03:34, Ling Xu wrote:
> 在 2024/1/26 0:38, Konrad Dybcio 写道:
>>
>>
>> On 1/25/24 11:24, Ling Xu wrote:
>>> Add dma-coherent property to fastRPC context bank nodes to pass dma
>>> sequence test in fastrpc sanity test, ensure that data integrity is
>>> maintained during DMA operations.
>>>
>>> Signed-off-by: Ling Xu <quic_lxu5@quicinc.com>
>>> ---
>>
>> How can we replicate this validation?
>>
>> Konrad
> 
> Without this change, case8 and case14 about DMA sequence test in fastRPC sanity test can not pass.
> 
> The steps to do fastRPC sanity test is:
> 1.download code
> p4 login
> export PATH="$PATH:/prj/qct/asw/qctss/linux/bin/vce"
> vce.py view --base fastrpctest.common.1.0 --checkout=<username> --root .

I'm assuming it's not this one.. https://pypi.org/project/vce/


> 2.compile command
> chmod -R 777 ./fastrpc_tests && python3 ./fastrpc_tests/build_fastrpc_test.py -target=LE
> 3.run fastRPC test
> fastrpc_tests_ReleaseG_push_LE.bat
> adb shell fastrpc_tests -e (case number) -d 3
> 

I see, however there has been some talks about halting fastrpc developments
until an open source userspace counterpart is ready, as upstream outright
rejects binary glue..

That said, I am not sure whether I'd be against fixing up the devicetree
component..

Konrad

Re: [PATCH 0/2] arm64: dts: qcom: Add dma-coherent property on

[Bjorn Andersson]

On Thu, 25 Jan 2024 15:54:11 +0530, Ling Xu wrote:
> Add dma-coherent property to fastRPC context bank nodes on sm8550 and
> sm8650 dtsi files to pass dma sequence test in fastrpc sanity test,
> ensure that data integrity is matained during DMA operations.
> 
> Ling Xu (2):
>   arm64: dts: qcom: sm8550: Add dma-coherent property
>   arm64: dts: qcom: sm8650: Add dma-coherent property
> 
> [...]

Applied, thanks!

[1/2] arm64: dts: qcom: sm8550: Add dma-coherent property
      commit: 4a03b85b8491d8bfe84a26ff979507b6ae7122c1
[2/2] arm64: dts: qcom: sm8650: Add dma-coherent property
      commit: feed0507688b7e77755c4cf507d02223137fb8c0

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: [PATCH 2/2] arm64: dts: qcom: sm8650: Add dma-coherent property

[Krzysztof Kozlowski]

On 25/01/2024 11:24, Ling Xu wrote:
> Add dma-coherent property to fastRPC context bank nodes to pass dma
> sequence test in fastrpc sanity test, ensure that data integrity is
> maintained during DMA operations.
> 
> Signed-off-by: Ling Xu <quic_lxu5@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/sm8650.dtsi | 13 +++++++++++++

This wasn't ever tested:

sm8650-qrd.dtb: remoteproc@32300000: glink-edge:fastrpc:compute-cb@1:
'dma-coherent' does not match any of the regexes: 'pinctrl-[0-9]+'

Ling,
How is this testing-patches-before-sending work in different teams? Do
you have such requirement?


Best regards,
Krzysztof

Re: [PATCH 2/2] arm64: dts: qcom: sm8650: Add dma-coherent property

[Krzysztof Kozlowski]

On 12/02/2024 12:00, Krzysztof Kozlowski wrote:
> On 25/01/2024 11:24, Ling Xu wrote:
>> Add dma-coherent property to fastRPC context bank nodes to pass dma
>> sequence test in fastrpc sanity test, ensure that data integrity is
>> maintained during DMA operations.
>>
>> Signed-off-by: Ling Xu <quic_lxu5@quicinc.com>
>> ---
>>  arch/arm64/boot/dts/qcom/sm8650.dtsi | 13 +++++++++++++
> 
> This wasn't ever tested:
> 
> sm8650-qrd.dtb: remoteproc@32300000: glink-edge:fastrpc:compute-cb@1:
> 'dma-coherent' does not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Ling,
> How is this testing-patches-before-sending work in different teams? Do
> you have such requirement?

No clue if the original DTS change should be reverted or these are in
fact DMA coherent, but let's choose one path...

https://lore.kernel.org/linux-devicetree/254c1d14-25e3-4f4c-9e79-4ef7cec4d22f@linaro.org/T/#t

Best regards,
Krzysztof

Re: [PATCH 2/2] arm64: dts: qcom: sm8650: Add dma-coherent property

[Ling Xu]

在 2024/2/12 19:10, Krzysztof Kozlowski 写道:
> On 12/02/2024 12:00, Krzysztof Kozlowski wrote:
>> On 25/01/2024 11:24, Ling Xu wrote:
>>> Add dma-coherent property to fastRPC context bank nodes to pass dma
>>> sequence test in fastrpc sanity test, ensure that data integrity is
>>> maintained during DMA operations.
>>>
>>> Signed-off-by: Ling Xu <quic_lxu5@quicinc.com>
>>> ---
>>>  arch/arm64/boot/dts/qcom/sm8650.dtsi | 13 +++++++++++++
>>
>> This wasn't ever tested:
>>
>> sm8650-qrd.dtb: remoteproc@32300000: glink-edge:fastrpc:compute-cb@1:
>> 'dma-coherent' does not match any of the regexes: 'pinctrl-[0-9]+'
>>
>> Ling,
>> How is this testing-patches-before-sending work in different teams? Do
>> you have such requirement?
> 
> No clue if the original DTS change should be reverted or these are in
> fact DMA coherent, but let's choose one path...
> 
> https://lore.kernel.org/linux-devicetree/254c1d14-25e3-4f4c-9e79-4ef7cec4d22f@linaro.org/T/#t
> 
> Best regards,
> Krzysztof
> 
Hi Krzysztof,
Add dma-coherent: true in this file: Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml at line number 89 can pass the DTcheck.
-- 
Thx and BRs,
Ling Xu

Re: [PATCH 2/2] arm64: dts: qcom: sm8650: Add dma-coherent property

[Krzysztof Kozlowski]

On 12/02/2024 12:31, Ling Xu wrote:
> 在 2024/2/12 19:10, Krzysztof Kozlowski 写道:
>> On 12/02/2024 12:00, Krzysztof Kozlowski wrote:
>>> On 25/01/2024 11:24, Ling Xu wrote:
>>>> Add dma-coherent property to fastRPC context bank nodes to pass dma
>>>> sequence test in fastrpc sanity test, ensure that data integrity is
>>>> maintained during DMA operations.
>>>>
>>>> Signed-off-by: Ling Xu <quic_lxu5@quicinc.com>
>>>> ---
>>>>  arch/arm64/boot/dts/qcom/sm8650.dtsi | 13 +++++++++++++
>>>
>>> This wasn't ever tested:
>>>
>>> sm8650-qrd.dtb: remoteproc@32300000: glink-edge:fastrpc:compute-cb@1:
>>> 'dma-coherent' does not match any of the regexes: 'pinctrl-[0-9]+'
>>>
>>> Ling,
>>> How is this testing-patches-before-sending work in different teams? Do
>>> you have such requirement?
>>
>> No clue if the original DTS change should be reverted or these are in
>> fact DMA coherent, but let's choose one path...
>>
>> https://lore.kernel.org/linux-devicetree/254c1d14-25e3-4f4c-9e79-4ef7cec4d22f@linaro.org/T/#t
>>
>> Best regards,
>> Krzysztof
>>
> Hi Krzysztof,
> Add dma-coherent: true in this file: Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml at line number 89 can pass the DTcheck.

I don't understand your comment. Did you read the link above?

Anyway, I was asking: are you testing the patches before sending?

Best regards,
Krzysztof

Re: [PATCH 2/2] arm64: dts: qcom: sm8650: Add dma-coherent property

[Ling Xu]

在 2024/2/12 19:41, Krzysztof Kozlowski 写道:
> On 12/02/2024 12:31, Ling Xu wrote:
>> 在 2024/2/12 19:10, Krzysztof Kozlowski 写道:
>>> On 12/02/2024 12:00, Krzysztof Kozlowski wrote:
>>>> On 25/01/2024 11:24, Ling Xu wrote:
>>>>> Add dma-coherent property to fastRPC context bank nodes to pass dma
>>>>> sequence test in fastrpc sanity test, ensure that data integrity is
>>>>> maintained during DMA operations.
>>>>>
>>>>> Signed-off-by: Ling Xu <quic_lxu5@quicinc.com>
>>>>> ---
>>>>>  arch/arm64/boot/dts/qcom/sm8650.dtsi | 13 +++++++++++++
>>>>
>>>> This wasn't ever tested:
>>>>
>>>> sm8650-qrd.dtb: remoteproc@32300000: glink-edge:fastrpc:compute-cb@1:
>>>> 'dma-coherent' does not match any of the regexes: 'pinctrl-[0-9]+'
>>>>
>>>> Ling,
>>>> How is this testing-patches-before-sending work in different teams? Do
>>>> you have such requirement?
>>>
>>> No clue if the original DTS change should be reverted or these are in
>>> fact DMA coherent, but let's choose one path...
>>>
>>> https://lore.kernel.org/linux-devicetree/254c1d14-25e3-4f4c-9e79-4ef7cec4d22f@linaro.org/T/#t
>>>
>>> Best regards,
>>> Krzysztof
>>>
>> Hi Krzysztof,
>> Add dma-coherent: true in this file: Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml at line number 89 can pass the DTcheck.
> 
> I don't understand your comment. Did you read the link above?
> 
> Anyway, I was asking: are you testing the patches before sending?
> 
> Best regards,
> Krzysztof
> 
Yes, I tested before sending.
-- 
Thx and BRs,
Ling Xu

Re: [PATCH 2/2] arm64: dts: qcom: sm8650: Add dma-coherent property

[Krzysztof Kozlowski]

On 12/02/2024 12:45, Ling Xu wrote:
>>>> https://lore.kernel.org/linux-devicetree/254c1d14-25e3-4f4c-9e79-4ef7cec4d22f@linaro.org/T/#t
>>>>
>>>> Best regards,
>>>> Krzysztof
>>>>
>>> Hi Krzysztof,
>>> Add dma-coherent: true in this file: Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml at line number 89 can pass the DTcheck.
>>
>> I don't understand your comment. Did you read the link above?
>>
>> Anyway, I was asking: are you testing the patches before sending?
>>
>> Best regards,
>> Krzysztof
>>
> Yes, I tested before sending.

Then I am confused why there is a warning. If this was tested and sent,
it means you sent code with a known warning.

Best regards,
Krzysztof