From: Chao Yu <yuchao0@huawei.com>
To: Jaegeuk Kim <jaegeuk@kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-f2fs-devel@lists.sourceforge.net>,
<kernel-team@android.com>
Cc: Light Hsieh <Light.Hsieh@mediatek.com>
Subject: Re: [f2fs-dev] [PATCH v3] f2fs: avoid race condition for shinker count
Date: Thu, 3 Dec 2020 14:55:50 +0800 [thread overview]
Message-ID: <df364dab-6640-654b-c36e-3f84f4bcbc2b@huawei.com> (raw)
In-Reply-To: <X8iAh7quYw77O6XC@google.com>
On 2020/12/3 14:07, Jaegeuk Kim wrote:
> On 11/11, Jaegeuk Kim wrote:
>> Light reported sometimes shinker gets nat_cnt < dirty_nat_cnt resulting in
>> wrong do_shinker work. Let's avoid to get stale data by using nat_tree_lock.
>>
>> Reported-by: Light Hsieh <Light.Hsieh@mediatek.com>
>> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
>> ---
>> v3:
>> - fix to use NM_I(sbi)
>>
>> fs/f2fs/shrinker.c | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/fs/f2fs/shrinker.c b/fs/f2fs/shrinker.c
>> index d66de5999a26..555712ba06d8 100644
>> --- a/fs/f2fs/shrinker.c
>> +++ b/fs/f2fs/shrinker.c
>> @@ -18,7 +18,11 @@ static unsigned int shrinker_run_no;
>>
>> static unsigned long __count_nat_entries(struct f2fs_sb_info *sbi)
>> {
>> - long count = NM_I(sbi)->nat_cnt - NM_I(sbi)->dirty_nat_cnt;
>> + long count;
>> +
>> + down_read(&NM_I(sbi)->nat_tree_lock);
>> + count = NM_I(sbi)->nat_cnt - NM_I(sbi)->dirty_nat_cnt;
>> + up_read(&NM_I(sbi)->nat_tree_lock);
>
> I just fosund this can give kernel hang due to the following backtrace.
> f2fs_shrink_count
> shrink_slab
> shrink_node
> do_try_to_free_pages
> try_to_free_pages
> __alloc_pages_nodemask
> alloc_pages_current
> allocate_slab
> __slab_alloc
> __slab_alloc
> kmem_cache_alloc
> add_free_nid
> f2fs_flush_nat_entries
> f2fs_write_checkpoint
Oh, I missed that case.
>
> Let me just check like this.
>
>>From 971163330224449d90aac90957ea38f77d494f0f Mon Sep 17 00:00:00 2001
> From: Jaegeuk Kim <jaegeuk@kernel.org>
> Date: Fri, 6 Nov 2020 13:22:05 -0800
> Subject: [PATCH] f2fs: avoid race condition for shrinker count
>
> Light reported sometimes shinker gets nat_cnt < dirty_nat_cnt resulting in
> wrong do_shinker work. Let's avoid to return insane overflowed value.
>
> Reported-by: Light Hsieh <Light.Hsieh@mediatek.com>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
> fs/f2fs/shrinker.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/f2fs/shrinker.c b/fs/f2fs/shrinker.c
> index d66de5999a26..75b5b4aaed99 100644
> --- a/fs/f2fs/shrinker.c
> +++ b/fs/f2fs/shrinker.c
> @@ -18,9 +18,9 @@ static unsigned int shrinker_run_no;
>
> static unsigned long __count_nat_entries(struct f2fs_sb_info *sbi)
> {
> - long count = NM_I(sbi)->nat_cnt - NM_I(sbi)->dirty_nat_cnt;
> -
> - return count > 0 ? count : 0;
> + if (NM_I(sbi)->nat_cnt > NM_I(sbi)->dirty_nat_cnt)
> + return NM_I(sbi)->nat_cnt - NM_I(sbi)->dirty_nat_cnt;
Hmm.. in the case that we are not in checkpoint progress, nat_cnt and dirty_nat_cnt
is mutable, how can we make sure the calculation is non-negative after the check
condition? :(
Thanks
> + return 0;
> }
>
> static unsigned long __count_free_nids(struct f2fs_sb_info *sbi)
>
next prev parent reply other threads:[~2020-12-03 6:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 17:00 [PATCH] f2fs: avoid race condition for shinker count Jaegeuk Kim
2020-11-10 2:15 ` [f2fs-dev] " Chao Yu
2020-11-10 4:19 ` Jaegeuk Kim
2020-11-10 6:04 ` Chao Yu
2020-11-12 5:31 ` Jaegeuk Kim
2020-11-12 5:34 ` [PATCH v2] " Jaegeuk Kim
2020-11-12 5:40 ` [f2fs-dev] [PATCH v3] " Jaegeuk Kim
2020-11-12 6:57 ` Chao Yu
2020-11-17 16:40 ` Jaegeuk Kim
2020-12-03 6:07 ` Jaegeuk Kim
2020-12-03 6:55 ` Chao Yu [this message]
2020-12-03 7:55 ` Jaegeuk Kim
2020-12-03 8:16 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df364dab-6640-654b-c36e-3f84f4bcbc2b@huawei.com \
--to=yuchao0@huawei.com \
--cc=Light.Hsieh@mediatek.com \
--cc=jaegeuk@kernel.org \
--cc=kernel-team@android.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).