* [PATCH] dt-bindings: ti,k3: Use common ti,k3-sci-common.yaml schema
@ 2023-01-25 22:13 Rob Herring
2023-02-02 19:46 ` Péter Ujfalusi
2023-02-02 23:17 ` Rob Herring
0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring @ 2023-01-25 22:13 UTC (permalink / raw)
To: Peter Ujfalusi, Vinod Koul, Krzysztof Kozlowski,
Santosh Shilimkar, Grygorii Strashko
Cc: Peter Ujfalusi, dmaengine, devicetree, linux-kernel
Instead of redefining the 'ti,sci' and 'ti,sci-dev-id' properties multiple
times, reference the common schema where they are defined. Most cases
using these properties already do this, just udma and ringacc need to be
fixed.
Signed-off-by: Rob Herring <robh@kernel.org>
---
.../devicetree/bindings/dma/ti/k3-udma.yaml | 9 +--------
.../devicetree/bindings/soc/ti/k3-ringacc.yaml | 13 ++++---------
2 files changed, 5 insertions(+), 17 deletions(-)
diff --git a/Documentation/devicetree/bindings/dma/ti/k3-udma.yaml b/Documentation/devicetree/bindings/dma/ti/k3-udma.yaml
index 7ff428ad3aae..97f6ae9b1236 100644
--- a/Documentation/devicetree/bindings/dma/ti/k3-udma.yaml
+++ b/Documentation/devicetree/bindings/dma/ti/k3-udma.yaml
@@ -44,6 +44,7 @@ description: |
allOf:
- $ref: "../dma-controller.yaml#"
+ - $ref: /schemas/arm/keystone/ti,k3-sci-common.yaml#
properties:
"#dma-cells":
@@ -78,14 +79,6 @@ properties:
msi-parent: true
- ti,sci:
- description: phandle to TI-SCI compatible System controller node
- $ref: /schemas/types.yaml#/definitions/phandle
-
- ti,sci-dev-id:
- description: TI-SCI device id of UDMAP
- $ref: /schemas/types.yaml#/definitions/uint32
-
ti,ringacc:
description: phandle to the ring accelerator node
$ref: /schemas/types.yaml#/definitions/phandle
diff --git a/Documentation/devicetree/bindings/soc/ti/k3-ringacc.yaml b/Documentation/devicetree/bindings/soc/ti/k3-ringacc.yaml
index ddea3d41971d..22cf9002fee7 100644
--- a/Documentation/devicetree/bindings/soc/ti/k3-ringacc.yaml
+++ b/Documentation/devicetree/bindings/soc/ti/k3-ringacc.yaml
@@ -25,6 +25,9 @@ description: |
The Ring Accelerator is a hardware module that is responsible for accelerating
management of the packet queues. The K3 SoCs can have more than one RA instances
+allOf:
+ - $ref: /schemas/arm/keystone/ti,k3-sci-common.yaml#
+
properties:
compatible:
items:
@@ -54,14 +57,6 @@ properties:
$ref: /schemas/types.yaml#/definitions/uint32
description: TI-SCI RM subtype for GP ring range
- ti,sci:
- $ref: /schemas/types.yaml#/definitions/phandle-array
- description: phandle on TI-SCI compatible System controller node
-
- ti,sci-dev-id:
- $ref: /schemas/types.yaml#/definitions/uint32
- description: TI-SCI device id of the ring accelerator
-
required:
- compatible
- reg
@@ -72,7 +67,7 @@ required:
- ti,sci
- ti,sci-dev-id
-additionalProperties: false
+unevaluatedProperties: false
examples:
- |
--
2.39.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: ti,k3: Use common ti,k3-sci-common.yaml schema
2023-01-25 22:13 [PATCH] dt-bindings: ti,k3: Use common ti,k3-sci-common.yaml schema Rob Herring
@ 2023-02-02 19:46 ` Péter Ujfalusi
2023-02-02 23:17 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Péter Ujfalusi @ 2023-02-02 19:46 UTC (permalink / raw)
To: Rob Herring, Vinod Koul, Krzysztof Kozlowski, Santosh Shilimkar,
Grygorii Strashko
Cc: Peter Ujfalusi, dmaengine, devicetree, linux-kernel
On 26/01/2023 00:13, Rob Herring wrote:
> Instead of redefining the 'ti,sci' and 'ti,sci-dev-id' properties multiple
> times, reference the common schema where they are defined. Most cases
> using these properties already do this, just udma and ringacc need to be
> fixed.
Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../devicetree/bindings/dma/ti/k3-udma.yaml | 9 +--------
> .../devicetree/bindings/soc/ti/k3-ringacc.yaml | 13 ++++---------
> 2 files changed, 5 insertions(+), 17 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/dma/ti/k3-udma.yaml b/Documentation/devicetree/bindings/dma/ti/k3-udma.yaml
> index 7ff428ad3aae..97f6ae9b1236 100644
> --- a/Documentation/devicetree/bindings/dma/ti/k3-udma.yaml
> +++ b/Documentation/devicetree/bindings/dma/ti/k3-udma.yaml
> @@ -44,6 +44,7 @@ description: |
>
> allOf:
> - $ref: "../dma-controller.yaml#"
> + - $ref: /schemas/arm/keystone/ti,k3-sci-common.yaml#
>
> properties:
> "#dma-cells":
> @@ -78,14 +79,6 @@ properties:
>
> msi-parent: true
>
> - ti,sci:
> - description: phandle to TI-SCI compatible System controller node
> - $ref: /schemas/types.yaml#/definitions/phandle
> -
> - ti,sci-dev-id:
> - description: TI-SCI device id of UDMAP
> - $ref: /schemas/types.yaml#/definitions/uint32
> -
> ti,ringacc:
> description: phandle to the ring accelerator node
> $ref: /schemas/types.yaml#/definitions/phandle
> diff --git a/Documentation/devicetree/bindings/soc/ti/k3-ringacc.yaml b/Documentation/devicetree/bindings/soc/ti/k3-ringacc.yaml
> index ddea3d41971d..22cf9002fee7 100644
> --- a/Documentation/devicetree/bindings/soc/ti/k3-ringacc.yaml
> +++ b/Documentation/devicetree/bindings/soc/ti/k3-ringacc.yaml
> @@ -25,6 +25,9 @@ description: |
> The Ring Accelerator is a hardware module that is responsible for accelerating
> management of the packet queues. The K3 SoCs can have more than one RA instances
>
> +allOf:
> + - $ref: /schemas/arm/keystone/ti,k3-sci-common.yaml#
> +
> properties:
> compatible:
> items:
> @@ -54,14 +57,6 @@ properties:
> $ref: /schemas/types.yaml#/definitions/uint32
> description: TI-SCI RM subtype for GP ring range
>
> - ti,sci:
> - $ref: /schemas/types.yaml#/definitions/phandle-array
> - description: phandle on TI-SCI compatible System controller node
> -
> - ti,sci-dev-id:
> - $ref: /schemas/types.yaml#/definitions/uint32
> - description: TI-SCI device id of the ring accelerator
> -
> required:
> - compatible
> - reg
> @@ -72,7 +67,7 @@ required:
> - ti,sci
> - ti,sci-dev-id
>
> -additionalProperties: false
> +unevaluatedProperties: false
>
> examples:
> - |
--
Péter
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: ti,k3: Use common ti,k3-sci-common.yaml schema
2023-01-25 22:13 [PATCH] dt-bindings: ti,k3: Use common ti,k3-sci-common.yaml schema Rob Herring
2023-02-02 19:46 ` Péter Ujfalusi
@ 2023-02-02 23:17 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2023-02-02 23:17 UTC (permalink / raw)
To: Rob Herring
Cc: Vinod Koul, Grygorii Strashko, devicetree, linux-kernel,
Santosh Shilimkar, Peter Ujfalusi, Peter Ujfalusi,
Krzysztof Kozlowski, dmaengine
On Wed, 25 Jan 2023 16:13:39 -0600, Rob Herring wrote:
> Instead of redefining the 'ti,sci' and 'ti,sci-dev-id' properties multiple
> times, reference the common schema where they are defined. Most cases
> using these properties already do this, just udma and ringacc need to be
> fixed.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../devicetree/bindings/dma/ti/k3-udma.yaml | 9 +--------
> .../devicetree/bindings/soc/ti/k3-ringacc.yaml | 13 ++++---------
> 2 files changed, 5 insertions(+), 17 deletions(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-02 23:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-25 22:13 [PATCH] dt-bindings: ti,k3: Use common ti,k3-sci-common.yaml schema Rob Herring
2023-02-02 19:46 ` Péter Ujfalusi
2023-02-02 23:17 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).