* [PATCH] proc: remove unused macro
@ 2020-01-21 10:25 Alex Shi
2020-01-21 10:28 ` David Hildenbrand
0 siblings, 1 reply; 2+ messages in thread
From: Alex Shi @ 2020-01-21 10:25 UTC (permalink / raw)
Cc: Alexey Dobriyan, Andrew Morton, David Hildenbrand,
Michael S. Tsirkin, Pankaj gupta, Konstantin Khlebnikov,
linux-kernel, linux-fsdevel
KPMBITS is never used from it was introduced. better to remove it.
Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: David Hildenbrand <david@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Pankaj gupta <pagupta@redhat.com>
Cc: Konstantin Khlebnikov <koct9i@gmail.com>
Cc: linux-kernel@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org
---
fs/proc/page.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/proc/page.c b/fs/proc/page.c
index 7c952ee732e6..c4b1005a82bc 100644
--- a/fs/proc/page.c
+++ b/fs/proc/page.c
@@ -19,7 +19,6 @@
#define KPMSIZE sizeof(u64)
#define KPMMASK (KPMSIZE - 1)
-#define KPMBITS (KPMSIZE * BITS_PER_BYTE)
/* /proc/kpagecount - an array exposing page counts
*
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] proc: remove unused macro
2020-01-21 10:25 [PATCH] proc: remove unused macro Alex Shi
@ 2020-01-21 10:28 ` David Hildenbrand
0 siblings, 0 replies; 2+ messages in thread
From: David Hildenbrand @ 2020-01-21 10:28 UTC (permalink / raw)
To: Alex Shi
Cc: Alexey Dobriyan, Andrew Morton, Michael S. Tsirkin, Pankaj gupta,
Konstantin Khlebnikov, linux-kernel, linux-fsdevel
On 21.01.20 11:25, Alex Shi wrote:
> KPMBITS is never used from it was introduced. better to remove it.
I suggest
"fs/proc/page.c: remove unused macro KPMBITS
KPMBITS was never used since it was introduced in commit 3c3fc71c8cfa
("mm: introduce idle page tracking"). Let's remove it.
"
Reviewed-by: David Hildenbrand <david@redhat.com>
>
> Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
> Cc: Alexey Dobriyan <adobriyan@gmail.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: David Hildenbrand <david@redhat.com>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Pankaj gupta <pagupta@redhat.com>
> Cc: Konstantin Khlebnikov <koct9i@gmail.com>
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-fsdevel@vger.kernel.org
> ---
> fs/proc/page.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/proc/page.c b/fs/proc/page.c
> index 7c952ee732e6..c4b1005a82bc 100644
> --- a/fs/proc/page.c
> +++ b/fs/proc/page.c
> @@ -19,7 +19,6 @@
>
> #define KPMSIZE sizeof(u64)
> #define KPMMASK (KPMSIZE - 1)
> -#define KPMBITS (KPMSIZE * BITS_PER_BYTE)
>
> /* /proc/kpagecount - an array exposing page counts
> *
>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-21 10:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-21 10:25 [PATCH] proc: remove unused macro Alex Shi
2020-01-21 10:28 ` David Hildenbrand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).