* [PATCH] blk-bwt: fix old-style function declaration
@ 2016-11-16 15:29 Arnd Bergmann
2016-11-16 15:33 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2016-11-16 15:29 UTC (permalink / raw)
To: Jens Axboe; +Cc: Arnd Bergmann, linux-block, linux-kernel
The newly added driver causes a harmless warning in some configurations:
block/blk-wbt.c:250:1: error: ‘inline’ is not at beginning of declaration [-Werror=old-style-declaration]
static bool inline stat_sample_valid(struct blk_rq_stat *stat)
This makes it use the expected format for the declaration.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
block/blk-wbt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/blk-wbt.c b/block/blk-wbt.c
index 20712f0db6ea..9f97594e68ce 100644
--- a/block/blk-wbt.c
+++ b/block/blk-wbt.c
@@ -247,7 +247,7 @@ static bool calc_wb_limits(struct rq_wb *rwb)
return ret;
}
-static bool inline stat_sample_valid(struct blk_rq_stat *stat)
+static inline bool stat_sample_valid(struct blk_rq_stat *stat)
{
/*
* We need at least one read sample, and a minimum of
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] blk-bwt: fix old-style function declaration
2016-11-16 15:29 [PATCH] blk-bwt: fix old-style function declaration Arnd Bergmann
@ 2016-11-16 15:33 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2016-11-16 15:33 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: linux-block, linux-kernel
On 11/16/2016 08:29 AM, Arnd Bergmann wrote:
> The newly added driver causes a harmless warning in some configurations:
>
> block/blk-wbt.c:250:1: error: ‘inline’ is not at beginning of declaration [-Werror=old-style-declaration]
> static bool inline stat_sample_valid(struct blk_rq_stat *stat)
>
> This makes it use the expected format for the declaration.
Thanks Arnd, applied with the subject typo fixed up.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-16 15:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-16 15:29 [PATCH] blk-bwt: fix old-style function declaration Arnd Bergmann
2016-11-16 15:33 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).