* Re: [PATCH] drm/i915/gem: Fix inconsistent IS_ERR and PTR_ERR
@ 2020-05-04 16:58 Markus Elfring
0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2020-05-04 16:58 UTC (permalink / raw)
To: Gustavo A. R. Silva, dri-devel, intel-gfx
Cc: linux-kernel, kernel-janitors, Chris Wilson, Daniel Vetter,
David Airlie, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi,
Tvrtko Ursulin
…
> The proper pointer to be passed as argument is ce.
>
> This bug was detected with the help of Coccinelle.
My software development attention was caught also by your commit message.
…
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> @@ -1325,7 +1325,7 @@ static int __reloc_gpu_alloc(struct i915_execbuffer *eb,
>
> ce = intel_context_create(engine);
> if (IS_ERR(ce)) {
> - err = PTR_ERR(rq);
> + err = PTR_ERR(ce);
> goto err_unpin;
> }
>
Are you looking for any more questionable identifier (or expression) combinations
also at other places by the means of advanced source code analysis?
Regards,
Markus
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-05-04 16:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-04 16:58 [PATCH] drm/i915/gem: Fix inconsistent IS_ERR and PTR_ERR Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).