* [PATCH v1] slimbus: core: Set fwnode for a device when setting of_node
@ 2020-03-26 6:16 Saravana Kannan
2020-03-26 7:27 ` Greg Kroah-Hartman
2020-03-26 13:08 ` Srinivas Kandagatla
0 siblings, 2 replies; 3+ messages in thread
From: Saravana Kannan @ 2020-03-26 6:16 UTC (permalink / raw)
To: Srinivas Kandagatla
Cc: Saravana Kannan, John Stultz, Greg Kroah-Hartman, kernel-team,
alsa-devel, linux-kernel
When setting the of_node for a newly created device, also set the
fwnode. This allows fw_devlink to work for slimbus devices.
Signed-off-by: Saravana Kannan <saravanak@google.com>
Change-Id: I5505213f8ecca908860a1ad6bbc275ec0f78e4a6
---
drivers/slimbus/core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c
index 526e3215d8fe..44228a5b246d 100644
--- a/drivers/slimbus/core.c
+++ b/drivers/slimbus/core.c
@@ -163,8 +163,10 @@ static int slim_add_device(struct slim_controller *ctrl,
INIT_LIST_HEAD(&sbdev->stream_list);
spin_lock_init(&sbdev->stream_list_lock);
- if (node)
+ if (node) {
sbdev->dev.of_node = of_node_get(node);
+ sbdev->dev.fwnode = of_fwnode_handle(node);
+ }
dev_set_name(&sbdev->dev, "%x:%x:%x:%x",
sbdev->e_addr.manf_id,
--
2.25.1.696.g5e7596f4ac-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1] slimbus: core: Set fwnode for a device when setting of_node
2020-03-26 6:16 [PATCH v1] slimbus: core: Set fwnode for a device when setting of_node Saravana Kannan
@ 2020-03-26 7:27 ` Greg Kroah-Hartman
2020-03-26 13:08 ` Srinivas Kandagatla
1 sibling, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2020-03-26 7:27 UTC (permalink / raw)
To: Saravana Kannan
Cc: Srinivas Kandagatla, John Stultz, kernel-team, alsa-devel, linux-kernel
On Wed, Mar 25, 2020 at 11:16:48PM -0700, Saravana Kannan wrote:
> When setting the of_node for a newly created device, also set the
> fwnode. This allows fw_devlink to work for slimbus devices.
>
> Signed-off-by: Saravana Kannan <saravanak@google.com>
> Change-Id: I5505213f8ecca908860a1ad6bbc275ec0f78e4a6
-ENOCHANGEID :(
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] slimbus: core: Set fwnode for a device when setting of_node
2020-03-26 6:16 [PATCH v1] slimbus: core: Set fwnode for a device when setting of_node Saravana Kannan
2020-03-26 7:27 ` Greg Kroah-Hartman
@ 2020-03-26 13:08 ` Srinivas Kandagatla
1 sibling, 0 replies; 3+ messages in thread
From: Srinivas Kandagatla @ 2020-03-26 13:08 UTC (permalink / raw)
To: Saravana Kannan
Cc: John Stultz, Greg Kroah-Hartman, kernel-team, alsa-devel, linux-kernel
Thanks for doing this!
On 26/03/2020 06:16, Saravana Kannan wrote:
> When setting the of_node for a newly created device, also set the
> fwnode. This allows fw_devlink to work for slimbus devices.
>
> Signed-off-by: Saravana Kannan <saravanak@google.com>
> Change-Id: I5505213f8ecca908860a1ad6bbc275ec0f78e4a6
Once Change-Id is removed as Greg suggested!
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
--srini
> ---
> drivers/slimbus/core.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c
> index 526e3215d8fe..44228a5b246d 100644
> --- a/drivers/slimbus/core.c
> +++ b/drivers/slimbus/core.c
> @@ -163,8 +163,10 @@ static int slim_add_device(struct slim_controller *ctrl,
> INIT_LIST_HEAD(&sbdev->stream_list);
> spin_lock_init(&sbdev->stream_list_lock);
>
> - if (node)
> + if (node) {
> sbdev->dev.of_node = of_node_get(node);
> + sbdev->dev.fwnode = of_fwnode_handle(node);
> + }
>
> dev_set_name(&sbdev->dev, "%x:%x:%x:%x",
> sbdev->e_addr.manf_id,
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-26 13:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-26 6:16 [PATCH v1] slimbus: core: Set fwnode for a device when setting of_node Saravana Kannan
2020-03-26 7:27 ` Greg Kroah-Hartman
2020-03-26 13:08 ` Srinivas Kandagatla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).