From: Fabio Aiuto <fabioaiuto83@gmail.com>
To: gregkh@linuxfoundation.org
Cc: joe@perches.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org,
Fabio Aiuto <fabioaiuto83@gmail.com>
Subject: [PATCH 25/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in hal/rtl8723bs_xmit.c
Date: Wed, 31 Mar 2021 11:39:53 +0200 [thread overview]
Message-ID: <e06a037ec6164c21908986f1a89c8600183a8edd.1617183374.git.fabioaiuto83@gmail.com> (raw)
In-Reply-To: <cover.1617183374.git.fabioaiuto83@gmail.com>
replace private macro RT_TRACE for tracing with in-kernel
pr_* printk wrappers
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
---
.../staging/rtl8723bs/hal/rtl8723bs_xmit.c | 42 ++++++-------------
1 file changed, 13 insertions(+), 29 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
index 597cf3a88c51..ad27ba1592ed 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
@@ -102,11 +102,8 @@ static s32 rtl8723_dequeue_writeport(struct adapter *padapter)
(padapter->bSurpriseRemoved) ||
(padapter->bDriverStopped)
) {
- RT_TRACE(
- _module_hal_xmit_c_,
- _drv_notice_,
- ("%s: bSurpriseRemoved(write port)\n", __func__)
- );
+ pr_notice("%s %s: bSurpriseRemoved(write port)\n",
+ DRIVER_PREFIX, __func__);
goto free_xmitbuf;
}
@@ -151,16 +148,9 @@ s32 rtl8723bs_xmit_buf_handler(struct adapter *padapter)
ret = (padapter->bDriverStopped) || (padapter->bSurpriseRemoved);
if (ret) {
- RT_TRACE(
- _module_hal_xmit_c_,
- _drv_err_,
- (
- "%s: bDriverStopped(%d) bSurpriseRemoved(%d)!\n",
- __func__,
- padapter->bDriverStopped,
- padapter->bSurpriseRemoved
- )
- );
+ pr_err("%s %s: bDriverStopped(%d) bSurpriseRemoved(%d)!\n",
+ DRIVER_PREFIX, __func__, padapter->bDriverStopped,
+ padapter->bSurpriseRemoved);
return _FAIL;
}
@@ -374,7 +364,8 @@ static s32 xmit_xmitframes(struct adapter *padapter, struct xmit_priv *pxmitpriv
/* dump xmit_buf to hw tx fifo */
if (pxmitbuf) {
- RT_TRACE(_module_hal_xmit_c_, _drv_info_, ("pxmitbuf->len =%d enqueue\n", pxmitbuf->len));
+ pr_info("%s pxmitbuf->len =%d enqueue\n",
+ DRIVER_PREFIX, pxmitbuf->len);
if (pxmitbuf->len > 0) {
struct xmit_frame *pframe;
@@ -424,16 +415,9 @@ static s32 rtl8723bs_xmit_handler(struct adapter *padapter)
(padapter->bDriverStopped) ||
(padapter->bSurpriseRemoved)
) {
- RT_TRACE(
- _module_hal_xmit_c_,
- _drv_notice_,
- (
- "%s: bDriverStopped(%d) bSurpriseRemoved(%d)\n",
- __func__,
- padapter->bDriverStopped,
- padapter->bSurpriseRemoved
- )
- );
+ pr_notice("%s %s: bDriverStopped(%d) bSurpriseRemoved(%d)\n",
+ DRIVER_PREFIX, __func__, padapter->bDriverStopped,
+ padapter->bSurpriseRemoved);
return _FAIL;
}
@@ -492,7 +476,7 @@ int rtl8723bs_xmit_thread(void *context)
complete(&pxmitpriv->SdioXmitTerminate);
- RT_TRACE(_module_hal_xmit_c_, _drv_notice_, ("-%s\n", __func__));
+ pr_notice("%s-%s\n", DRIVER_PREFIX, __func__);
thread_exit();
}
@@ -509,7 +493,7 @@ s32 rtl8723bs_mgnt_xmit(
u8 *pframe = (u8 *)(pmgntframe->buf_addr) + TXDESC_OFFSET;
u8 txdesc_size = TXDESC_SIZE;
- RT_TRACE(_module_hal_xmit_c_, _drv_info_, ("+%s\n", __func__));
+ pr_info("%s+%s\n", DRIVER_PREFIX, __func__);
pattrib = &pmgntframe->attrib;
pxmitbuf = pmgntframe->pxmitbuf;
@@ -572,7 +556,7 @@ s32 rtl8723bs_hal_xmit(
err = rtw_xmitframe_enqueue(padapter, pxmitframe);
spin_unlock_bh(&pxmitpriv->lock);
if (err != _SUCCESS) {
- RT_TRACE(_module_hal_xmit_c_, _drv_err_, ("rtl8723bs_hal_xmit: enqueue xmitframe fail\n"));
+ pr_err("%s %s: enqueue xmitframe fail\n", DRIVER_PREFIX, __func__);
rtw_free_xmitframe(pxmitpriv, pxmitframe);
pxmitpriv->tx_drop++;
--
2.20.1
next prev parent reply other threads:[~2021-03-31 9:42 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 9:39 [PATCH 00/40] staging: rtl8723bs: replace RT_TRACE private macro Fabio Aiuto
2021-03-31 9:39 ` [PATCH 01/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in core/rtw_xmit.c Fabio Aiuto
2021-03-31 10:16 ` Dan Carpenter
2021-03-31 9:39 ` [PATCH 02/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in core/rtw_security.c Fabio Aiuto
2021-03-31 9:39 ` [PATCH 03/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in core/rtw_eeprom.c Fabio Aiuto
2021-03-31 10:27 ` Greg KH
2021-03-31 10:36 ` Fabio Aiuto
2021-03-31 10:48 ` Greg KH
2021-03-31 12:19 ` Fabio Aiuto
2021-03-31 10:55 ` Fabio Aiuto
2021-03-31 11:14 ` Greg KH
2021-03-31 12:17 ` Fabio Aiuto
2021-04-01 9:10 ` Fabio Aiuto
2021-03-31 9:39 ` [PATCH 04/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in core/rtw_pwrctrl.c Fabio Aiuto
2021-03-31 9:39 ` [PATCH 05/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in core/rtw_cmd.c Fabio Aiuto
2021-03-31 9:39 ` [PATCH 06/40] staging: rtl8723bs: remove commented RT_TRACE calls in core/rtw_mlme.c Fabio Aiuto
2021-03-31 9:39 ` [PATCH 07/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers " Fabio Aiuto
2021-03-31 9:39 ` [PATCH 08/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in core/rtw_mlme_ext.c Fabio Aiuto
2021-03-31 9:39 ` [PATCH 09/40] staging: rtl8723bs: remove commented RT_TRACE calls in core/rtw_recv.c Fabio Aiuto
2021-03-31 9:39 ` [PATCH 10/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers " Fabio Aiuto
2021-03-31 9:39 ` [PATCH 11/40] staging: rtl8723bs: remove commented RT_TRACE call in core/rtw_ioctl_set.c Fabio Aiuto
2021-03-31 9:39 ` [PATCH 12/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers " Fabio Aiuto
2021-03-31 9:39 ` [PATCH 13/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in core/rtw_wlan_util.c Fabio Aiuto
2021-03-31 9:39 ` [PATCH 14/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in core/rtw_sta_mgt.c Fabio Aiuto
2021-03-31 9:39 ` [PATCH 15/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in core/rtw_ieee80211.c Fabio Aiuto
2021-03-31 9:39 ` [PATCH 16/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in hal/HalPwrSeqCmd.c Fabio Aiuto
2021-03-31 9:39 ` [PATCH 17/40] staging: rtl8723bs: fix constant name in hal/rtl8723b_hal_init.c Fabio Aiuto
2021-03-31 9:39 ` [PATCH 18/40] staging: rtl8723bs: added driver prefix in log messages Fabio Aiuto
2021-03-31 9:39 ` [PATCH 19/40] staging: rtl8723bs: remove commented RT_TRACE call in hal/rtl8723b_hal_init.c Fabio Aiuto
2021-03-31 9:39 ` [PATCH 20/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers " Fabio Aiuto
2021-03-31 9:39 ` [PATCH 21/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in hal/sdio_ops.c Fabio Aiuto
2021-03-31 9:39 ` [PATCH 22/40] staging: rtl8723bs: remove commented code block in hal/hal_com_phycfg.c Fabio Aiuto
2021-03-31 9:39 ` [PATCH 23/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in hal/rtl8723b_phycfg.c Fabio Aiuto
2021-03-31 9:39 ` [PATCH 24/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in hal/hal_intf.c Fabio Aiuto
2021-03-31 9:39 ` Fabio Aiuto [this message]
2021-03-31 9:39 ` [PATCH 26/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in hal/sdio_halinit.c Fabio Aiuto
2021-03-31 9:39 ` [PATCH 27/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in hal/rtl8723bs_recv.c Fabio Aiuto
2021-03-31 9:39 ` [PATCH 28/40] staging: rtl8723bs: remove commented RT_TRACE calls in hal/HalPhyRf_8723B.c Fabio Aiuto
2021-03-31 9:39 ` [PATCH 29/40] staging: rtl8723bs: remove commented RT_TRACE calls in hal/rtl8723b_rf6052.c Fabio Aiuto
2021-03-31 9:39 ` [PATCH 30/40] staging: rtl8723bs: remove commented RT_TRACE calls in os_dep/ioctl_linux.c Fabio Aiuto
2021-03-31 9:39 ` [PATCH 31/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers " Fabio Aiuto
2021-03-31 9:40 ` [PATCH 32/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in os_dep/mlme_linux.c Fabio Aiuto
2021-03-31 9:40 ` [PATCH 33/40] staging: rtl8723bs: fix string format in os_dep/ioctl_cfg80211.c Fabio Aiuto
2021-03-31 9:40 ` [PATCH 34/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers " Fabio Aiuto
2021-03-31 9:40 ` [PATCH 35/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in os_dep/os_intfs.c Fabio Aiuto
2021-03-31 9:40 ` [PATCH 36/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in os_dep/recv_linux.c Fabio Aiuto
2021-03-31 9:40 ` [PATCH 37/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in os_dep/sdio_intf.c Fabio Aiuto
2021-03-31 9:40 ` [PATCH 38/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in os_dep/xmit_linux.c Fabio Aiuto
2021-03-31 9:40 ` [PATCH 39/40] staging: rtl8723bs: replace RT_TRACE with public printk wrappers in os_dep/osdep_service.c Fabio Aiuto
2021-03-31 9:40 ` [PATCH 40/40] staging: rtl8723bs: remove obsolete debug macro Fabio Aiuto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e06a037ec6164c21908986f1a89c8600183a8edd.1617183374.git.fabioaiuto83@gmail.com \
--to=fabioaiuto83@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).