linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] misc: ocxl: context: Remove unnecessary (void*) conversions
@ 2023-11-13  1:15 Li zeming
  2023-11-14 12:52 ` Frederic Barrat
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Li zeming @ 2023-11-13  1:15 UTC (permalink / raw)
  To: fbarrat, ajd, arnd, gregkh; +Cc: linuxppc-dev, linux-kernel, Li zeming

The ctx pointer does not need to cast the type.

Signed-off-by: Li zeming <zeming@nfschina.com>
---
 drivers/misc/ocxl/context.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/ocxl/context.c b/drivers/misc/ocxl/context.c
index 7f83116ae11a6..cded7d1caf328 100644
--- a/drivers/misc/ocxl/context.c
+++ b/drivers/misc/ocxl/context.c
@@ -55,7 +55,7 @@ EXPORT_SYMBOL_GPL(ocxl_context_alloc);
  */
 static void xsl_fault_error(void *data, u64 addr, u64 dsisr)
 {
-	struct ocxl_context *ctx = (struct ocxl_context *) data;
+	struct ocxl_context *ctx = data;
 
 	mutex_lock(&ctx->xsl_error_lock);
 	ctx->xsl_error.addr = addr;
-- 
2.18.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] misc: ocxl: context: Remove unnecessary (void*) conversions
  2023-11-13  1:15 [PATCH] misc: ocxl: context: Remove unnecessary (void*) conversions Li zeming
@ 2023-11-14 12:52 ` Frederic Barrat
  2023-11-20  4:06 ` Andrew Donnellan
  2023-12-07 12:38 ` Michael Ellerman
  2 siblings, 0 replies; 4+ messages in thread
From: Frederic Barrat @ 2023-11-14 12:52 UTC (permalink / raw)
  To: Li zeming, ajd, arnd, gregkh; +Cc: linuxppc-dev, linux-kernel



On 13/11/2023 02:15, Li zeming wrote:
> The ctx pointer does not need to cast the type.
> 
> Signed-off-by: Li zeming <zeming@nfschina.com>
> ---


Indeed, it's useless.
Acked-by: Frederic Barrat <fbarrat@linux.ibm.com>


>   drivers/misc/ocxl/context.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/ocxl/context.c b/drivers/misc/ocxl/context.c
> index 7f83116ae11a6..cded7d1caf328 100644
> --- a/drivers/misc/ocxl/context.c
> +++ b/drivers/misc/ocxl/context.c
> @@ -55,7 +55,7 @@ EXPORT_SYMBOL_GPL(ocxl_context_alloc);
>    */
>   static void xsl_fault_error(void *data, u64 addr, u64 dsisr)
>   {
> -	struct ocxl_context *ctx = (struct ocxl_context *) data;
> +	struct ocxl_context *ctx = data;
>   
>   	mutex_lock(&ctx->xsl_error_lock);
>   	ctx->xsl_error.addr = addr;

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] misc: ocxl: context: Remove unnecessary (void*) conversions
  2023-11-13  1:15 [PATCH] misc: ocxl: context: Remove unnecessary (void*) conversions Li zeming
  2023-11-14 12:52 ` Frederic Barrat
@ 2023-11-20  4:06 ` Andrew Donnellan
  2023-12-07 12:38 ` Michael Ellerman
  2 siblings, 0 replies; 4+ messages in thread
From: Andrew Donnellan @ 2023-11-20  4:06 UTC (permalink / raw)
  To: Li zeming, fbarrat, arnd, gregkh; +Cc: linuxppc-dev, linux-kernel

On Mon, 2023-11-13 at 09:15 +0800, Li zeming wrote:
> The ctx pointer does not need to cast the type.
> 
> Signed-off-by: Li zeming <zeming@nfschina.com>

Acked-by: Andrew Donnellan <ajd@linux.ibm.com>

> ---
>  drivers/misc/ocxl/context.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/ocxl/context.c
> b/drivers/misc/ocxl/context.c
> index 7f83116ae11a6..cded7d1caf328 100644
> --- a/drivers/misc/ocxl/context.c
> +++ b/drivers/misc/ocxl/context.c
> @@ -55,7 +55,7 @@ EXPORT_SYMBOL_GPL(ocxl_context_alloc);
>   */
>  static void xsl_fault_error(void *data, u64 addr, u64 dsisr)
>  {
> -	struct ocxl_context *ctx = (struct ocxl_context *) data;
> +	struct ocxl_context *ctx = data;
>  
>  	mutex_lock(&ctx->xsl_error_lock);
>  	ctx->xsl_error.addr = addr;

-- 
Andrew Donnellan    OzLabs, ADL Canberra
ajd@linux.ibm.com   IBM Australia Limited

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] misc: ocxl: context: Remove unnecessary (void*) conversions
  2023-11-13  1:15 [PATCH] misc: ocxl: context: Remove unnecessary (void*) conversions Li zeming
  2023-11-14 12:52 ` Frederic Barrat
  2023-11-20  4:06 ` Andrew Donnellan
@ 2023-12-07 12:38 ` Michael Ellerman
  2 siblings, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2023-12-07 12:38 UTC (permalink / raw)
  To: fbarrat, ajd, arnd, gregkh, Li zeming; +Cc: linuxppc-dev, linux-kernel

On Mon, 13 Nov 2023 09:15:43 +0800, Li zeming wrote:
> The ctx pointer does not need to cast the type.
> 
> 

Applied to powerpc/next.

[1/1] misc: ocxl: context: Remove unnecessary (void*) conversions
      https://git.kernel.org/powerpc/c/82d30723d58fccbd2d7d707fab7649b541fafa1b

cheers

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-12-07 12:44 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-13  1:15 [PATCH] misc: ocxl: context: Remove unnecessary (void*) conversions Li zeming
2023-11-14 12:52 ` Frederic Barrat
2023-11-20  4:06 ` Andrew Donnellan
2023-12-07 12:38 ` Michael Ellerman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).