* [PATCH] drm/msm: Fix error return code in msm_drm_init()
@ 2020-11-17 2:36 Wei Li
2020-11-17 19:52 ` abhinavk
0 siblings, 1 reply; 2+ messages in thread
From: Wei Li @ 2020-11-17 2:36 UTC (permalink / raw)
To: Rob Clark, Sean Paul, David Airlie, Daniel Vetter, Rajesh Yadav,
Sravanthi Kollukuduru, Abhinav Kumar
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel, guohanjun
When it fail to create crtc_event kthread, it just jump to err_msm_uninit,
while the 'ret' is not updated. So assign the return code before that.
Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Li <liwei391@huawei.com>
---
drivers/gpu/drm/msm/msm_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
index 49685571dc0e..37a373c5ced3 100644
--- a/drivers/gpu/drm/msm/msm_drv.c
+++ b/drivers/gpu/drm/msm/msm_drv.c
@@ -506,6 +506,7 @@ static int msm_drm_init(struct device *dev, struct drm_driver *drv)
"crtc_event:%d", priv->event_thread[i].crtc_id);
if (IS_ERR(priv->event_thread[i].worker)) {
DRM_DEV_ERROR(dev, "failed to create crtc_event kthread\n");
+ ret = PTR_ERR(priv->event_thread[i].worker);
goto err_msm_uninit;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/msm: Fix error return code in msm_drm_init()
2020-11-17 2:36 [PATCH] drm/msm: Fix error return code in msm_drm_init() Wei Li
@ 2020-11-17 19:52 ` abhinavk
0 siblings, 0 replies; 2+ messages in thread
From: abhinavk @ 2020-11-17 19:52 UTC (permalink / raw)
To: Wei Li
Cc: Rob Clark, Sean Paul, David Airlie, Daniel Vetter, Rajesh Yadav,
Sravanthi Kollukuduru, linux-arm-msm, dri-devel, freedreno,
linux-kernel, guohanjun
On 2020-11-16 18:36, Wei Li wrote:
> When it fail to create crtc_event kthread, it just jump to
> err_msm_uninit,
> while the 'ret' is not updated. So assign the return code before that.
>
> Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Li <liwei391@huawei.com>
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
> ---
> drivers/gpu/drm/msm/msm_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/msm/msm_drv.c
> b/drivers/gpu/drm/msm/msm_drv.c
> index 49685571dc0e..37a373c5ced3 100644
> --- a/drivers/gpu/drm/msm/msm_drv.c
> +++ b/drivers/gpu/drm/msm/msm_drv.c
> @@ -506,6 +506,7 @@ static int msm_drm_init(struct device *dev, struct
> drm_driver *drv)
> "crtc_event:%d", priv->event_thread[i].crtc_id);
> if (IS_ERR(priv->event_thread[i].worker)) {
> DRM_DEV_ERROR(dev, "failed to create crtc_event kthread\n");
> + ret = PTR_ERR(priv->event_thread[i].worker);
> goto err_msm_uninit;
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-17 19:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-17 2:36 [PATCH] drm/msm: Fix error return code in msm_drm_init() Wei Li
2020-11-17 19:52 ` abhinavk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).