From: Matthias Brugger <matthias.bgg@gmail.com>
To: Ming-Fan Chen <ming-fan.chen@mediatek.com>,
Rob Herring <robh+dt@kernel.org>, Joerg Roedel <jroedel@suse.de>
Cc: Yong Wu <yong.wu@mediatek.com>, Evan Green <evgreen@chromium.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, wsd_upstream@mediatek.com
Subject: Re: [PATCH v3 2/3] memory: mtk-smi: Add basic support for MT6779
Date: Wed, 12 Feb 2020 12:23:04 +0100 [thread overview]
Message-ID: <e183a614-0635-d631-d37b-c6864b22b3e7@gmail.com> (raw)
In-Reply-To: <1578465691-30692-4-git-send-email-ming-fan.chen@mediatek.com>
On 08/01/2020 07:41, Ming-Fan Chen wrote:
> Add smi-larb and smi-common nodes and config_port for MT6779.
>
> changelog since v2:
> Split basic nodes and config_port support from initial golden setting patch
>
> Signed-off-by: Ming-Fan Chen <ming-fan.chen@mediatek.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> drivers/memory/mtk-smi.c | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c
> index 439d7d8..d0b747a 100644
> --- a/drivers/memory/mtk-smi.c
> +++ b/drivers/memory/mtk-smi.c
> @@ -239,6 +239,13 @@ static void mtk_smi_larb_config_port_gen1(struct device *dev)
> .larb_direct_to_common_mask = BIT(8) | BIT(9), /* bdpsys */
> };
>
> +static const struct mtk_smi_larb_gen mtk_smi_larb_mt6779 = {
> + .config_port = mtk_smi_larb_config_port_gen2_general,
> + .larb_direct_to_common_mask =
> + BIT(4) | BIT(6) | BIT(11) | BIT(12) | BIT(13),
> + /* DUMMY | IPU0 | IPU1 | CCU | MDLA */
> +};
> +
> static const struct mtk_smi_larb_gen mtk_smi_larb_mt8183 = {
> .has_gals = true,
> .config_port = mtk_smi_larb_config_port_gen2_general,
> @@ -260,6 +267,10 @@ static void mtk_smi_larb_config_port_gen1(struct device *dev)
> .data = &mtk_smi_larb_mt2712
> },
> {
> + .compatible = "mediatek,mt6779-smi-larb",
> + .data = &mtk_smi_larb_mt6779
> + },
> + {
> .compatible = "mediatek,mt8183-smi-larb",
> .data = &mtk_smi_larb_mt8183
> },
> @@ -386,6 +397,13 @@ static int __maybe_unused mtk_smi_larb_suspend(struct device *dev)
> .gen = MTK_SMI_GEN2,
> };
>
> +static const struct mtk_smi_common_plat mtk_smi_common_mt6779 = {
> + .gen = MTK_SMI_GEN2,
> + .has_gals = true,
> + .bus_sel = F_MMU1_LARB(1) | F_MMU1_LARB(2) | F_MMU1_LARB(4) |
> + F_MMU1_LARB(5) | F_MMU1_LARB(6) | F_MMU1_LARB(7),
> +};
> +
> static const struct mtk_smi_common_plat mtk_smi_common_mt8183 = {
> .gen = MTK_SMI_GEN2,
> .has_gals = true,
> @@ -407,6 +425,10 @@ static int __maybe_unused mtk_smi_larb_suspend(struct device *dev)
> .data = &mtk_smi_common_gen2,
> },
> {
> + .compatible = "mediatek,mt6779-smi-common",
> + .data = &mtk_smi_common_mt6779,
> + },
> + {
> .compatible = "mediatek,mt8183-smi-common",
> .data = &mtk_smi_common_mt8183,
> },
>
next prev parent reply other threads:[~2020-02-12 11:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 6:41 memory: mtk-smi: Add bandwidth initial golden setting for MT6779 Ming-Fan Chen
2020-01-08 6:41 ` [PATCH v3 0/3] memory: mtk-smi: Add bandwidth initial golden setting Ming-Fan Chen
2020-01-08 6:41 ` [PATCH v3 1/3] dt-bindings: mediatek: Add binding for MT6779 SMI Ming-Fan Chen
2020-01-08 15:15 ` Rob Herring
2020-01-08 6:41 ` [PATCH v3 2/3] memory: mtk-smi: Add basic support for MT6779 Ming-Fan Chen
2020-02-12 11:23 ` Matthias Brugger [this message]
2020-01-08 6:41 ` [PATCH v3 3/3] memory: mtk-smi: Add bandwidth initial golden setting Ming-Fan Chen
2020-02-12 12:17 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e183a614-0635-d631-d37b-c6864b22b3e7@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=evgreen@chromium.org \
--cc=jroedel@suse.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=ming-fan.chen@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=wsd_upstream@mediatek.com \
--cc=yong.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).