From: Martin Habets <mhabets@solarflare.com>
To: YueHaibing <yuehaibing@huawei.com>,
<linux-net-drivers@solarflare.com>, <ecree@solarflare.com>,
<davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] sfc: remove unused variable 'efx_default_channel_type'
Date: Tue, 11 Feb 2020 14:56:50 +0000 [thread overview]
Message-ID: <e246665f-fe9b-ec62-a621-0ea0dff06771@solarflare.com> (raw)
In-Reply-To: <20200211141606.47180-1-yuehaibing@huawei.com>
On 11/02/2020 14:16, YueHaibing wrote:
> drivers/net/ethernet/sfc/efx.c:116:38: warning:
> efx_default_channel_type defined but not used [-Wunused-const-variable=]
This is a good fix, but net-next is closed at the moment. Please resubmit it when it reopens.
> commit 83975485077d ("sfc: move channel alloc/removal code")
> left behind this, remove it.
Please add this info with a "Fixes:" tag.
Thanks,
Martin
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/net/ethernet/sfc/efx.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c
> index 4481f21a1f43..256807c28ff7 100644
> --- a/drivers/net/ethernet/sfc/efx.c
> +++ b/drivers/net/ethernet/sfc/efx.c
> @@ -113,7 +113,6 @@ MODULE_PARM_DESC(debug, "Bitmapped debugging message enable value");
> *
> *************************************************************************/
>
> -static const struct efx_channel_type efx_default_channel_type;
> static void efx_remove_port(struct efx_nic *efx);
> static int efx_xdp_setup_prog(struct efx_nic *efx, struct bpf_prog *prog);
> static int efx_xdp(struct net_device *dev, struct netdev_bpf *xdp);
>
next prev parent reply other threads:[~2020-02-11 14:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 14:16 [PATCH net-next] sfc: remove unused variable 'efx_default_channel_type' YueHaibing
2020-02-11 14:56 ` Martin Habets [this message]
2020-02-19 1:34 ` [PATCH v2 " YueHaibing
2020-02-19 12:35 ` Martin Habets
2020-02-20 0:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e246665f-fe9b-ec62-a621-0ea0dff06771@solarflare.com \
--to=mhabets@solarflare.com \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).