* [PATCH net-next] sfc: remove unused variable 'efx_default_channel_type'
@ 2020-02-11 14:16 YueHaibing
2020-02-11 14:56 ` Martin Habets
2020-02-19 1:34 ` [PATCH v2 " YueHaibing
0 siblings, 2 replies; 5+ messages in thread
From: YueHaibing @ 2020-02-11 14:16 UTC (permalink / raw)
To: linux-net-drivers, ecree, mhabets, davem; +Cc: netdev, linux-kernel, YueHaibing
drivers/net/ethernet/sfc/efx.c:116:38: warning:
efx_default_channel_type defined but not used [-Wunused-const-variable=]
commit 83975485077d ("sfc: move channel alloc/removal code")
left behind this, remove it.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/ethernet/sfc/efx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c
index 4481f21a1f43..256807c28ff7 100644
--- a/drivers/net/ethernet/sfc/efx.c
+++ b/drivers/net/ethernet/sfc/efx.c
@@ -113,7 +113,6 @@ MODULE_PARM_DESC(debug, "Bitmapped debugging message enable value");
*
*************************************************************************/
-static const struct efx_channel_type efx_default_channel_type;
static void efx_remove_port(struct efx_nic *efx);
static int efx_xdp_setup_prog(struct efx_nic *efx, struct bpf_prog *prog);
static int efx_xdp(struct net_device *dev, struct netdev_bpf *xdp);
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] sfc: remove unused variable 'efx_default_channel_type'
2020-02-11 14:16 [PATCH net-next] sfc: remove unused variable 'efx_default_channel_type' YueHaibing
@ 2020-02-11 14:56 ` Martin Habets
2020-02-19 1:34 ` [PATCH v2 " YueHaibing
1 sibling, 0 replies; 5+ messages in thread
From: Martin Habets @ 2020-02-11 14:56 UTC (permalink / raw)
To: YueHaibing, linux-net-drivers, ecree, davem; +Cc: netdev, linux-kernel
On 11/02/2020 14:16, YueHaibing wrote:
> drivers/net/ethernet/sfc/efx.c:116:38: warning:
> efx_default_channel_type defined but not used [-Wunused-const-variable=]
This is a good fix, but net-next is closed at the moment. Please resubmit it when it reopens.
> commit 83975485077d ("sfc: move channel alloc/removal code")
> left behind this, remove it.
Please add this info with a "Fixes:" tag.
Thanks,
Martin
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/net/ethernet/sfc/efx.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c
> index 4481f21a1f43..256807c28ff7 100644
> --- a/drivers/net/ethernet/sfc/efx.c
> +++ b/drivers/net/ethernet/sfc/efx.c
> @@ -113,7 +113,6 @@ MODULE_PARM_DESC(debug, "Bitmapped debugging message enable value");
> *
> *************************************************************************/
>
> -static const struct efx_channel_type efx_default_channel_type;
> static void efx_remove_port(struct efx_nic *efx);
> static int efx_xdp_setup_prog(struct efx_nic *efx, struct bpf_prog *prog);
> static int efx_xdp(struct net_device *dev, struct netdev_bpf *xdp);
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 net-next] sfc: remove unused variable 'efx_default_channel_type'
2020-02-11 14:16 [PATCH net-next] sfc: remove unused variable 'efx_default_channel_type' YueHaibing
2020-02-11 14:56 ` Martin Habets
@ 2020-02-19 1:34 ` YueHaibing
2020-02-19 12:35 ` Martin Habets
2020-02-20 0:26 ` David Miller
1 sibling, 2 replies; 5+ messages in thread
From: YueHaibing @ 2020-02-19 1:34 UTC (permalink / raw)
To: linux-net-drivers, ecree, mhabets, davem, amaftei
Cc: netdev, linux-kernel, YueHaibing
drivers/net/ethernet/sfc/efx.c:116:38: warning:
efx_default_channel_type defined but not used [-Wunused-const-variable=]
commit 83975485077d ("sfc: move channel alloc/removal code")
left behind this, remove it.
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 83975485077d ("sfc: move channel alloc/removal code")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
v2: Add Fixes tag
---
drivers/net/ethernet/sfc/efx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c
index 4481f21..256807c 100644
--- a/drivers/net/ethernet/sfc/efx.c
+++ b/drivers/net/ethernet/sfc/efx.c
@@ -113,7 +113,6 @@ MODULE_PARM_DESC(debug, "Bitmapped debugging message enable value");
*
*************************************************************************/
-static const struct efx_channel_type efx_default_channel_type;
static void efx_remove_port(struct efx_nic *efx);
static int efx_xdp_setup_prog(struct efx_nic *efx, struct bpf_prog *prog);
static int efx_xdp(struct net_device *dev, struct netdev_bpf *xdp);
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2 net-next] sfc: remove unused variable 'efx_default_channel_type'
2020-02-19 1:34 ` [PATCH v2 " YueHaibing
@ 2020-02-19 12:35 ` Martin Habets
2020-02-20 0:26 ` David Miller
1 sibling, 0 replies; 5+ messages in thread
From: Martin Habets @ 2020-02-19 12:35 UTC (permalink / raw)
To: YueHaibing, linux-net-drivers, ecree, davem, amaftei; +Cc: netdev, linux-kernel
On 19/02/2020 01:34, YueHaibing wrote:
> drivers/net/ethernet/sfc/efx.c:116:38: warning:
> efx_default_channel_type defined but not used [-Wunused-const-variable=]
>
> commit 83975485077d ("sfc: move channel alloc/removal code")
> left behind this, remove it.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 83975485077d ("sfc: move channel alloc/removal code")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Martin Habets <mhabets@solarflare.com>
> ---
> v2: Add Fixes tag
> ---
> drivers/net/ethernet/sfc/efx.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c
> index 4481f21..256807c 100644
> --- a/drivers/net/ethernet/sfc/efx.c
> +++ b/drivers/net/ethernet/sfc/efx.c
> @@ -113,7 +113,6 @@ MODULE_PARM_DESC(debug, "Bitmapped debugging message enable value");
> *
> *************************************************************************/
>
> -static const struct efx_channel_type efx_default_channel_type;
> static void efx_remove_port(struct efx_nic *efx);
> static int efx_xdp_setup_prog(struct efx_nic *efx, struct bpf_prog *prog);
> static int efx_xdp(struct net_device *dev, struct netdev_bpf *xdp);
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 net-next] sfc: remove unused variable 'efx_default_channel_type'
2020-02-19 1:34 ` [PATCH v2 " YueHaibing
2020-02-19 12:35 ` Martin Habets
@ 2020-02-20 0:26 ` David Miller
1 sibling, 0 replies; 5+ messages in thread
From: David Miller @ 2020-02-20 0:26 UTC (permalink / raw)
To: yuehaibing
Cc: linux-net-drivers, ecree, mhabets, amaftei, netdev, linux-kernel
From: YueHaibing <yuehaibing@huawei.com>
Date: Wed, 19 Feb 2020 09:34:58 +0800
> drivers/net/ethernet/sfc/efx.c:116:38: warning:
> efx_default_channel_type defined but not used [-Wunused-const-variable=]
>
> commit 83975485077d ("sfc: move channel alloc/removal code")
> left behind this, remove it.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 83975485077d ("sfc: move channel alloc/removal code")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> v2: Add Fixes tag
Applied, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-02-20 0:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-11 14:16 [PATCH net-next] sfc: remove unused variable 'efx_default_channel_type' YueHaibing
2020-02-11 14:56 ` Martin Habets
2020-02-19 1:34 ` [PATCH v2 " YueHaibing
2020-02-19 12:35 ` Martin Habets
2020-02-20 0:26 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).