From: Hannes Reinecke <hare@suse.de>
To: Jason Yan <yanaijie@huawei.com>,
jejb@linux.ibm.com, martin.petersen@oracle.com,
zhengbin13@huawei.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: fcoe: remove unneeded semicolon in fcoe.c
Date: Tue, 21 Apr 2020 07:45:19 +0200 [thread overview]
Message-ID: <e25d02bd-101a-724a-e4e8-2686efc9a6ff@suse.de> (raw)
In-Reply-To: <20200421034008.27865-1-yanaijie@huawei.com>
On 4/21/20 5:40 AM, Jason Yan wrote:
> Fix the following coccicheck warning:
>
> drivers/scsi/fcoe/fcoe.c:1918:3-4: Unneeded semicolon
> drivers/scsi/fcoe/fcoe.c:1930:3-4: Unneeded semicolon
>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
> drivers/scsi/fcoe/fcoe.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
> index 25dae9f0b205..cb41d166e0c0 100644
> --- a/drivers/scsi/fcoe/fcoe.c
> +++ b/drivers/scsi/fcoe/fcoe.c
> @@ -1915,7 +1915,7 @@ static int fcoe_device_notification(struct notifier_block *notifier,
> case FCOE_CTLR_ENABLED:
> case FCOE_CTLR_UNUSED:
> fcoe_ctlr_link_up(ctlr);
> - };
> + }
> } else if (fcoe_ctlr_link_down(ctlr)) {
> switch (cdev->enabled) {
> case FCOE_CTLR_DISABLED:
> @@ -1927,7 +1927,7 @@ static int fcoe_device_notification(struct notifier_block *notifier,
> stats->LinkFailureCount++;
> put_cpu();
> fcoe_clean_pending_queue(lport);
> - };
> + }
> }
> out:
> return rc;
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
next prev parent reply other threads:[~2020-04-21 5:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 3:40 [PATCH] scsi: fcoe: remove unneeded semicolon in fcoe.c Jason Yan
2020-04-21 5:45 ` Hannes Reinecke [this message]
2020-04-22 4:07 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e25d02bd-101a-724a-e4e8-2686efc9a6ff@suse.de \
--to=hare@suse.de \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=yanaijie@huawei.com \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).