* [PATCH] scsi: fcoe: remove unneeded semicolon in fcoe.c
@ 2020-04-21 3:40 Jason Yan
2020-04-21 5:45 ` Hannes Reinecke
2020-04-22 4:07 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Jason Yan @ 2020-04-21 3:40 UTC (permalink / raw)
To: hare, jejb, martin.petersen, zhengbin13, linux-scsi, linux-kernel
Cc: Jason Yan
Fix the following coccicheck warning:
drivers/scsi/fcoe/fcoe.c:1918:3-4: Unneeded semicolon
drivers/scsi/fcoe/fcoe.c:1930:3-4: Unneeded semicolon
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/scsi/fcoe/fcoe.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
index 25dae9f0b205..cb41d166e0c0 100644
--- a/drivers/scsi/fcoe/fcoe.c
+++ b/drivers/scsi/fcoe/fcoe.c
@@ -1915,7 +1915,7 @@ static int fcoe_device_notification(struct notifier_block *notifier,
case FCOE_CTLR_ENABLED:
case FCOE_CTLR_UNUSED:
fcoe_ctlr_link_up(ctlr);
- };
+ }
} else if (fcoe_ctlr_link_down(ctlr)) {
switch (cdev->enabled) {
case FCOE_CTLR_DISABLED:
@@ -1927,7 +1927,7 @@ static int fcoe_device_notification(struct notifier_block *notifier,
stats->LinkFailureCount++;
put_cpu();
fcoe_clean_pending_queue(lport);
- };
+ }
}
out:
return rc;
--
2.21.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: fcoe: remove unneeded semicolon in fcoe.c
2020-04-21 3:40 [PATCH] scsi: fcoe: remove unneeded semicolon in fcoe.c Jason Yan
@ 2020-04-21 5:45 ` Hannes Reinecke
2020-04-22 4:07 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Hannes Reinecke @ 2020-04-21 5:45 UTC (permalink / raw)
To: Jason Yan, jejb, martin.petersen, zhengbin13, linux-scsi, linux-kernel
On 4/21/20 5:40 AM, Jason Yan wrote:
> Fix the following coccicheck warning:
>
> drivers/scsi/fcoe/fcoe.c:1918:3-4: Unneeded semicolon
> drivers/scsi/fcoe/fcoe.c:1930:3-4: Unneeded semicolon
>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
> drivers/scsi/fcoe/fcoe.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
> index 25dae9f0b205..cb41d166e0c0 100644
> --- a/drivers/scsi/fcoe/fcoe.c
> +++ b/drivers/scsi/fcoe/fcoe.c
> @@ -1915,7 +1915,7 @@ static int fcoe_device_notification(struct notifier_block *notifier,
> case FCOE_CTLR_ENABLED:
> case FCOE_CTLR_UNUSED:
> fcoe_ctlr_link_up(ctlr);
> - };
> + }
> } else if (fcoe_ctlr_link_down(ctlr)) {
> switch (cdev->enabled) {
> case FCOE_CTLR_DISABLED:
> @@ -1927,7 +1927,7 @@ static int fcoe_device_notification(struct notifier_block *notifier,
> stats->LinkFailureCount++;
> put_cpu();
> fcoe_clean_pending_queue(lport);
> - };
> + }
> }
> out:
> return rc;
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: fcoe: remove unneeded semicolon in fcoe.c
2020-04-21 3:40 [PATCH] scsi: fcoe: remove unneeded semicolon in fcoe.c Jason Yan
2020-04-21 5:45 ` Hannes Reinecke
@ 2020-04-22 4:07 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2020-04-22 4:07 UTC (permalink / raw)
To: Jason Yan
Cc: hare, jejb, martin.petersen, zhengbin13, linux-scsi, linux-kernel
Jason,
> Fix the following coccicheck warning:
>
> drivers/scsi/fcoe/fcoe.c:1918:3-4: Unneeded semicolon
> drivers/scsi/fcoe/fcoe.c:1930:3-4: Unneeded semicolon
Applied to 5.8/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-22 4:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-21 3:40 [PATCH] scsi: fcoe: remove unneeded semicolon in fcoe.c Jason Yan
2020-04-21 5:45 ` Hannes Reinecke
2020-04-22 4:07 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).