* [PATCH V4 0/2] Add reset entries for SDCC controllers
@ 2022-04-12 10:32 Shaik Sajida Bhanu
2022-04-12 10:32 ` [PATCH V4 1/2] dt-bindings: mmc: sdhci-msm: Add gcc resets strings Shaik Sajida Bhanu
2022-04-12 10:32 ` [PATCH V4 2/2] arm64: dts: qcom: sc7280: Add reset entries for SDCC controllers Shaik Sajida Bhanu
0 siblings, 2 replies; 5+ messages in thread
From: Shaik Sajida Bhanu @ 2022-04-12 10:32 UTC (permalink / raw)
To: ulf.hansson, robh+dt, krzk+dt, linux-mmc, devicetree,
linux-kernel, agross, bjorn.andersson, linux-arm-msm
Cc: quic_rampraka, quic_pragalla, quic_sartgarg, quic_nitirawa,
quic_sayalil, Shaik Sajida Bhanu
Changes since V3:
- Removed reset-names from bindings and DT file as suggested by
Stephen Boyd.
- Removed comments for resets as suggested by Stephen Boyd.
Changes since V2:
- Updated commit subject and comments in dtsi file.
- Added resets entry in sdhci-msm dt-bindings.
Changes since V1:
- Updated commit message, subject and comments in dtsi file as
suggested by Krzysztof Kozlowski.
Shaik Sajida Bhanu (2):
dt-bindings: mmc: sdhci-msm: Add gcc resets strings
arm64: dts: qcom: sc7280: Add reset entries for SDCC controllers
Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 5 +++++
arch/arm64/boot/dts/qcom/sc7280.dtsi | 4 ++++
2 files changed, 9 insertions(+)
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH V4 1/2] dt-bindings: mmc: sdhci-msm: Add gcc resets strings
2022-04-12 10:32 [PATCH V4 0/2] Add reset entries for SDCC controllers Shaik Sajida Bhanu
@ 2022-04-12 10:32 ` Shaik Sajida Bhanu
2022-04-12 11:59 ` Krzysztof Kozlowski
2022-04-12 14:18 ` Ulf Hansson
2022-04-12 10:32 ` [PATCH V4 2/2] arm64: dts: qcom: sc7280: Add reset entries for SDCC controllers Shaik Sajida Bhanu
1 sibling, 2 replies; 5+ messages in thread
From: Shaik Sajida Bhanu @ 2022-04-12 10:32 UTC (permalink / raw)
To: ulf.hansson, robh+dt, krzk+dt, linux-mmc, devicetree,
linux-kernel, agross, bjorn.andersson, linux-arm-msm
Cc: quic_rampraka, quic_pragalla, quic_sartgarg, quic_nitirawa,
quic_sayalil, Shaik Sajida Bhanu
Add gcc hardware reset supported strings for qcom-sdhci controller.
Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com>
---
Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
index 6216ed7..9f02461 100644
--- a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
+++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
@@ -76,6 +76,7 @@ Optional Properties:
"cpu-sdhc".
Please refer to Documentation/devicetree/bindings/
interconnect/ for more details.
+- resets: Phandle and reset specifier for the device's reset.
Example:
@@ -98,6 +99,8 @@ Example:
<&qnoc MASTER_CPU_ID &qnoc SLAVE_SDCC_ID>;
interconnect-names = "sdhc-ddr","cpu-sdhc";
+ resets = <&gcc GCC_SDCC1_BCR>;
+
qcom,dll-config = <0x000f642c>;
qcom,ddr-config = <0x80040868>;
};
@@ -118,6 +121,8 @@ Example:
clocks = <&gcc GCC_SDCC2_APPS_CLK>, <&gcc GCC_SDCC2_AHB_CLK>;
clock-names = "core", "iface";
+ resets = <&gcc GCC_SDCC2_BCR>;
+
qcom,dll-config = <0x0007642c>;
qcom,ddr-config = <0x80040868>;
};
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH V4 2/2] arm64: dts: qcom: sc7280: Add reset entries for SDCC controllers
2022-04-12 10:32 [PATCH V4 0/2] Add reset entries for SDCC controllers Shaik Sajida Bhanu
2022-04-12 10:32 ` [PATCH V4 1/2] dt-bindings: mmc: sdhci-msm: Add gcc resets strings Shaik Sajida Bhanu
@ 2022-04-12 10:32 ` Shaik Sajida Bhanu
1 sibling, 0 replies; 5+ messages in thread
From: Shaik Sajida Bhanu @ 2022-04-12 10:32 UTC (permalink / raw)
To: ulf.hansson, robh+dt, krzk+dt, linux-mmc, devicetree,
linux-kernel, agross, bjorn.andersson, linux-arm-msm
Cc: quic_rampraka, quic_pragalla, quic_sartgarg, quic_nitirawa,
quic_sayalil, Shaik Sajida Bhanu
Add gcc hardware reset entries for eMMC and SD card.
Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com>
---
arch/arm64/boot/dts/qcom/sc7280.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index f0b64be..e2393d1 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -881,6 +881,8 @@
mmc-hs400-1_8v;
mmc-hs400-enhanced-strobe;
+ resets = <&gcc GCC_SDCC1_BCR>;
+
sdhc1_opp_table: opp-table {
compatible = "operating-points-v2";
@@ -2686,6 +2688,8 @@
qcom,dll-config = <0x0007642c>;
+ resets = <&gcc GCC_SDCC2_BCR>;
+
sdhc2_opp_table: opp-table {
compatible = "operating-points-v2";
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH V4 1/2] dt-bindings: mmc: sdhci-msm: Add gcc resets strings
2022-04-12 10:32 ` [PATCH V4 1/2] dt-bindings: mmc: sdhci-msm: Add gcc resets strings Shaik Sajida Bhanu
@ 2022-04-12 11:59 ` Krzysztof Kozlowski
2022-04-12 14:18 ` Ulf Hansson
1 sibling, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-12 11:59 UTC (permalink / raw)
To: Shaik Sajida Bhanu, ulf.hansson, robh+dt, krzk+dt, linux-mmc,
devicetree, linux-kernel, agross, bjorn.andersson, linux-arm-msm
Cc: quic_rampraka, quic_pragalla, quic_sartgarg, quic_nitirawa, quic_sayalil
On 12/04/2022 12:32, Shaik Sajida Bhanu wrote:
> Add gcc hardware reset supported strings for qcom-sdhci controller.
>
> Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com>
> ---
> Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 5 +++++
> 1 file changed, 5 insertions(+)
>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V4 1/2] dt-bindings: mmc: sdhci-msm: Add gcc resets strings
2022-04-12 10:32 ` [PATCH V4 1/2] dt-bindings: mmc: sdhci-msm: Add gcc resets strings Shaik Sajida Bhanu
2022-04-12 11:59 ` Krzysztof Kozlowski
@ 2022-04-12 14:18 ` Ulf Hansson
1 sibling, 0 replies; 5+ messages in thread
From: Ulf Hansson @ 2022-04-12 14:18 UTC (permalink / raw)
To: Shaik Sajida Bhanu
Cc: robh+dt, krzk+dt, linux-mmc, devicetree, linux-kernel, agross,
bjorn.andersson, linux-arm-msm, quic_rampraka, quic_pragalla,
quic_sartgarg, quic_nitirawa, quic_sayalil, Bhupesh Sharma
+ Bhupesh
On Tue, 12 Apr 2022 at 12:33, Shaik Sajida Bhanu
<quic_c_sbhanu@quicinc.com> wrote:
>
> Add gcc hardware reset supported strings for qcom-sdhci controller.
>
> Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com>
As stated earlier, I would really like to see the binding being
converted to the yaml format first. It seems like Bhupesh is working
on the conversion [1].
Kind regards
Uffe
[1]
https://www.spinics.net/lists/linux-arm-msm/msg107809.html
> ---
> Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
> index 6216ed7..9f02461 100644
> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
> @@ -76,6 +76,7 @@ Optional Properties:
> "cpu-sdhc".
> Please refer to Documentation/devicetree/bindings/
> interconnect/ for more details.
> +- resets: Phandle and reset specifier for the device's reset.
>
> Example:
>
> @@ -98,6 +99,8 @@ Example:
> <&qnoc MASTER_CPU_ID &qnoc SLAVE_SDCC_ID>;
> interconnect-names = "sdhc-ddr","cpu-sdhc";
>
> + resets = <&gcc GCC_SDCC1_BCR>;
> +
> qcom,dll-config = <0x000f642c>;
> qcom,ddr-config = <0x80040868>;
> };
> @@ -118,6 +121,8 @@ Example:
> clocks = <&gcc GCC_SDCC2_APPS_CLK>, <&gcc GCC_SDCC2_AHB_CLK>;
> clock-names = "core", "iface";
>
> + resets = <&gcc GCC_SDCC2_BCR>;
> +
> qcom,dll-config = <0x0007642c>;
> qcom,ddr-config = <0x80040868>;
> };
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-04-12 14:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-12 10:32 [PATCH V4 0/2] Add reset entries for SDCC controllers Shaik Sajida Bhanu
2022-04-12 10:32 ` [PATCH V4 1/2] dt-bindings: mmc: sdhci-msm: Add gcc resets strings Shaik Sajida Bhanu
2022-04-12 11:59 ` Krzysztof Kozlowski
2022-04-12 14:18 ` Ulf Hansson
2022-04-12 10:32 ` [PATCH V4 2/2] arm64: dts: qcom: sc7280: Add reset entries for SDCC controllers Shaik Sajida Bhanu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).