From: Joe Perches <joe@perches.com>
To: Rob Herring <robh@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Andy Whitcroft <apw@canonical.com>
Subject: Re: [PATCH v2] checkpatch: DT bindings should be a separate patch
Date: Fri, 10 Aug 2018 11:14:58 -0700 [thread overview]
Message-ID: <e2975022a0440b642a7a68e2e5be4764b468143e.camel@perches.com> (raw)
In-Reply-To: <20180810170513.26284-1-robh@kernel.org>
On Fri, 2018-08-10 at 11:05 -0600, Rob Herring wrote:
> Devicetree bindings should be their own patch as documented in
> Documentation/devicetree/bindings/submitting-patches.txt section I.1.
> This is because bindings are logically independent from a driver
> implementation, they have a different maintainer (even though they often
> are applied via the same tree), and it makes for a cleaner history in
> the DT only tree created with git-filter-branch.
>
> Cc: Andy Whitcroft <apw@canonical.com>
> Cc: Joe Perches <joe@perches.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> v2:
> - Add doc pointer to warning
> - Simplify logic
>
> Joe, this makes $is_binding_patch an empty value when the regex doesn't
> match rather than 0 which would be more logical IMO. It seems to work
> fine, but I'm not sure if there's a better way to do it.
Hi Rob. This looks fine with a couple nits.
> scripts/checkpatch.pl | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index a9c05506e325..f9aba4bc41ce 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2236,6 +2236,7 @@ sub process {
> our $clean = 1;
> my $signoff = 0;
> my $is_patch = 0;
> + my $is_binding_patch = -1;
> my $in_header_lines = $file ? 0 : 1;
> my $in_commit_log = 0; #Scanning lines before patch
> my $has_commit_log = 0; #Encountered lines before patch
> @@ -2485,6 +2486,19 @@ sub process {
> $check = $check_orig;
> }
> $checklicenseline = 1;
> +
> + if ($realfile !~ /^MAINTAINERS/) {
> + my $last_binding_patch = $is_binding_patch;
> +
> + $is_binding_patch = ($realfile =~ m@^(?:Documentation/devicetree/|include/dt-bindings/)@);
If you want 0/1 you could use:
$is_binding_patch = () = $realfile =~ m@^(?:Documentation/devicetree/|include/dt-bindings/)@;
(perl syntax is a constant joy)
> +
> + if (($last_binding_patch != -1) &&
> + ($last_binding_patch ^ $is_binding_patch)) {
> + WARN("DT_SPLIT_BINDING_PATCH",
> + "DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.txt");
This is missing a '\n' newline at the end of the message.
> + }
> + }
> +
> next;
> }
>
prev parent reply other threads:[~2018-08-10 18:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-10 17:05 [PATCH v2] checkpatch: DT bindings should be a separate patch Rob Herring
2018-08-10 18:14 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2975022a0440b642a7a68e2e5be4764b468143e.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).