From: Matthias Brugger <matthias.bgg@gmail.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
sean.wang@mediatek.com, linus.walleij@linaro.org,
robh+dt@kernel.org
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, amit.kucheria@linaro.org
Subject: Re: [PATCH 4/5] pinctrl: mediatek: pinctrl-mtk-common-v2: Make eint_m u16
Date: Thu, 11 Oct 2018 11:29:27 +0200 [thread overview]
Message-ID: <e2df8c8a-34a1-ef32-838d-776053b1b707@gmail.com> (raw)
In-Reply-To: <20181008191411.32555-5-manivannan.sadhasivam@linaro.org>
On 08/10/2018 21:14, Manivannan Sadhasivam wrote:
> For SoC's which lacks EINT support, U16_MAX is assigned to both eint_m
> and eint_n through macro NO_EINT_SUPPORT. This will generate integer
> overflow warning because eint_m is declared as u8 type. Hence modify
> the eint_m type to u16.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.h b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.h
> index 991c1c56670c..6d24522739d9 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.h
> +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.h
> @@ -154,7 +154,7 @@ struct mtk_func_desc {
> * @eitn_n: the eint number for this pin
> */
> struct mtk_eint_desc {
> - u8 eint_m;
> + u16 eint_m;
> u16 eint_n;
> };
>
>
next prev parent reply other threads:[~2018-10-11 9:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 19:14 [PATCH 0/5] Add initial pinctrl support for MT6797 SoC Manivannan Sadhasivam
2018-10-08 19:14 ` [PATCH 1/5] dt-bindings: pinctrl: Add devicetree constants " Manivannan Sadhasivam
2018-10-08 19:14 ` [PATCH 2/5] arm64: dts: mediatek: mt6797: Add pinctrl support Manivannan Sadhasivam
2018-10-18 14:24 ` Sean Wang
[not found] ` <CAGp9LzoSA=06CF_yNMOHnfmRnFzpBA4R2YGhbWmxdSKci2uF0w@mail.gmail.com>
2018-10-19 8:27 ` Manivannan Sadhasivam
2018-10-08 19:14 ` [PATCH 3/5] arm64: dts: mediatek: x20: Add pinmux support for UART1 Manivannan Sadhasivam
2018-10-08 19:14 ` [PATCH 4/5] pinctrl: mediatek: pinctrl-mtk-common-v2: Make eint_m u16 Manivannan Sadhasivam
2018-10-11 9:29 ` Matthias Brugger [this message]
2018-10-15 14:18 ` Linus Walleij
2018-10-08 19:14 ` [PATCH 5/5] pinctrl: mediatek: Add initial pinctrl driver for MT6797 SoC Manivannan Sadhasivam
2018-10-11 9:30 ` Matthias Brugger
2018-10-11 15:50 ` Matthias Brugger
2018-10-11 16:44 ` Manivannan Sadhasivam
2018-10-16 13:58 ` Matthias Brugger
2018-10-18 15:06 ` Sean Wang
2018-10-30 12:51 ` Linus Walleij
2018-10-30 23:45 ` Sean Wang
2018-10-16 8:36 ` [PATCH 0/5] Add initial pinctrl support " Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2df8c8a-34a1-ef32-838d-776053b1b707@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=amit.kucheria@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).