* [PATCH v4] kernel/crash_core.c : remove redundant check of ck_cmdline
@ 2022-05-06 4:32 lizhe
2022-05-06 5:07 ` Baoquan He
2022-05-06 5:28 ` Kari Argillander
0 siblings, 2 replies; 3+ messages in thread
From: lizhe @ 2022-05-06 4:32 UTC (permalink / raw)
To: bhe, vgoyal, dyoung, prudo; +Cc: kexec, linux-kernel, lizhe
At the end of get_last_crashkernel(), the judgement of ck_cmdline is
obviously unnecessary and causes redundance, let's clean it up.
Signed-off-by: lizhe <sensor1010@163.com>
Acked-by: Baoquan He <bhe@redhat.com>
Acked-by: Philipp Rudo <prudo@redhat.com>
---
kernel/crash_core.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/kernel/crash_core.c b/kernel/crash_core.c
index 256cf6db573c..c232f01a2c54 100644
--- a/kernel/crash_core.c
+++ b/kernel/crash_core.c
@@ -222,9 +222,6 @@ static __init char *get_last_crashkernel(char *cmdline,
p = strstr(p+1, name);
}
- if (!ck_cmdline)
- return NULL;
-
return ck_cmdline;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v4] kernel/crash_core.c : remove redundant check of ck_cmdline
2022-05-06 4:32 [PATCH v4] kernel/crash_core.c : remove redundant check of ck_cmdline lizhe
@ 2022-05-06 5:07 ` Baoquan He
2022-05-06 5:28 ` Kari Argillander
1 sibling, 0 replies; 3+ messages in thread
From: Baoquan He @ 2022-05-06 5:07 UTC (permalink / raw)
To: lizhe, Andrew Morton; +Cc: vgoyal, dyoung, prudo, kexec, linux-kernel
Add Andrew to CC list
On 05/05/22 at 09:32pm, lizhe wrote:
> At the end of get_last_crashkernel(), the judgement of ck_cmdline is
> obviously unnecessary and causes redundance, let's clean it up.
>
> Signed-off-by: lizhe <sensor1010@163.com>
> Acked-by: Baoquan He <bhe@redhat.com>
> Acked-by: Philipp Rudo <prudo@redhat.com>
> ---
> kernel/crash_core.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/kernel/crash_core.c b/kernel/crash_core.c
> index 256cf6db573c..c232f01a2c54 100644
> --- a/kernel/crash_core.c
> +++ b/kernel/crash_core.c
> @@ -222,9 +222,6 @@ static __init char *get_last_crashkernel(char *cmdline,
> p = strstr(p+1, name);
> }
>
> - if (!ck_cmdline)
> - return NULL;
> -
> return ck_cmdline;
> }
>
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v4] kernel/crash_core.c : remove redundant check of ck_cmdline
2022-05-06 4:32 [PATCH v4] kernel/crash_core.c : remove redundant check of ck_cmdline lizhe
2022-05-06 5:07 ` Baoquan He
@ 2022-05-06 5:28 ` Kari Argillander
1 sibling, 0 replies; 3+ messages in thread
From: Kari Argillander @ 2022-05-06 5:28 UTC (permalink / raw)
To: lizhe, bhe, vgoyal, dyoung, prudo; +Cc: kexec, linux-kernel
On 6.5.2022 7.32, lizhe wrote:
> At the end of get_last_crashkernel(), the judgement of ck_cmdline is
> obviously unnecessary and causes redundance, let's clean it up.
>
> Signed-off-by: lizhe <sensor1010@163.com>
Signed off by should be real name. Greg ask this already, but you did
not ever answer [1].
[1]: https://lore.kernel.org/lkml/Yi2nfjH7aph6CuiX@kroah.com/
> Acked-by: Baoquan He <bhe@redhat.com>
> Acked-by: Philipp Rudo <prudo@redhat.com>
> ---
> kernel/crash_core.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/kernel/crash_core.c b/kernel/crash_core.c
> index 256cf6db573c..c232f01a2c54 100644
> --- a/kernel/crash_core.c
> +++ b/kernel/crash_core.c
> @@ -222,9 +222,6 @@ static __init char *get_last_crashkernel(char *cmdline,
> p = strstr(p+1, name);
> }
>
> - if (!ck_cmdline)
> - return NULL;
> -
> return ck_cmdline;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-06 5:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-06 4:32 [PATCH v4] kernel/crash_core.c : remove redundant check of ck_cmdline lizhe
2022-05-06 5:07 ` Baoquan He
2022-05-06 5:28 ` Kari Argillander
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).